fix: Make test suite names match the directory name (#5597)

This change fixes the suite names all around the test files, to make them match to the folder name in which this test files are located. Also, the RCL test files are relocated to the consensus folder, because they are testing consensus functionality.

Author: Afformativ

src/test/app/Check_test.cpp

@@ -2729,6 +2729,6 @@ class Check_test : public beast::unit_test::suite
     }
 };
 
-BEAST_DEFINE_TESTSUITE(Check, tx, ripple);
+BEAST_DEFINE_TESTSUITE(Check, app, ripple);
 
 }  // namespace ripple

src/test/app/CrossingLimits_test.cpp

@@ -530,7 +530,7 @@ class CrossingLimits_test : public beast::unit_test::suite
     }
 };
 
-BEAST_DEFINE_TESTSUITE_MANUAL_PRIO(CrossingLimits, tx, ripple, 10);
+BEAST_DEFINE_TESTSUITE_MANUAL_PRIO(CrossingLimits, app, ripple, 10);
 
 }  // namespace test
 }  // namespace ripple

src/test/app/DNS_test.cpp

@@ -128,7 +128,7 @@ class DNS_test : public beast::unit_test::suite
     }
 };
 
-BEAST_DEFINE_TESTSUITE_MANUAL_PRIO(DNS, ripple_data, ripple, 20);
+BEAST_DEFINE_TESTSUITE_MANUAL_PRIO(DNS, app, ripple, 20);
 
 }  // namespace test
 }  // namespace ripple

src/test/app/FeeVote_test.cpp

@@ -100,7 +100,7 @@ class FeeVote_test : public beast::unit_test::suite
     }
 };
 
-BEAST_DEFINE_TESTSUITE(FeeVote, server, ripple);
+BEAST_DEFINE_TESTSUITE(FeeVote, app, ripple);
 
 }  // namespace test
 }  // namespace ripple

src/test/app/FixNFTokenPageLinks_test.cpp

@@ -663,6 +663,6 @@ class FixNFTokenPageLinks_test : public beast::unit_test::suite
     }
 };
 
-BEAST_DEFINE_TESTSUITE(FixNFTokenPageLinks, tx, ripple);
+BEAST_DEFINE_TESTSUITE(FixNFTokenPageLinks, app, ripple);
 
 }  // namespace ripple

src/test/ledger/Invariants_test.cpp renamed to src/test/app/Invariants_test.cpp

@@ -1626,6 +1626,6 @@ class Invariants_test : public beast::unit_test::suite
     }
 };
 
-BEAST_DEFINE_TESTSUITE(Invariants, ledger, ripple);
+BEAST_DEFINE_TESTSUITE(Invariants, app, ripple);
 
 }  // namespace ripple

src/test/app/LoadFeeTrack_test.cpp

@@ -87,6 +87,6 @@ class LoadFeeTrack_test : public beast::unit_test::suite
     }
 };
 
-BEAST_DEFINE_TESTSUITE(LoadFeeTrack, ripple_core, ripple);
+BEAST_DEFINE_TESTSUITE(LoadFeeTrack, app, ripple);
 
 }  // namespace ripple

src/test/app/MPToken_test.cpp

@@ -2797,7 +2797,7 @@ class MPToken_test : public beast::unit_test::suite
     }
 };
 
-BEAST_DEFINE_TESTSUITE_PRIO(MPToken, tx, ripple, 2);
+BEAST_DEFINE_TESTSUITE_PRIO(MPToken, app, ripple, 2);
 
 }  // namespace test
 }  // namespace ripple

src/test/app/NFTokenAuth_test.cpp

@@ -619,6 +619,6 @@ class NFTokenAuth_test : public beast::unit_test::suite
     }
 };
 
-BEAST_DEFINE_TESTSUITE_PRIO(NFTokenAuth, tx, ripple, 2);
+BEAST_DEFINE_TESTSUITE_PRIO(NFTokenAuth, app, ripple, 2);
 
 }  // namespace ripple

src/test/app/NFTokenBurn_test.cpp

@@ -1454,10 +1454,10 @@ class NFTokenBurnAllFeatures_test : public NFTokenBurnBaseUtil_test
     }
 };
 
-BEAST_DEFINE_TESTSUITE_PRIO(NFTokenBurnBaseUtil, tx, ripple, 3);
-BEAST_DEFINE_TESTSUITE_PRIO(NFTokenBurnWOfixFungTokens, tx, ripple, 3);
-BEAST_DEFINE_TESTSUITE_PRIO(NFTokenBurnWOFixTokenRemint, tx, ripple, 3);
-BEAST_DEFINE_TESTSUITE_PRIO(NFTokenBurnWOFixNFTPageLinks, tx, ripple, 3);
-BEAST_DEFINE_TESTSUITE_PRIO(NFTokenBurnAllFeatures, tx, ripple, 3);
+BEAST_DEFINE_TESTSUITE_PRIO(NFTokenBurnBaseUtil, app, ripple, 3);
+BEAST_DEFINE_TESTSUITE_PRIO(NFTokenBurnWOfixFungTokens, app, ripple, 3);
+BEAST_DEFINE_TESTSUITE_PRIO(NFTokenBurnWOFixTokenRemint, app, ripple, 3);
+BEAST_DEFINE_TESTSUITE_PRIO(NFTokenBurnWOFixNFTPageLinks, app, ripple, 3);
+BEAST_DEFINE_TESTSUITE_PRIO(NFTokenBurnAllFeatures, app, ripple, 3);
 
 }  // namespace ripple