Skip to content

Commit dc8b37a

Browse files
authored
refactor: Modularise ledger (#5493)
This change moves the ledger code to libxrpl.
1 parent 617a895 commit dc8b37a

File tree

161 files changed

+244
-272
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

161 files changed

+244
-272
lines changed

.github/scripts/levelization/results/loops.txt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,6 @@ Loop: test.jtx test.unit_test
77
Loop: xrpld.app xrpld.core
88
xrpld.app > xrpld.core
99

10-
Loop: xrpld.app xrpld.ledger
11-
xrpld.app > xrpld.ledger
12-
1310
Loop: xrpld.app xrpld.overlay
1411
xrpld.overlay > xrpld.app
1512

.github/scripts/levelization/results/ordering.txt

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@ libxrpl.basics > xrpl.basics
22
libxrpl.crypto > xrpl.basics
33
libxrpl.json > xrpl.basics
44
libxrpl.json > xrpl.json
5+
libxrpl.ledger > xrpl.basics
6+
libxrpl.ledger > xrpl.json
7+
libxrpl.ledger > xrpl.ledger
8+
libxrpl.ledger > xrpl.protocol
59
libxrpl.net > xrpl.basics
610
libxrpl.net > xrpl.net
711
libxrpl.protocol > xrpl.basics
@@ -21,11 +25,11 @@ test.app > test.unit_test
2125
test.app > xrpl.basics
2226
test.app > xrpld.app
2327
test.app > xrpld.core
24-
test.app > xrpld.ledger
2528
test.app > xrpld.nodestore
2629
test.app > xrpld.overlay
2730
test.app > xrpld.rpc
2831
test.app > xrpl.json
32+
test.app > xrpl.ledger
2933
test.app > xrpl.protocol
3034
test.app > xrpl.resource
3135
test.basics > test.jtx
@@ -44,8 +48,8 @@ test.consensus > test.unit_test
4448
test.consensus > xrpl.basics
4549
test.consensus > xrpld.app
4650
test.consensus > xrpld.consensus
47-
test.consensus > xrpld.ledger
4851
test.consensus > xrpl.json
52+
test.consensus > xrpl.ledger
4953
test.core > test.jtx
5054
test.core > test.toplevel
5155
test.core > test.unit_test
@@ -63,9 +67,9 @@ test.json > xrpl.json
6367
test.jtx > xrpl.basics
6468
test.jtx > xrpld.app
6569
test.jtx > xrpld.core
66-
test.jtx > xrpld.ledger
6770
test.jtx > xrpld.rpc
6871
test.jtx > xrpl.json
72+
test.jtx > xrpl.ledger
6973
test.jtx > xrpl.net
7074
test.jtx > xrpl.protocol
7175
test.jtx > xrpl.resource
@@ -75,7 +79,7 @@ test.ledger > test.toplevel
7579
test.ledger > xrpl.basics
7680
test.ledger > xrpld.app
7781
test.ledger > xrpld.core
78-
test.ledger > xrpld.ledger
82+
test.ledger > xrpl.ledger
7983
test.ledger > xrpl.protocol
8084
test.nodestore > test.jtx
8185
test.nodestore > test.toplevel
@@ -135,6 +139,8 @@ test.toplevel > xrpl.json
135139
test.unit_test > xrpl.basics
136140
tests.libxrpl > xrpl.basics
137141
xrpl.json > xrpl.basics
142+
xrpl.ledger > xrpl.basics
143+
xrpl.ledger > xrpl.protocol
138144
xrpl.net > xrpl.basics
139145
xrpl.protocol > xrpl.basics
140146
xrpl.protocol > xrpl.json
@@ -151,6 +157,7 @@ xrpld.app > xrpld.consensus
151157
xrpld.app > xrpld.nodestore
152158
xrpld.app > xrpld.perflog
153159
xrpld.app > xrpl.json
160+
xrpld.app > xrpl.ledger
154161
xrpld.app > xrpl.net
155162
xrpld.app > xrpl.protocol
156163
xrpld.app > xrpl.resource
@@ -163,9 +170,6 @@ xrpld.core > xrpl.basics
163170
xrpld.core > xrpl.json
164171
xrpld.core > xrpl.net
165172
xrpld.core > xrpl.protocol
166-
xrpld.ledger > xrpl.basics
167-
xrpld.ledger > xrpl.json
168-
xrpld.ledger > xrpl.protocol
169173
xrpld.nodestore > xrpl.basics
170174
xrpld.nodestore > xrpld.core
171175
xrpld.nodestore > xrpld.unity
@@ -186,9 +190,9 @@ xrpld.perflog > xrpl.basics
186190
xrpld.perflog > xrpl.json
187191
xrpld.rpc > xrpl.basics
188192
xrpld.rpc > xrpld.core
189-
xrpld.rpc > xrpld.ledger
190193
xrpld.rpc > xrpld.nodestore
191194
xrpld.rpc > xrpl.json
195+
xrpld.rpc > xrpl.ledger
192196
xrpld.rpc > xrpl.net
193197
xrpld.rpc > xrpl.protocol
194198
xrpld.rpc > xrpl.resource

cmake/RippledCore.cmake

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,12 @@ target_link_libraries(xrpl.libxrpl.net PUBLIC
111111
add_module(xrpl server)
112112
target_link_libraries(xrpl.libxrpl.server PUBLIC xrpl.libxrpl.protocol)
113113

114+
add_module(xrpl ledger)
115+
target_link_libraries(xrpl.libxrpl.ledger PUBLIC
116+
xrpl.libxrpl.basics
117+
xrpl.libxrpl.json
118+
xrpl.libxrpl.protocol
119+
)
114120

115121
add_library(xrpl.libxrpl)
116122
set_target_properties(xrpl.libxrpl PROPERTIES OUTPUT_NAME xrpl)
@@ -131,6 +137,7 @@ target_link_modules(xrpl PUBLIC
131137
resource
132138
server
133139
net
140+
ledger
134141
)
135142

136143
# All headers in libxrpl are in modules.

cmake/RippledInstall.cmake

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ install (
1818
xrpl.libxrpl.json
1919
xrpl.libxrpl.protocol
2020
xrpl.libxrpl.resource
21+
xrpl.libxrpl.ledger
2122
xrpl.libxrpl.server
2223
xrpl.libxrpl.net
2324
xrpl.libxrpl

src/xrpld/ledger/ApplyView.h renamed to include/xrpl/ledger/ApplyView.h

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,10 @@
2020
#ifndef RIPPLE_LEDGER_APPLYVIEW_H_INCLUDED
2121
#define RIPPLE_LEDGER_APPLYVIEW_H_INCLUDED
2222

23-
#include <xrpld/ledger/RawView.h>
24-
#include <xrpld/ledger/ReadView.h>
25-
2623
#include <xrpl/basics/safe_cast.h>
2724
#include <xrpl/beast/utility/instrumentation.h>
25+
#include <xrpl/ledger/RawView.h>
26+
#include <xrpl/ledger/ReadView.h>
2827

2928
namespace ripple {
3029

src/xrpld/ledger/ApplyViewImpl.h renamed to include/xrpl/ledger/ApplyViewImpl.h

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,8 @@
2020
#ifndef RIPPLE_LEDGER_APPLYVIEWIMPL_H_INCLUDED
2121
#define RIPPLE_LEDGER_APPLYVIEWIMPL_H_INCLUDED
2222

23-
#include <xrpld/ledger/OpenView.h>
24-
#include <xrpld/ledger/detail/ApplyViewBase.h>
25-
23+
#include <xrpl/ledger/OpenView.h>
24+
#include <xrpl/ledger/detail/ApplyViewBase.h>
2625
#include <xrpl/protocol/STAmount.h>
2726
#include <xrpl/protocol/TER.h>
2827

src/xrpld/ledger/BookDirs.h renamed to include/xrpl/ledger/BookDirs.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,8 @@
2020
#ifndef RIPPLE_LEDGER_BOOK_DIRS_H_INCLUDED
2121
#define RIPPLE_LEDGER_BOOK_DIRS_H_INCLUDED
2222

23-
#include <xrpld/ledger/ReadView.h>
24-
2523
#include <xrpl/beast/utility/Journal.h>
24+
#include <xrpl/ledger/ReadView.h>
2625

2726
namespace ripple {
2827

File renamed without changes.

src/xrpld/ledger/CachedView.h renamed to include/xrpl/ledger/CachedView.h

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,9 @@
2020
#ifndef RIPPLE_LEDGER_CACHEDVIEW_H_INCLUDED
2121
#define RIPPLE_LEDGER_CACHEDVIEW_H_INCLUDED
2222

23-
#include <xrpld/ledger/CachedSLEs.h>
24-
#include <xrpld/ledger/ReadView.h>
25-
2623
#include <xrpl/basics/hardened_hash.h>
24+
#include <xrpl/ledger/CachedSLEs.h>
25+
#include <xrpl/ledger/ReadView.h>
2726

2827
#include <mutex>
2928
#include <type_traits>

src/xrpld/app/misc/CredentialHelpers.h renamed to include/xrpl/ledger/CredentialHelpers.h

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,11 @@
2020
#ifndef RIPPLE_APP_MISC_CREDENTIALHELPERS_H_INCLUDED
2121
#define RIPPLE_APP_MISC_CREDENTIALHELPERS_H_INCLUDED
2222

23-
#include <xrpld/ledger/ApplyView.h>
24-
#include <xrpld/ledger/ReadView.h>
25-
2623
#include <xrpl/basics/Log.h>
2724
#include <xrpl/basics/base_uint.h>
2825
#include <xrpl/beast/utility/Journal.h>
26+
#include <xrpl/ledger/ApplyView.h>
27+
#include <xrpl/ledger/ReadView.h>
2928
#include <xrpl/protocol/AccountID.h>
3029
#include <xrpl/protocol/STArray.h>
3130
#include <xrpl/protocol/STTx.h>

0 commit comments

Comments
 (0)