Skip to content

Commit 8c31ccc

Browse files
committed
fix: address review feedback on async-std deprecation PR
- Cargo.toml: correct comment to say "compile_error" not "runtime panic" - build_and_lint.yml: add note for contributors to manually add new features
1 parent 9f40073 commit 8c31ccc

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

.github/workflows/build_and_lint.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ jobs:
3636
- name: Clippy
3737
# Exclude async-std-rt: it is deprecated (RUSTSEC-2025-0052) and emits a
3838
# compile_error! at crate level, so --all-features would always fail.
39+
# NOTE: When adding new Cargo features, add them to this list manually.
3940
run: cargo clippy --features std,tokio-rt,embassy-rt,actix-rt,futures-rt,smol-rt,core,wallet,models,utils,helpers,json-rpc,websocket,cli -- -D warnings
4041

4142
- name: Build (default)

Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ embassy-futures = { version = "0.1.1" }
9393
embedded-nal-async = { version = "0.8.0", optional = true }
9494
actix-rt = { version = "2.10.0", optional = true }
9595
# DEPRECATED: async-std has been discontinued (RUSTSEC-2025-0052). Use smol-rt instead.
96-
# Retained so the async-std-rt feature gate resolves; enabling it triggers a runtime panic.
96+
# Retained so the async-std-rt feature gate resolves; enabling it emits a compile_error.
9797
async-std = { version = "1.13.0", optional = true }
9898
futures-executor = { version = "0.3.30", optional = true }
9999
futures-timer = { version = "3.0.3", optional = true }

0 commit comments

Comments
 (0)