Remove Obsolete API (#2366)

Author: Alirexaa

src/HealthChecks.Sqlite/DependencyInjection/SqliteHealthCheckBuilderExtensions.cs

@@ -40,47 +40,6 @@ public static IHealthChecksBuilder AddSqlite(
         return builder.AddSqlite(_ => connectionString, healthQuery, configure, name, failureStatus, tags, timeout);
     }
 
-    /// <summary>
-    /// Add a health check for Sqlite databases.
-    /// </summary>
-    /// <param name="builder">The <see cref="IHealthChecksBuilder"/>.</param>
-    /// <param name="connectionStringFactory">A factory to build the Sqlite connection string to be used.</param>
-    /// <param name="healthQuery">The query to be used in check.</param>
-    /// <param name="configure">An optional action to allow additional Sqlite specific configuration.</param>
-    /// <param name="name">The health check name. Optional. If <c>null</c> the type name 'sqlite' will be used for the name.</param>
-    /// <param name="failureStatus">
-    /// The <see cref="HealthStatus"/> that should be reported when the health check fails. Optional. If <c>null</c> then
-    /// the default status of <see cref="HealthStatus.Unhealthy"/> will be reported.
-    /// </param>
-    /// <param name="tags">A list of tags that can be used to filter sets of health checks. Optional.</param>
-    /// <param name="timeout">An optional <see cref="TimeSpan"/> representing the timeout of the check.</param>
-    /// <returns>The <see cref="IHealthChecksBuilder"/>.</returns>
-    [Obsolete("This method is obsolete and will be removed in a future version. use AddSqlite with same parameters.")]
-    public static IHealthChecksBuilder AddOracle(
-        this IHealthChecksBuilder builder,
-        Func<IServiceProvider, string> connectionStringFactory,
-        string healthQuery = HEALTH_QUERY,
-        Action<SqliteConnection>? configure = null,
-        string? name = default,
-        HealthStatus? failureStatus = default,
-        IEnumerable<string>? tags = default,
-        TimeSpan? timeout = default)
-    {
-        Guard.ThrowIfNull(connectionStringFactory);
-
-        return builder.Add(new HealthCheckRegistration(
-            name ?? NAME,
-            sp => new SqliteHealthCheck(new SqliteHealthCheckOptions
-            {
-                ConnectionString = connectionStringFactory(sp),
-                CommandText = healthQuery,
-                Configure = configure,
-            }),
-            failureStatus,
-            tags,
-            timeout));
-    }
-
     /// <summary>
     /// Add a health check for Sqlite databases.
     /// </summary>

test/HealthChecks.Sqlite.Tests/HealthChecks.Sqlite.approved.txt

@@ -18,9 +18,6 @@ namespace Microsoft.Extensions.DependencyInjection
 {
     public static class SqliteHealthCheckBuilderExtensions
     {
-        [System.Obsolete("This method is obsolete and will be removed in a future version. use AddSqlite wi" +
-            "th same parameters.")]
-        public static Microsoft.Extensions.DependencyInjection.IHealthChecksBuilder AddOracle(this Microsoft.Extensions.DependencyInjection.IHealthChecksBuilder builder, System.Func<System.IServiceProvider, string> connectionStringFactory, string healthQuery = "select name from sqlite_master where type='table'", System.Action<Microsoft.Data.Sqlite.SqliteConnection>? configure = null, string? name = null, Microsoft.Extensions.Diagnostics.HealthChecks.HealthStatus? failureStatus = default, System.Collections.Generic.IEnumerable<string>? tags = null, System.TimeSpan? timeout = default) { }
         public static Microsoft.Extensions.DependencyInjection.IHealthChecksBuilder AddSqlite(this Microsoft.Extensions.DependencyInjection.IHealthChecksBuilder builder, HealthChecks.Sqlite.SqliteHealthCheckOptions options, string? name = null, Microsoft.Extensions.Diagnostics.HealthChecks.HealthStatus? failureStatus = default, System.Collections.Generic.IEnumerable<string>? tags = null, System.TimeSpan? timeout = default) { }
         public static Microsoft.Extensions.DependencyInjection.IHealthChecksBuilder AddSqlite(this Microsoft.Extensions.DependencyInjection.IHealthChecksBuilder builder, System.Func<System.IServiceProvider, string> connectionStringFactory, string healthQuery = "select name from sqlite_master where type='table'", System.Action<Microsoft.Data.Sqlite.SqliteConnection>? configure = null, string? name = null, Microsoft.Extensions.Diagnostics.HealthChecks.HealthStatus? failureStatus = default, System.Collections.Generic.IEnumerable<string>? tags = null, System.TimeSpan? timeout = default) { }
         public static Microsoft.Extensions.DependencyInjection.IHealthChecksBuilder AddSqlite(this Microsoft.Extensions.DependencyInjection.IHealthChecksBuilder builder, string connectionString, string healthQuery = "select name from sqlite_master where type='table'", System.Action<Microsoft.Data.Sqlite.SqliteConnection>? configure = null, string? name = null, Microsoft.Extensions.Diagnostics.HealthChecks.HealthStatus? failureStatus = default, System.Collections.Generic.IEnumerable<string>? tags = null, System.TimeSpan? timeout = default) { }