Skip to content

Commit 910997f

Browse files
authored
Merge pull request #32 from Xatta-Trone/main
add pg fe
2 parents 33058a1 + ce08821 commit 910997f

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

app/Http/Controllers/Api/User/AuthController.php

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,11 @@ public function register(RegisterRequest $request)
2828
$validatedData = $request->validated();
2929
// dd($validatedData);
3030
//data pre-process
31-
$student_id_without_prefix = $this->studentIdWithoutPrefix($validatedData['student_id']);
32-
$merit = sprintf("%04d", $validatedData['merit_position']);
31+
if ($request->grad_level == "UG") {
32+
$student_id_without_prefix = $this->studentIdWithoutPrefix($validatedData['student_id']);
33+
} else {
34+
$student_id_without_prefix = $validatedData['student_id'];
35+
}
3336

3437
//check if already registered
3538
$checkinUsers = User::where('student_id', $student_id_without_prefix)->orWhere('email', '=', $request->email)->get()->first();
@@ -55,7 +58,7 @@ public function register(RegisterRequest $request)
5558
}
5659

5760

58-
if ($this->formatMeritPosition($checkForStudentInDB->merit) != $request->merit_position) {
61+
if ($request->grad_level == "UG" && $this->formatMeritPosition($checkForStudentInDB->merit) != $request->merit_position) {
5962
return response()->json([
6063
'message' => 'DATA_NOT_MATCHING',
6164
'status' => 'false',
@@ -69,7 +72,7 @@ public function register(RegisterRequest $request)
6972
], 422);
7073
}
7174

72-
return $this->createNewAccount(array_merge($request->validated(), ['student_id' => $student_id_without_prefix, 'name' => $checkForStudentInDB->student_name]), $checkForStudentInDB->id);
75+
return $this->createNewAccount(array_merge($request->validated(), ['student_id' => $student_id_without_prefix, 'name' => $checkForStudentInDB->student_name, 'grad_level' => $request->grad_level]), $checkForStudentInDB->id);
7376

7477
// $user = User::create([
7578
// 'name' => $validatedData['name'],

app/Http/Requests/RegisterRequest.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ public function rules()
3030
'merit_position' => ['required', 'numeric'],
3131
'hall_name' => ['required'],
3232
'student_id' => ['required'],
33+
'grad_level' => ['required'],
3334
];
3435
}
3536
}

0 commit comments

Comments
 (0)