ios/tvos: try to include dSYM symbols in app store builds

Author: warmenhoven

pkg/apple/fastlane/Fastfile

@@ -165,6 +165,7 @@ private_lane :ra_build_app do |options|
     xcodebuild_formatter: 'xcbeautify --renderer github-actions',
     buildlog_path: "buildlog",
     export_method: "app-store",
+    include_symbols: true,
     export_options: {
       provisioningProfiles: options[:provisioningProfiles]
     }

pkg/apple/make-frameworks.sh

@@ -29,8 +29,10 @@ fi
 
 if [ -n "$BUILT_PRODUCTS_DIR" -a -n "$FRAMEWORKS_FOLDER_PATH" ] ; then
     OUTDIR="$BUILT_PRODUCTS_DIR"/"$FRAMEWORKS_FOLDER_PATH"
+    DSYM_OUTDIR="$BUILT_PRODUCTS_DIR"
 else
     OUTDIR="$BASE_DIR"/Frameworks
+    DSYM_OUTDIR="$BASE_DIR"/Frameworks
 fi
 
 mkdir -p "$OUTDIR"
@@ -62,6 +64,29 @@ for dylib in $(find "$BASE_DIR"/modules -maxdepth 1 -type f -regex '.*libretro.*
     fi
     echo "signing $fwName"
     codesign --force --verbose --sign "${CODE_SIGN_IDENTITY_FOR_ITEMS}" "$fwDir"
+
+    # Create framework dSYM if dylib dSYM exists
+    if [ -d "$dylib.dSYM" ] ; then
+        echo "Creating dSYM for framework $fwName"
+        dSYMDir="${DSYM_OUTDIR}/${fwName}.framework.dSYM"
+
+        # Copy entire dSYM structure to preserve all metadata and future additions
+        cp -R "$dylib.dSYM" "$dSYMDir"
+
+        # Rename DWARF binary to match framework name
+        dylibName=$(basename "$dylib")
+        mv "$dSYMDir/Contents/Resources/DWARF/$dylibName" "$dSYMDir/Contents/Resources/DWARF/$fwName"
+
+        # Update binary-path in Relocations yml files if they exist
+        if [ -d "$dSYMDir/Contents/Resources/Relocations" ] ; then
+            find "$dSYMDir/Contents/Resources/Relocations" -name "*.yml" -type f | while read -r ymlfile ; do
+                sed -i '' "s/binary-path: *$dylibName/binary-path:     $fwName/" "$ymlfile"
+            done
+        fi
+
+        # Update Info.plist with framework identifier
+        /usr/libexec/PlistBuddy -c "Set :CFBundleIdentifier com.apple.xcode.dsym.$fwName" "$dSYMDir/Contents/Info.plist"
+    fi
 done
 
 # Copy in MoltenVK as an embedded library manually instead of having

pkg/apple/update-cores.sh

@@ -30,6 +30,13 @@ else
     DRY_RUN=
 fi
 
+if [ "$1" = "-d" -o "$1" = "--dsym" ] ; then
+    DOWNLOAD_DSYM=1
+    shift
+else
+    DOWNLOAD_DSYM=
+fi
+
 URL_BASE="https://buildbot.libretro.com/nightly/apple"
 
 if [ "$PLATFORM_FAMILY_NAME" = "tvOS" -o "$1" = "tvos" -o "$1" = "--tvos" ] ; then
@@ -96,10 +103,44 @@ function update_dylib() {
         if [ "${#URL_PLATFORMS[@]}" != 1 ] ; then
             lipo -create -output "$dylib" "$dylib".*
         fi
+
+        # Download dSYM if requested
+        if [ -n "$DOWNLOAD_DSYM" ] ; then
+            for urlp in "${URL_PLATFORMS[@]}" ; do
+                debug curl $CURL_DEBUG -o "$dylib".dSYM.zip "$URL_BASE"/"$urlp"/latest/dSYM/"$dylib".dSYM.zip
+                curl $CURL_DEBUG -o "$dylib".dSYM.zip "$URL_BASE"/"$urlp"/latest/dSYM/"$dylib".dSYM.zip
+                if [ -f "$dylib".dSYM.zip ] ; then
+                    debug unzip $UNZIP_DEBUG "$dylib".dSYM.zip
+                    unzip $UNZIP_DEBUG "$dylib".dSYM.zip
+                    rm -f "$dylib".dSYM.zip
+
+                    # macos app store needs universal binaries - merge dSYMs
+                    if [ "${#URL_PLATFORMS[@]}" != 1 ] ; then
+                        mv "$dylib".dSYM "$dylib".dSYM.$(basename "$urlp")
+                    fi
+                fi
+            done
+            if [ "${#URL_PLATFORMS[@]}" != 1 ] ; then
+                # Merge dSYMs for universal binary if we have multiple architectures
+                if ls "$dylib".dSYM.* >/dev/null 2>&1 ; then
+                    lipo -create -output "$dylib".dSYM.tmp $(find . -name "$dylib".dSYM.*/Contents/Resources/DWARF/"$dylib" -o -name "$dylib".dSYM.*/Contents/Resources/DWARF/$(basename "$dylib" .dylib))
+                    # Reconstruct dSYM bundle structure
+                    mkdir -p "$dylib".dSYM/Contents/Resources/DWARF
+                    mv "$dylib".dSYM.tmp "$dylib".dSYM/Contents/Resources/DWARF/$(basename "$dylib" .dylib)
+                    rm -rf "$dylib".dSYM.*
+                fi
+            fi
+        fi
+
         popd >/dev/null
         if [ -f "$dylib".tmp/"$dylib" ] ; then
             printf "${GREEN}Download ${dylib} success!${NC}\n"
             mv "$dylib".tmp/"$dylib" "$dylib"
+            # Move dSYM if it exists (only when --dsym flag was used)
+            if [ -n "$DOWNLOAD_DSYM" ] && [ -d "$dylib".tmp/"$dylib".dSYM ] ; then
+                rm -rf "$dylib".dSYM
+                mv "$dylib".tmp/"$dylib".dSYM "$dylib".dSYM
+            fi
         fi
         rm -rf "$dylib".tmp
     ) &
@@ -263,6 +304,7 @@ else
         if [ "$1" = "all" ] ; then
             dylibs=(${allcores[*]})
         elif [ "$1" = "appstore" ] ; then
+            DOWNLOAD_DSYM=1
             exports=(${appstore_cores[*]})
             if [ "$PLATFORM" = "osx" ] ; then
                 exports+=(