Simplify config and add SDL build options

Added `Release|x64` build configuration in `PCSX2_qt.sln`. Updated `pcsx2-winrt.vcxproj` and `pcsx2.vcxproj` to include `/D SDL_BUILD` compiler option. Simplified `InputBindingKey` initialization in `SDLInputSource.cpp`.

Author: SternXD

PCSX2_qt.sln

@@ -2025,6 +2025,7 @@ Global
 		{BB98BF81-A132-444A-BB81-96D510F433A8}.Release|ARM64.ActiveCfg = Release|x64
 		{BB98BF81-A132-444A-BB81-96D510F433A8}.Release|ARM64.Build.0 = Release|x64
 		{BB98BF81-A132-444A-BB81-96D510F433A8}.Release|x64.ActiveCfg = Release|x64
+		{BB98BF81-A132-444A-BB81-96D510F433A8}.Release|x64.Build.0 = Release|x64
 		{BB98BF81-A132-444A-BB81-96D510F433A8}.Release|x86.ActiveCfg = Release|x64
 		{BB98BF81-A132-444A-BB81-96D510F433A8}.Release|x86.Build.0 = Release|x64
 		{67D0160C-0FE4-44B9-AC2E-82BBCF4104DF}.Debug AVX2|ARM.ActiveCfg = Devel Clang|x64

pcsx2-winrt/pcsx2-winrt.vcxproj

@@ -107,7 +107,7 @@
       <FloatingPointModel>Precise</FloatingPointModel>
       <MultiProcessorCompilation>true</MultiProcessorCompilation>
       <ConformanceMode>true</ConformanceMode>
-      <AdditionalOptions>/Zc:__cplusplus /Zo /utf-8%(AdditionalOptions) /bigobj</AdditionalOptions>
+      <AdditionalOptions>/Zc:__cplusplus /Zo /utf-8%(AdditionalOptions) /bigobj /D SDL_BUILD</AdditionalOptions>
       <Optimization Condition="'$(Configuration)|$(Platform)'=='Debug Clang|ARM64'">Full</Optimization>
       <FavorSizeOrSpeed Condition="'$(Configuration)|$(Platform)'=='Debug Clang|ARM64'">Speed</FavorSizeOrSpeed>
     </ClCompile>

pcsx2/Input/SDLInputSource.cpp

@@ -799,7 +799,7 @@ bool SDLInputSource::CloseDevice(int joystick_index)
 		return false;
 
 	InputManager::OnInputDeviceDisconnected(
-		{InputBindingKey{.source_type = InputSourceType::SDL, .source_index = static_cast<u32>(it->player_id)}},
+		{InputBindingKey{InputSourceType::SDL, static_cast<u32>(it->player_id)}},
 		fmt::format("SDL-{}", it->player_id));
 
 	if (it->haptic)

pcsx2/Pcsx2Config.cpp

@@ -2039,7 +2039,6 @@ void Pcsx2Config::CopyRuntimeConfig(Pcsx2Config& cfg)
 	CurrentIRX = std::move(cfg.CurrentIRX);
 	CurrentGameArgs = std::move(cfg.CurrentGameArgs);
 	CurrentAspectRatio = cfg.CurrentAspectRatio;
-	IsPortableMode = cfg.IsPortableMode;
 
 	for (u32 i = 0; i < sizeof(Mcd) / sizeof(Mcd[0]); i++)
 	{
@@ -2125,15 +2124,8 @@ bool EmuFolders::SetResourcesDirectory()
 
 bool EmuFolders::ShouldUsePortableMode()
 {
-	// Check whether portable.ini/txt exists in the program directory or the `-portable` launch arguments have been passed.
-	if (FileSystem::FileExists(Path::Combine(AppRoot, "portable.ini").c_str()) ||
-		FileSystem::FileExists(Path::Combine(AppRoot, "portable.txt").c_str()) ||
-		EmuConfig.IsPortableMode)
-	{
-		return true;
-	}
-
-	return false;
+	// Check whether portable.ini exists in the program directory.
+	return FileSystem::FileExists(Path::Combine(AppRoot, "portable.ini").c_str()) || FileSystem::FileExists(Path::Combine(AppRoot, "portable.txt").c_str());
 }
 
 bool EmuFolders::SetDataDirectory(Error* error)
@@ -2186,23 +2178,7 @@ bool EmuFolders::SetDataDirectory(Error* error)
 
 	// couldn't determine the data directory, or using portable mode? fallback to portable.
 	if (DataRoot.empty())
-	{
-/* This breaks bulding on UWP so we have to comment this out
-#if defined(__linux__)
-	// special check if we're on appimage
-	// always make sure that DataRoot
-	// is adjacent next to the appimage
-	if (getenv("APPIMAGE"))
-	{
-		std::string_view appimage_path = Path::GetDirectory(getenv("APPIMAGE"));
-		DataRoot = Path::RealPath(Path::Combine(appimage_path, "PCSX2"));
-	}
-	else
-		DataRoot = Path::Combine(AppRoot, GetPortableModePath());
-#else
-		DataRoot = Path::Combine(AppRoot, GetPortableModePath());
-#endif
-	} */
+		DataRoot = AppRoot;
 
 	// inis is always below the data root
 	Settings = Path::Combine(DataRoot, "inis");

pcsx2/pcsx2.vcxproj

@@ -77,6 +77,7 @@
       <PreprocessorDefinitions>__SSE4_1__;%(PreprocessorDefinitions)</PreprocessorDefinitions>
       <PreprocessorDefinitions Condition="'$(Platform)'=='x64'">ZYCORE_STATIC_DEFINE;ZYDIS_STATIC_DEFINE;%(PreprocessorDefinitions)</PreprocessorDefinitions>
       <ObjectFileName>$(IntDir)%(RelativeDir)</ObjectFileName>
+      <AdditionalOptions Condition="'$(Configuration)|$(Platform)'=='Release|x64'">/D SDL_BUILD %(AdditionalOptions)</AdditionalOptions>
     </ClCompile>
   </ItemDefinitionGroup>
   <ItemGroup>