Merge pull request #180 from tahirmt/do-not-hard-exit-if-xcode-already-installed

Do not exit(1) if xcode is already installed

Author: MattKiazyk

Sources/xcodes/ParsableArguments+InstallError.swift

@@ -0,0 +1,30 @@
+import ArgumentParser
+import Foundation
+import LegibleError
+import PromiseKit
+import XcodesKit
+import Rainbow
+
+extension ParsableArguments {
+    static func processDownloadOrInstall(error: Error) -> Never {
+        var exitCode: ExitCode = .failure
+        switch error {
+        case Process.PMKError.execution(let process, let standardOutput, let standardError):
+            Current.logging.log("""
+                Failed executing: `\(process)` (\(process.terminationStatus))
+                \([standardOutput, standardError].compactMap { $0 }.joined(separator: "\n"))
+                """.red)
+        case let error as XcodeInstaller.Error:
+            if case .versionAlreadyInstalled = error {
+                Current.logging.log(error.legibleLocalizedDescription.green)
+                exitCode = .success
+            } else {
+                Current.logging.log(error.legibleLocalizedDescription.red)
+            }
+        default:
+            Current.logging.log(error.legibleLocalizedDescription.red)
+        }
+
+        Self.exit(withError: exitCode)
+    }
+}

Sources/xcodes/main.swift

@@ -138,17 +138,7 @@ struct Xcodes: ParsableCommand {
 
             installer.download(installation, dataSource: globalDataSource.dataSource, downloader: downloader, destinationDirectory: destination)
                 .catch { error in
-                    switch error {
-                    case Process.PMKError.execution(let process, let standardOutput, let standardError):
-                        Current.logging.log("""
-                            Failed executing: `\(process)` (\(process.terminationStatus))
-                            \([standardOutput, standardError].compactMap { $0 }.joined(separator: "\n"))
-                            """.red)
-                    default:
-                        Current.logging.log(error.legibleLocalizedDescription.red)
-                    }
-                    
-                    Install.exit(withError: ExitCode.failure)
+                    Install.processDownloadOrInstall(error: error)
                 }
 
             RunLoop.current.run()
@@ -231,17 +221,7 @@ struct Xcodes: ParsableCommand {
             installer.install(installation, dataSource: globalDataSource.dataSource, downloader: downloader, destination: destination)
                 .done { Install.exit() }
                 .catch { error in
-                    switch error {
-                    case Process.PMKError.execution(let process, let standardOutput, let standardError):
-                        Current.logging.log("""
-                            Failed executing: `\(process)` (\(process.terminationStatus))
-                            \([standardOutput, standardError].compactMap { $0 }.joined(separator: "\n"))
-                            """.red)
-                    default:
-                        Current.logging.log(error.legibleLocalizedDescription.red)
-                    }
-                    
-                    Install.exit(withError: ExitCode.failure)
+                    Install.processDownloadOrInstall(error: error)
                 }
 
             RunLoop.current.run()