Skip to content

Xcode versions may be missing or duplicated (e.g. Xcode 26 Beta 5 missing) #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Xcode versions may be missing or duplicated (e.g. Xcode 26 Beta 5 missing) #444

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
581ba79
Filter a single version for each build
mattguk Sep 15, 2025
5beff11
add tests
mattguk Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions Sources/XcodesKit/XcodeList.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,22 +173,23 @@ extension XcodeList {
/// We don't care about that difference, so only keep the final release (GM or Release, in XCModel terms).
/// The downside of this is that a user could technically have both releases installed, and so they won't both be shown in the list, but I think most users wouldn't do this.
func filterPrereleasesThatMatchReleaseBuildMetadataIdentifiers(_ xcodes: [Xcode]) -> [Xcode] {

let xcodesByBuildMetadataIdentifiers =
Dictionary(grouping: xcodes, by: { $0.version.buildMetadataIdentifiers })

var filteredXcodes: [Xcode] = []
for xcode in xcodes {
if xcode.version.buildMetadataIdentifiers.isEmpty {
filteredXcodes.append(xcode)
for (buildMetadataIdentifiers, xcodes) in xcodesByBuildMetadataIdentifiers {
if buildMetadataIdentifiers.isEmpty || xcodes.count == 1 {
filteredXcodes.append(contentsOf: xcodes)
continue
}

let xcodesWithSameBuildMetadataIdentifiers = xcodes
.filter({ $0.version.buildMetadataIdentifiers == xcode.version.buildMetadataIdentifiers })
if xcodesWithSameBuildMetadataIdentifiers.count > 1,
xcode.version.prereleaseIdentifiers.isEmpty || xcode.version.prereleaseIdentifiers == ["GM"] {
filteredXcodes.append(xcode)
} else if xcodesWithSameBuildMetadataIdentifiers.count == 1 {
filteredXcodes.append(xcode)
}
// Use the final release if there is one, otherwise just (arbitrarily) pick the first.
let finalRelease = xcodes.first(where: {
$0.version.prereleaseIdentifiers.isEmpty || $0.version.prereleaseIdentifiers == ["GM"] })
filteredXcodes.append(finalRelease ?? xcodes.first!)
}

return filteredXcodes
}
}