Renamed extension method to RegisterCommandHandlersByAttribute

Author: joel-jeremy

Src/Xer.Cqrs.CommandStack.Extensions.Attributes/SingleMessageHandlerRegistrationExtensions.cs

@@ -33,11 +33,11 @@ public static partial class SingleMessageHandlerRegistrationExtensions
         /// </remarks>
         /// <param name="registration">Message handler registration.</param>
         /// <param name="attributedObjectFactory">Factory delegate which provides an instance of a class that contains methods marked with [CommandHandler] attribute.</param>
-        public static void RegisterCommandHandlerAttributes<TAttributed>(this SingleMessageHandlerRegistration registration,
-                                                                         Func<TAttributed> attributedObjectFactory)
-                                                                         where TAttributed : class
+        public static void RegisterCommandHandlersByAttribute<TAttributed>(this SingleMessageHandlerRegistration registration,
+                                                                           Func<TAttributed> attributedObjectFactory)
+                                                                           where TAttributed : class
         {
-            RegisterCommandHandlerAttributes(registration, CommandHandlerAttributeMethod.FromType<TAttributed>(attributedObjectFactory));
+            RegisterCommandHandlersByAttribute(registration, CommandHandlerAttributeMethod.FromType<TAttributed>(attributedObjectFactory));
         }
 
         /// <summary>
@@ -50,11 +50,11 @@ public static void RegisterCommandHandlerAttributes<TAttributed>(this SingleMess
         /// <param name="registration">Message handler registration.</param>
         /// <param name="type">Type to scan for methods marked with the [CommandHandler] attribute.</param>
         /// <param name="instanceFactory">Factory delegate that provides an instance of the specified type.</param>
-        public static void RegisterCommandHandlerAttributes(this SingleMessageHandlerRegistration registration,
-                                                            Type type, 
-                                                            Func<object> instanceFactory)
+        public static void RegisterCommandHandlersByAttribute(this SingleMessageHandlerRegistration registration,
+                                                              Type type, 
+                                                              Func<object> instanceFactory)
         {
-            RegisterCommandHandlerAttributes(registration, CommandHandlerAttributeMethod.FromType(type, instanceFactory));
+            RegisterCommandHandlersByAttribute(registration, CommandHandlerAttributeMethod.FromType(type, instanceFactory));
         }
 
         /// <summary>
@@ -67,11 +67,11 @@ public static void RegisterCommandHandlerAttributes(this SingleMessageHandlerReg
         /// <param name="registration">Message handler registration.</param>
         /// <param name="types">Types to scan for methods marked with the [CommandHandler] attribute.</param>
         /// <param name="instanceFactory">Factory delegate that provides an instance of a given type.</param>
-        public static void RegisterCommandHandlerAttributes(this SingleMessageHandlerRegistration registration,
-                                                            IEnumerable<Type> types, 
-                                                            Func<Type, object> instanceFactory)
+        public static void RegisterCommandHandlersByAttribute(this SingleMessageHandlerRegistration registration,
+                                                              IEnumerable<Type> types, 
+                                                              Func<Type, object> instanceFactory)
         {
-            RegisterCommandHandlerAttributes(registration, CommandHandlerAttributeMethod.FromTypes(types, instanceFactory));
+            RegisterCommandHandlersByAttribute(registration, CommandHandlerAttributeMethod.FromTypes(types, instanceFactory));
         }
 
         /// <summary>
@@ -84,11 +84,11 @@ public static void RegisterCommandHandlerAttributes(this SingleMessageHandlerReg
         /// <param name="registration">Message handler registration.</param>
         /// <param name="assembly">Assembly to scan for methods marked with the [CommandHandler] attribute.</param>
         /// <param name="instanceFactory">Factory delegate that provides an instance of a type that has methods marked with [CommandHandler] attribute.</param>
-        public static void RegisterCommandHandlerAttributes(this SingleMessageHandlerRegistration registration,
-                                                            Assembly assembly, 
-                                                            Func<Type, object> instanceFactory)
+        public static void RegisterCommandHandlersByAttribute(this SingleMessageHandlerRegistration registration,
+                                                              Assembly assembly, 
+                                                              Func<Type, object> instanceFactory)
         {
-            RegisterCommandHandlerAttributes(registration, CommandHandlerAttributeMethod.FromAssembly(assembly, instanceFactory));
+            RegisterCommandHandlersByAttribute(registration, CommandHandlerAttributeMethod.FromAssembly(assembly, instanceFactory));
         }
 
         /// <summary>
@@ -101,26 +101,11 @@ public static void RegisterCommandHandlerAttributes(this SingleMessageHandlerReg
         /// <param name="registration">Message handler registration.</param>
         /// <param name="assembly">Assembly to scan for methods marked with the [CommandHandler] attribute.</param>
         /// <param name="instanceFactory">Factory delegate that provides an instance of a type that has methods marked with [CommandHandler] attribute.</param>
-        public static void RegisterCommandHandlerAttributes(this SingleMessageHandlerRegistration registration,
-                                                            IEnumerable<Assembly> assemblies, 
-                                                            Func<Type, object> instanceFactory)
+        public static void RegisterCommandHandlersByAttribute(this SingleMessageHandlerRegistration registration,
+                                                              IEnumerable<Assembly> assemblies, 
+                                                              Func<Type, object> instanceFactory)
         {
-            RegisterCommandHandlerAttributes(registration, CommandHandlerAttributeMethod.FromAssemblies(assemblies, instanceFactory));
-        }
-
-        /// <summary>
-        /// Register methods marked with the [CommandHandler] attribute as command handlers.
-        /// <para>Supported signatures for methods marked with [CommandHandler] are: (Methods can be named differently)</para>
-        /// <para>void HandleCommand(TCommand command);</para>
-        /// <para>Task HandleCommandAsync(TCommand command);</para>
-        /// <para>Task HandleCommandAsync(TCommand command, CancellationToken cancellationToken);</para>
-        /// </summary>
-        /// <param name="registration">Message handler registration.</param>
-        /// <param name="commandHandlerMethod">Object which represents a method marked with [CommandHandler] attribute.</param>
-        public static void RegisterCommandHandlerAttributes(this SingleMessageHandlerRegistration registration,
-                                                            CommandHandlerAttributeMethod commandHandlerMethod)
-        {
-            RegisterCommandHandlerAttributes(registration, new[] { commandHandlerMethod });
+            RegisterCommandHandlersByAttribute(registration, CommandHandlerAttributeMethod.FromAssemblies(assemblies, instanceFactory));
         }
 
         /// <summary>
@@ -132,8 +117,8 @@ public static void RegisterCommandHandlerAttributes(this SingleMessageHandlerReg
         /// </summary>
         /// <param name="registration">Message handler registration.</param>
         /// <param name="commandHandlerMethods">Objects which represent methods marked with [CommandHandler] attribute.</param>
-        public static void RegisterCommandHandlerAttributes(this SingleMessageHandlerRegistration registration,
-                                                            IEnumerable<CommandHandlerAttributeMethod> commandHandlerMethods)
+        public static void RegisterCommandHandlersByAttribute(this SingleMessageHandlerRegistration registration,
+                                                              IEnumerable<CommandHandlerAttributeMethod> commandHandlerMethods)
         {
             if (registration == null)
             {

Tests/Xer.Cqrs.CommandStack.Extensions.Attributes.Tests/Registration/AttributeRegistrationTests.cs

@@ -32,7 +32,7 @@ public async Task ShouldRegisterAllMethodsOfTypeThatIsMarkedWithCommandHandlerAt
                 var commandHandler = new TestAttributedCommandHandler(_outputHelper);
 
                 var registration = new SingleMessageHandlerRegistration();
-                registration.RegisterCommandHandlerAttributes(() => commandHandler);
+                registration.RegisterCommandHandlersByAttribute(() => commandHandler);
 
                 IMessageHandlerResolver resolver = registration.BuildMessageHandlerResolver();
 
@@ -56,7 +56,7 @@ public async Task ShouldRegisterAllCommandHandlerAttributeMethodObjects()
                 IEnumerable<CommandHandlerAttributeMethod> methods = CommandHandlerAttributeMethod.FromType(() => commandHandler);
 
                 var registration = new SingleMessageHandlerRegistration();
-                registration.RegisterCommandHandlerAttributes(methods);
+                registration.RegisterCommandHandlersByAttribute(methods);
 
                 IMessageHandlerResolver resolver = registration.BuildMessageHandlerResolver();
 
@@ -79,7 +79,7 @@ public void ShouldNotAllowSyncMethodsWithCancellationToken()
                     try
                     {
                         var registration = new SingleMessageHandlerRegistration();
-                        registration.RegisterCommandHandlerAttributes(() => new TestAttributedSyncCommandHandlerWithCancellationToken(_outputHelper));
+                        registration.RegisterCommandHandlersByAttribute(() => new TestAttributedSyncCommandHandlerWithCancellationToken(_outputHelper));
                     }
                     catch (Exception ex)
                     {