Skip to content

Commit 245b4c9

Browse files
committed
fixes tests
1 parent 287f616 commit 245b4c9

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

src/test/java/com/xero/api/client/AccountingApiJournalsTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ public void tearDown() {
5454
public void getJournalTest() throws IOException {
5555
System.out.println("@Test - getJournal");
5656
UUID journalID = UUID.fromString("8138a266-fb42-49b2-a104-014b7045753d");
57-
Journals response = accountingApi.getJournalByNumber(accessToken,xeroTenantId,1);
57+
Journals response = accountingApi.getJournal(accessToken,xeroTenantId,journalID);
5858

5959
assertThat(response.getJournals().get(0).getJournalID(), is(equalTo(UUID.fromString("1b31feeb-aa23-404c-8c19-24c827c53661"))));
6060
assertThat(response.getJournals().get(0).getJournalDateAsDate(), is(equalTo(LocalDate.of(2018,10,20))));

src/test/java/com/xero/api/client/PayrollUkApiEmploymentTest.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
import com.xero.api.ApiClient;
88
import com.xero.api.util.ConfigurationLoader;
99
import com.xero.models.payrolluk.*;
10-
import com.xero.models.payrolluk.Employment.NiCategoryEnum;
1110

1211
import org.threeten.bp.*;
1312
import java.io.IOException;
@@ -42,15 +41,15 @@ public void createEmploymentTest() throws IOException {
4241

4342
Employment employment = new Employment();
4443
employment.setPayrollCalendarID(UUID.randomUUID());
45-
employment.setEmployeeNumber("007");
44+
employment.setEmployeeNumber("123ABC");
4645
employment.setStartDate(LocalDate.of(2024, 04, 01));
47-
employment.setNiCategory(NiCategoryEnum.A);
46+
employment.setNiCategories(Arrays.asList(new NICategory().niCategory(NICategoryLetter.I).workplacePostcode("SW1A 1AA")));
47+
4848
UUID employeeId = UUID.fromString("cdfb8371-0b21-4b8a-8903-1024df6c391e");
4949
EmploymentObject response = payrollUkApi.createEmployment(accessToken, xeroTenantId, employeeId, employment, null);
5050
assertThat(response.getEmployment().getPayrollCalendarID(), is(equalTo(UUID.fromString("216d80e6-af55-47b1-b718-9457c3f5d2fe"))));
5151
assertThat(response.getEmployment().getStartDate(), is(equalTo(LocalDate.of(2020, 04, 01))));
5252
assertThat(response.getEmployment().getEmployeeNumber(), is(equalTo("123ABC")));
53-
assertThat(response.getEmployment().getNiCategory(), is(equalTo(com.xero.models.payrolluk.NICategoryLetter.A)));
54-
//System.out.println(response.toString());
53+
assertThat(response.getEmployment().getNiCategories(), hasItem(hasProperty("niCategory", is(equalTo(NICategoryLetter.I)))));
5554
}
5655
}

0 commit comments

Comments
 (0)