Skip to content

Commit d6feb8b

Browse files
[PETOSS-829] Update codegen app_id location (#761)
* [PETOSS-829] Use var for app_id as per docs * [PETOSS-829] Replace access token action
1 parent 021fffd commit d6feb8b

File tree

2 files changed

+8
-12
lines changed

2 files changed

+8
-12
lines changed

.github/workflows/create-github-pr.yml

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -23,16 +23,12 @@ jobs:
2323

2424
- name: Get github app access token
2525
id: get_access_token
26-
env:
27-
GITHUB_APP_ID: ${{ secrets.XERO_GITHUB_APP_ID }}
28-
GITHUB_APP_PRIVATE_KEY: ${{ secrets.XERO_GITHUB_APPLICATION_KEY }}
29-
uses: actions/github-script@v7
26+
uses: actions/create-github-app-token@v2
3027
with:
31-
result-encoding: string
32-
script: |
33-
const { getAccessToken } = await import('${{ github.workspace }}/.github/get-access-token/index.js')
34-
const token = await getAccessToken()
35-
return token
28+
app-id: ${{ secrets.XERO_PUBLIC_BOT_APP_ID}}
29+
private-key: ${{ secrets.XERO_PUBLIC_BOT_KEY }}
30+
owner: xero-internal
31+
repositories: xeroapi-sdk-codegen
3632

3733
- name: Fetch Latest release number
3834
id: get_latest_release_number
@@ -41,7 +37,7 @@ jobs:
4137
echo "Latest release version is - $latest_version"
4238
echo "releaseVersion=$latest_version" >> $GITHUB_OUTPUT
4339
env:
44-
GH_TOKEN: ${{steps.get_access_token.outputs.result}}
40+
GH_TOKEN: ${{steps.get_access_token.outputs.token}}
4541

4642
- name: Set up branch name
4743
id: identify_branch_name
@@ -121,4 +117,4 @@ jobs:
121117
echo "PR is already up to date"
122118
fi
123119
env:
124-
GH_TOKEN: ${{steps.get_access_token.outputs.result}}
120+
GH_TOKEN: ${{steps.get_access_token.outputs.token}}

.github/workflows/pr-validation.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ jobs:
3636
id: get_access_token
3737
uses: actions/create-github-app-token@v2
3838
with:
39-
app-id: ${{ secrets.XERO_GITHUB_APP_ID }}
39+
app-id: ${{ vars.XERO_CODEGEN_APP_ID }}
4040
private-key: ${{ secrets.XERO_GITHUB_APPLICATION_KEY }}
4141
owner: xero-internal
4242
repositories: xeroapi-sdk-codegen

0 commit comments

Comments
 (0)