xero-finance.yaml is using incorrect data type for http response code (number vs string)

[rpocklin]

Although many parsers may tolerate HTTP Response Codes as being a number it violates the OpenAPISpec 3.0 which specifies it as a string and is an easy fix.

Reference Documentation
Rule Details

Looking for agreement to raise a trivial PR to bring this into alignment with all other Xero yaml specs (which correctly implement them as a string eg. "200" vs 200.

I have a validator which highlights the error:

➜  Xero-OpenAPI git:(feat-spectral-linter) ✗ ./validate-all.sh
🔍 Validating all Xero OpenAPI specifications...
================================================
Testing 11 OpenAPI specification files...

📄 Validating xero-identity.yaml...
✅ xero-identity.yaml - PASSED
📄 Validating xero-projects.yaml...
✅ xero-projects.yaml - PASSED
📄 Validating xero-app-store.yaml...
✅ xero-app-store.yaml - PASSED
📄 Validating xero-payroll-uk.yaml...
✅ xero-payroll-uk.yaml - PASSED
📄 Validating xero_files.yaml...
✅ xero_files.yaml - PASSED
📄 Validating xero_accounting.yaml...
✅ xero_accounting.yaml - PASSED
📄 Validating xero-payroll-nz.yaml...
✅ xero-payroll-nz.yaml - PASSED
📄 Validating xero_assets.yaml...
✅ xero_assets.yaml - PASSED
📄 Validating xero-finance.yaml...
❌ xero-finance.yaml - FAILED
   Running detailed check:

/Users/~/Xero-OpenAPI/xero-finance.yaml
  392:9         error  parser                              Mapping key must be a string scalar rather than number               paths./FinancialStatements/BalanceSheet.get.responses[200]
  456:9         error  parser                              Mapping key must be a string scalar rather than number               paths./FinancialStatements/BalanceSheet.get.responses[400]
  467:9         error  parser                              Mapping key must be a string scalar rather than number               paths./FinancialStatements/BalanceSheet.get.responses[503]
  506:9         error  parser                              Mapping key must be a string scalar rather than number               paths./FinancialStatements/Cashflow.get.responses[200]
  610:9         error  parser                              Mapping key must be a string scalar rather than number               paths./FinancialStatements/Cashflow.get.responses[400]
  621:9         error  parser                              Mapping key must be a string scalar rather than number               paths./FinancialStatements/Cashflow.get.responses[503]
  660:9         error  parser                              Mapping key must be a string scalar rather than number               paths./FinancialStatements/ProfitAndLoss.get.responses[200]
  712:9         error  parser                              Mapping key must be a string scalar rather than number               paths./FinancialStatements/ProfitAndLoss.get.responses[400]

📄 Validating xero_bankfeeds.yaml...
✅ xero_bankfeeds.yaml - PASSED
📄 Validating xero-payroll-au.yaml...
✅ xero-payroll-au.yaml - PASSED

================================================
📊 SUMMARY:
   Total files: 11
   Passed: 10
   Failed: 1

⚠️  Some files failed validation. Check the output above for details.

[github-actions]

PETOSS-809

[github-actions]

Thanks for raising an issue, a ticket has been created to track your request

[rpocklin]

Fixed by #743 =)