[DUCK] 限制低粒度与高粒度结合 (#260)

du00cs · web-flow · commit 2fabbd268dbd · 2025-08-27T18:36:31.000+08:00
- maxGrain 补充在更多predicate中的实现
- intersect 增加 maxGrain 考量
diff --git a/duckling-fork-chinese/core/src/main/scala/com/xiaomi/duckling/dimension/time/Rules.scala b/duckling-fork-chinese/core/src/main/scala/com/xiaomi/duckling/dimension/time/Rules.scala
@@ -213,7 +213,10 @@ trait Rules extends DimRules {
           if td1.timeGrain > td2.timeGrain && !(td1.hint == Hint.Date && td2.hint == Hint.Date) ||
             // 上午的8-9点
             td1.timeGrain == td2.timeGrain && td1.timeGrain == Hour && isAPartOfDay(t1) && !isAPartOfDay(t2) =>
-        intersectToken(options, td1, td2)
+          val g1 = td1.timePred.maxGrain
+          val g2 = td2.timePred.maxGrain
+          if (g1.isDefined && g2.isDefined && g1.get < g2.get) None
+          else intersectToken(options, td1, td2)
       }
     )
 
diff --git a/duckling-fork-chinese/core/src/main/scala/com/xiaomi/duckling/dimension/time/Time.scala b/duckling-fork-chinese/core/src/main/scala/com/xiaomi/duckling/dimension/time/Time.scala
@@ -208,7 +208,7 @@ case class TimeData(timePred: TimePredicate,
       case TimeDatePredicate(second, minute, hour, _, _, dayOfMonth, month, year, _) =>
         // 如：2021年10月1日12点三十分
         Simple(year, month, dayOfMonth, hour, minute, second, offset=Some(false))
-      case IntersectTimePredicate(TimeDatePredicate(second, minute, hour, _, _, _, _, _, _), IntersectTimePredicate(TimeDatePredicate(_, _, _, _, _, dayOfMonth, month, _, _), SeriesPredicate(_))) =>
+      case IntersectTimePredicate(TimeDatePredicate(second, minute, hour, _, _, _, _, _, _), IntersectTimePredicate(TimeDatePredicate(_, _, _, _, _, dayOfMonth, month, _, _), SeriesPredicate(_, _))) =>
         // 如： 明年三月一号十二点三十分, 年份隐式表达SeriesPredicate
         Simple(None, month, dayOfMonth, hour, minute, second, offset=Some(true))
       case IntersectTimePredicate(SequencePredicate(_), TimeDatePredicate(_, _, _, _, _, _, _, year, _)) =>
@@ -217,26 +217,26 @@ case class TimeData(timePred: TimePredicate,
       case IntersectTimePredicate(TimeDatePredicate(second, minute, hour, _, _, _, _, _, _), SequencePredicate(_)) =>
         // 如：除夕十二点三十分，没有年份表达，除夕SequencePredicate
         Simple(hour=hour, minute=minute, second=second, offset=Some(false))
-      case IntersectTimePredicate(TimeDatePredicate(second, minute, hour, _, _, _, _, _, _), IntersectTimePredicate(SequencePredicate(_), SeriesPredicate(_))) =>
+      case IntersectTimePredicate(TimeDatePredicate(second, minute, hour, _, _, _, _, _, _), IntersectTimePredicate(SequencePredicate(_), SeriesPredicate(_, _))) =>
         // 如：今年除夕十二点三十分，年份隐式表达，除夕SequencePredicate
         Simple(hour=hour, minute=minute, second=second, offset=Some(true))
       case IntersectTimePredicate(TimeDatePredicate(second, minute, hour, _, _, _, _, _, _), IntersectTimePredicate(_, TimeDatePredicate(_, _, _, _, _, _, _, year, _))) =>
         // 如：2021年[除夕、节气、西方节日]十二点三十分，有具体年份表达
         Simple(year=year, hour=hour, minute=minute, second=second, offset=Some(false))
-      case IntersectTimePredicate(TimeDatePredicate(second, minute, hour, _, _, _, _, _, _), IntersectTimePredicate(SeriesPredicate(_), SeriesPredicate(_))) =>
+      case IntersectTimePredicate(TimeDatePredicate(second, minute, hour, _, _, _, _, _, _), IntersectTimePredicate(SeriesPredicate(_, _), SeriesPredicate(_, _))) =>
         // 如：明年[清明节、西方节日]十二点三十分，年份隐式表达，节气SeriesPredicate
         Simple(hour=hour, minute=minute, second=second, offset=Some(true))
-      case IntersectTimePredicate(SeriesPredicate(_), TimeDatePredicate(second, minute, hour, _, _, _, _, year, _)) =>
+      case IntersectTimePredicate(SeriesPredicate(_, _), TimeDatePredicate(second, minute, hour, _, _, _, _, year, _)) =>
         // 如：2021年[清明节、西方节日]，节气需要根据年份查表获取具体日期，只抽取年，节气SeriesPredicate
         Simple(year=year, hour=hour, minute=minute, second=second, offset=Some(false))
-      case IntersectTimePredicate(TimeDatePredicate(second, minute, hour, _, _, dayOfMonth, month, _, _), SeriesPredicate(_)) =>
+      case IntersectTimePredicate(TimeDatePredicate(second, minute, hour, _, _, dayOfMonth, month, _, _), SeriesPredicate(_, grain)) =>
         // 如：[清明节、西方节日]十二点三十分，今年国庆节，明年中秋节，今天十二点三十分，年份/日期隐式表达和节气SeriesPredicate
         val offset = (second.isDefined || minute.isDefined || hour.isDefined) && holiday.exists(_.nonEmpty)
         Simple(None, month, dayOfMonth, hour, minute, second, offset=Some(!offset))
-      case IntersectTimePredicate(SeriesPredicate(_), SeriesPredicate(_)) =>
+      case IntersectTimePredicate(SeriesPredicate(_, _), SeriesPredicate(_, _)) =>
         // 如：今年[清明节、西方节日]，年份隐式表达和节气SeriesPredicate
         Simple(offset=Some(true))
-      case SeriesPredicate(_) =>
+      case SeriesPredicate(_, _) =>
         // 如：[清明节、西方节日]西方节日和节气SeriesPredicate
         Simple(offset=if (holiday.exists(_.nonEmpty)) Some(false) else Some(true))
       case _ => Simple()
diff --git a/duckling-fork-chinese/core/src/main/scala/com/xiaomi/duckling/dimension/time/helper/TimePredicateHelpers.scala b/duckling-fork-chinese/core/src/main/scala/com/xiaomi/duckling/dimension/time/helper/TimePredicateHelpers.scala
@@ -145,7 +145,7 @@ object TimePredicateHelpers {
       }
     }
 
-    SeriesPredicate(timeSeqMap(false, f, basePred))
+    SeriesPredicate(timeSeqMap(false, f, basePred), basePred.maxGrain)
   }
 
   def timeCycle(grain: Grain): CycleSeriesPredicate = timeCycle(grain, grain)
@@ -192,7 +192,7 @@ object TimePredicateHelpers {
       }
     }
 
-    SeriesPredicate(series)
+    SeriesPredicate(series, cycleSP.maxGrain)
   }
 
   /**
@@ -221,7 +221,7 @@ object TimePredicateHelpers {
           else (Stream(nth), Stream.empty)
       }
     }
-    SeriesPredicate(series)
+    SeriesPredicate(series, f.maxGrain)
   }
 
   /**
@@ -255,7 +255,7 @@ object TimePredicateHelpers {
         (Stream.iterate(anchor)(f(-1)).tail, Stream.iterate(anchor)(f(1)))
       }
     }
-    SeriesPredicate(series)
+    SeriesPredicate(series, Some(Day))
   }
 
   /**
diff --git a/duckling-fork-chinese/core/src/main/scala/com/xiaomi/duckling/dimension/time/package.scala b/duckling-fork-chinese/core/src/main/scala/com/xiaomi/duckling/dimension/time/package.scala
@@ -144,7 +144,7 @@ package object time {
   def runPredicate(tp: TimePredicate): SeriesPredicateF = {
     tp match {
       case EmptyTimePredicate => EmptySeriesPredicate
-      case SeriesPredicate(f) => f
+      case SeriesPredicate(f, _) => f
       case TimeDatePredicate(sec, min, hour, ampm, dayOfWeek, dayOfMonth, month, year, calendar) =>
         if (hour.isEmpty && ampm.nonEmpty) EmptySeriesPredicate
         else {
@@ -197,8 +197,8 @@ package object time {
       t2 <- resolveTimeData(t, td2)
     } yield {
       val to =
-        if (td2.timePred.maxGrain.nonEmpty && td1.timeGrain > td2.timePred.maxGrain.get) {
-          copyGrain(Year, td2.timePred.maxGrain.get, t1, t2)
+        if (td2.timePred.maxGrain.nonEmpty && td1.timeGrain > td2.timePred.maxGrain.get && td1.timeGrain.finer().isDefined) {
+          copyGrain(Year, td1.timeGrain.finer().get, t1, t2)
         } else {
           (td1.timeGrain, td2.timeGrain) match {
             case (Year, Month) => t2.copy(start = t2.start.withYear(t1.start.year))
diff --git a/duckling-fork-chinese/core/src/main/scala/com/xiaomi/duckling/dimension/time/predicates.scala b/duckling-fork-chinese/core/src/main/scala/com/xiaomi/duckling/dimension/time/predicates.scala
@@ -73,8 +73,9 @@ object predicates {
     }
   }
 
-  case class SeriesPredicate(f: SeriesPredicateF) extends TimePredicate {
+  case class SeriesPredicate(f: SeriesPredicateF, grainOpt: Option[Grain]) extends TimePredicate {
     override def toString: String = "f:Series"
+    override val maxGrain: Option[Grain] = grainOpt
   }
 
   case class IntersectTimePredicate(pred1: TimePredicate, pred2: TimePredicate)
@@ -105,12 +106,17 @@ object predicates {
   /**
    * 用td1的部分信息替换td2的结果，解决明年的今天、上个月的今天之类的问题
    */
-  case class ReplacePartPredicate(td1: TimeData, td2: TimeData) extends TimePredicate
+  case class ReplacePartPredicate(td1: TimeData, td2: TimeData) extends TimePredicate {
+    override val maxGrain: Option[Grain] = td1.timeGrain
+  }
 
   case object EndOfGrainPredicate extends TimePredicate
 
   case class CycleSeriesPredicate(seriesF: SeriesPredicateF, n: Int, grain: Grain)
-    extends TimePredicate
+    extends TimePredicate {
+
+    override val maxGrain: Option[Grain] = Some(grain)
+  }
 
   val singleNumeber: Predicate = isIntegerBetween(0, 9)
 
diff --git a/duckling-fork-chinese/core/src/test/scala/com/xiaomi/duckling/dimension/time/TimeTest.scala b/duckling-fork-chinese/core/src/test/scala/com/xiaomi/duckling/dimension/time/TimeTest.scala
@@ -139,9 +139,13 @@ class TimeTest extends UnitSpec {
       }
     }
 
-    it("fix #187") {
+    it("不需要支持的") {
       val opt = options.copy(full = true, withLatent = false)
-      val cases = Table("query", "国庆晚", "十月一晚", "下钟", "晚")
+      val cases = Table("query",
+        // fix #187
+        "国庆晚", "十月一晚", "下钟", "晚",
+        // fix #259
+        "上午今天早上七点")
       forAll(cases) {query =>
         parse(query, options = opt) should be (empty)
       }

Original file line number	Diff line number	Diff line change
`@@ -213,7 +213,10 @@ trait Rules extends DimRules {`
`213`	`213`	`if td1.timeGrain > td2.timeGrain && !(td1.hint == Hint.Date && td2.hint == Hint.Date) \|\|`
`214`	`214`	`// 上午的8-9点`
`215`	`215`	`td1.timeGrain == td2.timeGrain && td1.timeGrain == Hour && isAPartOfDay(t1) && !isAPartOfDay(t2) =>`
`216`		`- intersectToken(options, td1, td2)`
	`216`	`+ val g1 = td1.timePred.maxGrain`
	`217`	`+ val g2 = td2.timePred.maxGrain`
	`218`	`+ if (g1.isDefined && g2.isDefined && g1.get < g2.get) None`
	`219`	`+ else intersectToken(options, td1, td2)`
`217`	`220`	`}`
`218`	`221`	`)`
`219`	`222`
Original file line number	Diff line number	Diff line change
`@@ -145,7 +145,7 @@ object TimePredicateHelpers {`
`145`	`145`	`}`
`146`	`146`	`}`
`147`	`147`
`148`		`- SeriesPredicate(timeSeqMap(false, f, basePred))`
	`148`	`+ SeriesPredicate(timeSeqMap(false, f, basePred), basePred.maxGrain)`
`149`	`149`	`}`
`150`	`150`
`151`	`151`	`def timeCycle(grain: Grain): CycleSeriesPredicate = timeCycle(grain, grain)`
`@@ -192,7 +192,7 @@ object TimePredicateHelpers {`
`192`	`192`	`}`
`193`	`193`	`}`
`194`	`194`
`195`		`- SeriesPredicate(series)`
	`195`	`+ SeriesPredicate(series, cycleSP.maxGrain)`
`196`	`196`	`}`
`197`	`197`
`198`	`198`	`/**`
`@@ -221,7 +221,7 @@ object TimePredicateHelpers {`
`221`	`221`	`else (Stream(nth), Stream.empty)`
`222`	`222`	`}`
`223`	`223`	`}`
`224`		`- SeriesPredicate(series)`
	`224`	`+ SeriesPredicate(series, f.maxGrain)`
`225`	`225`	`}`
`226`	`226`
`227`	`227`	`/**`
`@@ -255,7 +255,7 @@ object TimePredicateHelpers {`
`255`	`255`	`(Stream.iterate(anchor)(f(-1)).tail, Stream.iterate(anchor)(f(1)))`
`256`	`256`	`}`
`257`	`257`	`}`
`258`		`- SeriesPredicate(series)`
	`258`	`+ SeriesPredicate(series, Some(Day))`
`259`	`259`	`}`
`260`	`260`
`261`	`261`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -139,9 +139,13 @@ class TimeTest extends UnitSpec {`
`139`	`139`	`}`
`140`	`140`	`}`
`141`	`141`
`142`		`- it("fix #187") {`
	`142`	`+ it("不需要支持的") {`
`143`	`143`	`val opt = options.copy(full = true, withLatent = false)`
`144`		`- val cases = Table("query", "国庆晚", "十月一晚", "下钟", "晚")`
	`144`	`+ val cases = Table("query",`
	`145`	`+ // fix #187`
	`146`	`+ "国庆晚", "十月一晚", "下钟", "晚",`
	`147`	`+ // fix #259`
	`148`	`+ "上午今天早上七点")`
`145`	`149`	`forAll(cases) {query =>`
`146`	`150`	`parse(query, options = opt) should be (empty)`
`147`	`151`	`}`