Skip to content

Please rename fru-print.py to fru-print or support both #4

@lool

Description

@lool

Hi,

Currently, image-update calls fru-print.py. In Xilinx/xmutil#2, I'm requesting to vendor fru-print into xmutil and to stop installing it as fru-print.py. Probably fru-print could even be removed from usr/bin entirely as it should really be called from xmutil.

In the mean time, it would be nice if image-update would support calling /usr/bin/fru-print or /usr/bin/fru-print.py as Ubuntu currently installs fru-print.py as /usr/bin/fru-print. The patch that we use in Ubuntu is quite trivial, but it's not suitable for inclusion until fru-print.py is renamed to fru-print in petalinux:

===================================================================
--- xmutil-2022.1.orig/image-update/image_update.c
+++ xmutil-2022.1/image-update/image_update.c
@@ -632,7 +632,7 @@ static int validate_board_string(void)
 	FILE *cmd;
 	char revision[10U] = {0U};
 
-	cmd = popen("fru-print.py -b som -f revision", "r");
+	cmd = popen("fru-print -b som -f revision", "r");
 	if (!cmd) {
 		printf("Unable to read Board revision from EEprom\n");
 		return ret;
@@ -644,7 +644,7 @@ static int validate_board_string(void)
 		ret = XST_SUCCESS;
 	} else {
 		printf("Unable to read Board revision from EEprom via ");
-		printf("fru-print.py utility\n");
+		printf("fru-print utility\n");
 	}
 	pclose(cmd);
 

Best
LM

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions