Address comments

Author: mgehre-amd

mlir/lib/Conversion/TosaToLinalg/TosaToLinalg.cpp

@@ -2772,17 +2772,17 @@ void mlir::tosa::populateTosaToLinalgTypeConversion(TypeConverter &converter) {
     return type.clone(converted);
   });
   converter.addSourceMaterialization([&](OpBuilder &builder, Type resultType,
-                               ValueRange inputs,
-                               Location loc) -> std::optional<Value> {
+                                         ValueRange inputs,
+                                         Location loc) -> std::optional<Value> {
     if (inputs.size() != 1)
       return std::nullopt;
 
     return builder.create<UnrealizedConversionCastOp>(loc, resultType, inputs)
         .getResult(0);
   });
   converter.addTargetMaterialization([&](OpBuilder &builder, Type resultType,
-                               ValueRange inputs,
-                               Location loc) -> std::optional<Value> {
+                                         ValueRange inputs,
+                                         Location loc) -> std::optional<Value> {
     if (inputs.size() != 1)
       return std::nullopt;
 

mlir/lib/Conversion/TosaToLinalg/TosaToLinalgNamed.cpp

@@ -794,7 +794,7 @@ class MaxPool2dConverter : public OpConversionPattern<tosa::MaxPool2dOp> {
 
     else if (isUnsigned)
       initialAttr = rewriter.getIntegerAttr(
-          resultETy, APInt::getMinValue(resultETy.getIntOrFloatBitWidth()));
+          resultETy, APInt::getZero(resultETy.getIntOrFloatBitWidth()));
     else if (isa<IntegerType>(resultETy))
       initialAttr = rewriter.getIntegerAttr(
           resultETy,
@@ -1106,7 +1106,8 @@ class TransposeConverter : public OpRewritePattern<tosa::TransposeOp> {
 } // namespace
 
 void mlir::tosa::populateTosaToLinalgNamedConversionPatterns(
-     TypeConverter &converter, RewritePatternSet *patterns, const TosaToLinalgNamedOptions &options) {
+    TypeConverter &converter, RewritePatternSet *patterns,
+    const TosaToLinalgNamedOptions &options) {
   if (options.preferConv2DKernelLayoutHWCF) {
     patterns->add<ConvConverter<tosa::Conv2DOp, linalg::Conv2DNhwcHwcfOp,
                                 linalg::Conv2DNhwcHwcfQOp>>(
@@ -1125,7 +1126,6 @@ void mlir::tosa::populateTosaToLinalgNamedConversionPatterns(
       TransposeConverter
   >(patterns->getContext());
   patterns->add<
-      // clang-format off
       MaxPool2dConverter
     >(converter, patterns->getContext());
   patterns->add<

mlir/lib/Conversion/TosaToLinalg/TosaToLinalgNamedPass.cpp

@@ -71,7 +71,8 @@ struct TosaToLinalgNamed
     TosaToLinalgNamedOptions options;
     options.preferConv2DKernelLayoutHWCF = preferConv2DKernelLayoutHWCF;
     options.useMatmulForSingleBatch = useMatmulForSingleBatch;
-    tosa::populateTosaToLinalgNamedConversionPatterns(converter, &patterns, options);
+    tosa::populateTosaToLinalgNamedConversionPatterns(converter, &patterns,
+                                                      options);
     if (failed(applyFullConversion(func, target, std::move(patterns))))
       signalPassFailure();
   }