Modify transform-op-hoist-pad/transform-op-hoist-pad-build-packing-loop-nest.mlir:

The change to not slice when tiling with domain size caused a tensor.extract_slice
on %arg1 to disappear. The previous tensor.extract_slice was actually a noop:

%extracted_slice_1 = tensor.extract_slice %arg1[0, 0] [12, 25] [1, 1] : tensor<12x25xf32> to tensor<12x25xf32>

while %arg1 is defined as:  %arg1: tensor<12x25xf32>

Since the second operand of the matmul is no longer an extract slice but a block argument the emitted error
message also changed.

Author: josel-amd

mlir/test/Dialect/Linalg/transform-op-hoist-pad-build-packing-loop-nest.mlir

@@ -6,6 +6,7 @@ func.func @pad_and_hoist_rhs(
   %arg0: tensor<24x12xf32>, %arg1: tensor<12x25xf32>, %arg2: tensor<24x25xf32>)
      -> tensor<24x25xf32>
 {
+  // expected-note @below {{target op}}
   %0 = linalg.matmul ins(%arg0, %arg1 : tensor<24x12xf32>, tensor<12x25xf32>) outs(%arg2 : tensor<24x25xf32>) -> tensor<24x25xf32>
   func.return %0 : tensor<24x25xf32>
 }
@@ -24,10 +25,11 @@ module attributes {transform.with_named_sequence} {
 
     // In this case, the pad op is actually empty: we only tile the first dimension
     // and it does not have an impact on the RHS operand.
+    // expected-error @below {{could not find a producer for operand number: 1}}
     %pad = transform.get_producer_of_operand %matmul_padded[1]
       : (!transform.any_op) -> !transform.any_op
 
-    // expected-error @below {{requires exactly 2 non-null handles}}
+    // We do not even reach this transform op.
     transform.structured.hoist_pad.build_packing_loop_nest %pad above %loops_l1
        : (!transform.any_op, !transform.any_op) -> !transform.any_op
        transform.yield

mlir/test/Dialect/Linalg/transform-op-hoist-pad.mlir

@@ -4,7 +4,7 @@ func.func @pad_and_hoist_rhs(
   %arg0: tensor<24x12xf32>, %arg1: tensor<12x25xf32>, %arg2: tensor<24x25xf32>)
      -> tensor<24x25xf32>
 {
-  // expected-note @below {{payload operation}}
+  // expected-note @below {{target op}}
   %0 = linalg.matmul ins(%arg0, %arg1 : tensor<24x12xf32>, tensor<12x25xf32>) outs(%arg2 : tensor<24x25xf32>) -> tensor<24x25xf32>
   func.return %0 : tensor<24x25xf32>
 }
@@ -25,7 +25,7 @@ module attributes {transform.with_named_sequence} {
 
     // In this case, the pad op is actually empty: we only tile the first dimension
     // and it does not have an impact on the RHS operand.
-    // expected-error @below {{incompatible payload operation name}}
+    // expected-error @below {{could not find a producer for operand number: 1}}
     %pad = transform.get_producer_of_operand %matmul_padded[1]
       : (!transform.any_op) -> !transform.op<"tensor.pad">