Skip to content

Commit c9b35c8

Browse files
committed
Partially revert "Fixed type conversion for tosa.abs when lowering to linalg".
1 parent 1e53fb5 commit c9b35c8

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

mlir/lib/Conversion/TosaToLinalg/TosaToLinalg.cpp

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,8 @@ createConstFromIntAttribute(Operation *op, const std::string &attrName,
4747
}
4848

4949
static Value createLinalgBodyCalculationForElementwiseOp(
50-
Operation *op, const TypeConverter &converter, ValueRange args,
51-
ArrayRef<Type> resultTypes, ConversionPatternRewriter &rewriter) {
50+
Operation *op, ValueRange args, ArrayRef<Type> resultTypes,
51+
ConversionPatternRewriter &rewriter) {
5252
Location loc = op->getLoc();
5353
auto elementTy =
5454
cast<ShapedType>(op->getOperand(0).getType()).getElementType();
@@ -61,7 +61,7 @@ static Value createLinalgBodyCalculationForElementwiseOp(
6161

6262
if (isa<tosa::AbsOp>(op) && isa<IntegerType>(elementTy)) {
6363
auto zero = rewriter.create<arith::ConstantOp>(
64-
loc, rewriter.getZeroAttr(converter.convertType(elementTy)));
64+
loc, rewriter.getZeroAttr(elementTy));
6565
auto neg = rewriter.create<arith::SubIOp>(loc, zero, args[0]);
6666
return rewriter.create<arith::MaxSIOp>(loc, args[0], neg);
6767
}
@@ -948,8 +948,7 @@ emitElementwiseComputation(ConversionPatternRewriter &rewriter, Location loc,
948948
getNParallelLoopsAttrs(rank),
949949
[&](OpBuilder &opBuilder, Location loc, ValueRange blockArgs) {
950950
Value opResult = createLinalgBodyCalculationForElementwiseOp(
951-
operation, converter,
952-
blockArgs.take_front(operation->getNumOperands()),
951+
operation, blockArgs.take_front(operation->getNumOperands()),
953952
{resultType.getElementType()}, rewriter);
954953
if (!opResult) {
955954
encounteredError = true;

0 commit comments

Comments
 (0)