emitc.include: don't require the parent to be a ModuleOp #396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`#include` make sense everywhere, and in particular we need to allow them inside a `emitc.tu`. But sometimes we might even want to have an `#include` in a function body.
cferry-AMD
approved these changes
Nov 7, 2024
Collaborator
cferry-AMD
left a comment
cferry-AMD
left a comment
There was a problem hiding this comment.
LGTM. Do you know of any passes that check for a specific include? Those will need to search the entire module now up to the site the include is used.
Collaborator
Author
I'm not aware of any. Likely because emitc dialect is mostly generated and seldomly consumed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#includemake sense everywhere, and in particular we need to allow them inside aemitc.tu. But sometimes we might even want to have an#includein a function body.