Allow operands and results of tosa.custom to be None. #579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wering from dialects that support None operands or results
mathmer-amd
approved these changes
Jun 23, 2025
Comment on lines
+698
to
+702
| // CHECK-LABEL: test_custom_none | ||
| func.func @test_custom_none(%arg0: tensor<10xi32>, %arg1: none) -> tensor<10xi32> { | ||
| %0 = tosa.custom %arg0, %arg1 {operator_name="custom_test", domain_name="tosa.mlir_test", implementation_attrs="" } : (tensor<10xi32>, none) -> (tensor<10xi32>) | ||
| return %0 : tensor<10xi32> | ||
| } |
There was a problem hiding this comment.
NIT: I think it could be nice to have the other test where the output of tosa.custom is None
Author
|
Closing, its likely better to not convert operations with a none argument to tosa.custon |
Aggred, I think it is a better idea to fail the lowering until we have a clear understanding on how TOSA deals with none |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables lowering from dialects that support None operands or results