Add: prevent onnx to tosa legalization when the size (lhs most parameter) is not constant

Author: Samnour2

src/Conversion/ONNXToTOSA/Tensor/Resize.cpp

@@ -31,7 +31,7 @@ struct ScaleHelper {
   ScaleHelper(
       int64_t numerator, int64_t denominator, int64_t offset, int64_t border)
       : numerator(numerator), denominator(denominator), offset(offset),
-        border(border){};
+        border(border) {};
   int64_t numerator, denominator, offset, border;
 };
 
@@ -203,6 +203,16 @@ class ONNXResizeOpLoweringToTOSA : public ConversionPattern {
           resizeOp, "Only static sized tensors are supported.");
     }
 
+    Value sizesValue = resizeOp.getSizes();
+    if (!isNoneValue(sizesValue)) {
+      mlir::ElementsAttr sizesAttr =
+          getElementAttributeFromONNXValue(sizesValue);
+      if (!sizesAttr) {
+        return rewriter.notifyMatchFailure(
+            resizeOp, "Sizes must be a constant tensor for static inputs.");
+      }
+    }
+
     auto elementType = inputType.getElementType();
     if (!(isa<FloatType>(elementType) || isTOSAInt(elementType))) {
       return rewriter.notifyMatchFailure(

test/mlir/conversion/onnx_to_tosa/Tensor/Resize.mlir

@@ -252,3 +252,26 @@ func.func @test_resize_cubic_disallowed(%arg0: tensor<1x1x2x4xf32>) -> tensor<1x
 // CHECK-LABEL:  func.func @test_resize_cubic_disallowed
 // CHECK-LABEL:  onnx.Resize
 }
+
+// -----
+
+func.func @test_resize_size_constant_disallowed(%arg0: tensor<1x1x2x4xf32>, %arg1: tensor<4xi64>, %arg2: tensor<4xi64>) -> tensor<1x1x2x8xf32> {
+    %0 = "onnx.NoValue"() {value} : () -> none
+    %2 = "onnx.Add"(%arg1, %arg2) {} : (tensor<4xi64>, tensor<4xi64>) -> tensor<4xi64> 
+    %3 = "onnx.Resize"(%arg0, %0, %0, %2) {antialias = 0 : si64, coordinate_transformation_mode = "half_pixel", cubic_coeff_a = -7.500000e-01 : f32, exclude_outside = 0 : si64, extrapolation_value = 0.000000e+00 : f32, keep_aspect_ratio_policy = "stretch", mode = "linear", nearest_mode = "floor"} : (tensor<1x1x2x4xf32>, none, none, tensor<4xi64>) -> tensor<1x1x2x8xf32>
+    return %3 : tensor<1x1x2x8xf32>
+// CHECK-LABEL:  func.func @test_resize_size_constant_disallowed
+// CHECK-LABEL:  onnx.Resize
+}
+
+// -----
+
+func.func @test_resize_size_constant_allowed(%arg0: tensor<1x1x2x4xf32>, %arg1: tensor<4xi64>, %arg2: tensor<4xi64>) -> tensor<1x1x2x8xf32> {
+    %0 = "onnx.NoValue"() {value} : () -> none
+    %1 = "onnx.Constant"() {value = dense_resource<__elided__> : tensor<4xi64>} : () -> tensor<4xi64>
+    %2 = "onnx.Resize"(%arg0, %0, %0, %1) {antialias = 0 : si64, coordinate_transformation_mode = "half_pixel", cubic_coeff_a = -7.500000e-01 : f32, exclude_outside = 0 : si64, extrapolation_value = 0.000000e+00 : f32, keep_aspect_ratio_policy = "stretch", mode = "linear", nearest_mode = "floor"} : (tensor<1x1x2x4xf32>, none, none, tensor<4xi64>) -> tensor<1x1x2x8xf32>
+    return %2 : tensor<1x1x2x8xf32>
+// CHECK-LABEL:  func.func @test_resize_size_constant_allowed
+// CHECK-NOT:  onnx.Resize
+}
+