Skip to content

Commit d893b73

Browse files
improving the comments
1 parent 05dad07 commit d893b73

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

src/Dialect/ONNX/Transforms/Decompose.cpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1713,9 +1713,7 @@ Value decomposeIntoPhasedConvs(PatternRewriter &rewriter, Location loc,
17131713
startOnnxConstant, endOnnxConstant, axisOnnxConstant,
17141714
stepOnnxConstant);
17151715
}
1716-
1717-
// The four convOutputs are adjusted to add an extra dimension at the
1718-
// innermost level.
1716+
// Four conv outputs are merged in channel dim
17191717
SmallVector<int64_t> outputShapeOfConcat = {
17201718
1, convOutputShape[1] * 4, convOutputShape[2], convOutputShape[3]};
17211719
auto concatOutputType =
@@ -1725,7 +1723,7 @@ Value decomposeIntoPhasedConvs(PatternRewriter &rewriter, Location loc,
17251723
// This is observed by looking at the phased conv outputs with respect to
17261724
// convtranspose output.
17271725
bool reverseConcatOrder = (needWeightsPadding || (kernelShape[0] == 4));
1728-
// Below concats result will have the innermost dim as 2.
1726+
// The concat output will have 4 times the channels of a single conv.
17291727
auto firstConcat =
17301728
(reverseConcatOrder)
17311729
? rewriter.create<ONNXConcatOp>(loc, concatOutputType,

0 commit comments

Comments
 (0)