Skip to content

Commit ad9dfe9

Browse files
authored
Fix clang warning about printf format (llvm#3814)
Compiling with clang 16.0 on macOS I have warnings about incorrect printf format (see below). Values to be printed are `int64_t`, but they are printed with `%zu` and `%ld`, which are not portable way to print this type. ``` <...>/torch-mlir/test/CAPI/torch.c:52:3: warning: format specifies type 'size_t' (aka 'unsigned long') but the argument has type 'int64_t' (aka 'long long') [-Wformat] 52 | DEFINE_CHECK(NonValueTensor) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ <...>/torch-mlir/test/CAPI/torch.c:37:13: note: expanded from macro 'DEFINE_CHECK' 36 | fprintf(stderr, #TTT "Type %s rank: %zu\n", testName, \ | ~~~ 37 | torchMlirTorch##TTT##TypeGetRank(TTT##Type)); \ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ <scratch space>:78:1: note: expanded from here 78 | torchMlirTorchNonValueTensorTypeGetRank | ^ <...>/torch-mlir/test/CAPI/torch.c:52:3: warning: format specifies type 'long' but the argument has type 'int64_t' (aka 'long long') [-Wformat] 52 | DEFINE_CHECK(NonValueTensor) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ <...>/torch-mlir/test/CAPI/torch.c:42:15: note: expanded from macro 'DEFINE_CHECK' 41 | fprintf(stderr, #TTT "Type %s pos %d size: %ld\n", testName, i, \ | ~~~ 42 | TTT##Sizes[i]); \ | ^~~~~~~~~~~~~ <scratch space>:85:1: note: expanded from here 85 | NonValueTensorSizes | ^ <...>/torch-mlir/test/CAPI/torch.c:53:3: warning: format specifies type 'size_t' (aka 'unsigned long') but the argument has type 'int64_t' (aka 'long long') [-Wformat] 53 | DEFINE_CHECK(ValueTensor) | ^~~~~~~~~~~~~~~~~~~~~~~~~ <...>/torch-mlir/test/CAPI/torch.c:37:13: note: expanded from macro 'DEFINE_CHECK' 36 | fprintf(stderr, #TTT "Type %s rank: %zu\n", testName, \ | ~~~ 37 | torchMlirTorch##TTT##TypeGetRank(TTT##Type)); \ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ <scratch space>:112:1: note: expanded from here 112 | torchMlirTorchValueTensorTypeGetRank | ^ <...>/torch-mlir/test/CAPI/torch.c:53:3: warning: format specifies type 'long' but the argument has type 'int64_t' (aka 'long long') [-Wformat] 53 | DEFINE_CHECK(ValueTensor) | ^~~~~~~~~~~~~~~~~~~~~~~~~ <...>/torch-mlir/test/CAPI/torch.c:42:15: note: expanded from macro 'DEFINE_CHECK' 41 | fprintf(stderr, #TTT "Type %s pos %d size: %ld\n", testName, i, \ | ~~~ 42 | TTT##Sizes[i]); \ | ^~~~~~~~~~~~~ <scratch space>:119:1: note: expanded from here 119 | ValueTensorSizes | ^ 4 warnings generated. ```
1 parent 76209db commit ad9dfe9

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

test/CAPI/torch.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,12 +33,12 @@ static void testTensor(MlirContext ctx, intptr_t numSizes, int64_t *sizes,
3333
bool TTT##hasDtype = torchMlirTorch##TTT##TypeHasDtype(TTT##Type); \
3434
fprintf(stderr, #TTT "Type %s hasDtype: %d\n", testName, TTT##hasDtype); \
3535
if (TTT##hasSizes) { \
36-
fprintf(stderr, #TTT "Type %s rank: %zu\n", testName, \
36+
fprintf(stderr, #TTT "Type %s rank: %" PRId64 "\n", testName, \
3737
torchMlirTorch##TTT##TypeGetRank(TTT##Type)); \
3838
int64_t *TTT##Sizes = malloc(sizeof(int64_t) * numSizes); \
3939
torchMlirTorch##TTT##TypeGetSizes(TTT##Type, TTT##Sizes); \
4040
for (int i = 0; i < numSizes; ++i) { \
41-
fprintf(stderr, #TTT "Type %s pos %d size: %ld\n", testName, i, \
41+
fprintf(stderr, #TTT "Type %s pos %d size: %" PRId64 "\n", testName, i, \
4242
TTT##Sizes[i]); \
4343
} \
4444
} \

0 commit comments

Comments
 (0)