consensus/XDPoS: use slices package for sorting

Author: gzliudan

consensus/XDPoS/api.go

@@ -23,7 +23,7 @@ import (
 	"math/big"
 	"os"
 	"path/filepath"
-	"sort"
+	"slices"
 	"strconv"
 	"strings"
 
@@ -486,8 +486,11 @@ func (api *API) getRewardFileNamesInRange(begin, end *rpc.BlockNumber) ([]reward
 	if err != nil {
 		return nil, err
 	}
+	if len(files) == 0 {
+		return nil, errors.New("no file in rewards folder")
+	}
 
-	var rewardFileNames = []rewardFileName{}
+	rewardFileNames := make([]rewardFileName, 0, len(files))
 	for _, file := range files {
 		if !file.IsDir() {
 			filePrefix, fileSuffix, found := strings.Cut(file.Name(), ".")
@@ -506,26 +509,29 @@ func (api *API) getRewardFileNamesInRange(begin, end *rpc.BlockNumber) ([]reward
 			}
 		}
 	}
-
-	sort.Slice(rewardFileNames, func(i, j int) bool {
-		return rewardFileNames[i].epochBlockNum < rewardFileNames[j].epochBlockNum
-	})
-
-	epochNumbers := make([]int, len(rewardFileNames))
-	for i, obj := range rewardFileNames {
-		epochNumbers[i] = obj.epochBlockNum
+	if len(rewardFileNames) == 0 {
+		return nil, errors.New("no reward file in rewards folder")
 	}
 
-	startIndex := sort.SearchInts(epochNumbers, int(beginHeader.Number.Int64()))
-	endIndex := sort.SearchInts(epochNumbers, int(endHeader.Number.Int64()))
-	if endIndex == len(epochNumbers) {
-		endIndex-- //this is to prevent endIndex out of bounds when endInput is higher than last reward(epoch) block but lower than latest block
+	slices.SortFunc(rewardFileNames, func(a, b rewardFileName) int {
+		return a.epochBlockNum - b.epochBlockNum
+	})
+	startIndex, _ := slices.BinarySearchFunc(rewardFileNames, int(beginHeader.Number.Int64()), func(rfn rewardFileName, number int) int {
+		return rfn.epochBlockNum - number
+	})
+	if startIndex == len(rewardFileNames) {
+		// retrun early if startIndex is out of bounds
+		return []rewardFileName{}, nil
 	}
-
-	var rewardfileNamesInRange []rewardFileName
-	for i := startIndex; i <= endIndex; i++ {
-		rewardfileNamesInRange = append(rewardfileNamesInRange, rewardFileNames[i])
+	endIndex, _ := slices.BinarySearchFunc(rewardFileNames, int(endHeader.Number.Int64()), func(rfn rewardFileName, number int) int {
+		return rfn.epochBlockNum - number
+	})
+	if endIndex != len(rewardFileNames) {
+		endIndex++ // include the endIndex file
 	}
+	// create a new slice by copy in case of rewardFileNames is large
+	rewardfileNamesInRange := make([]rewardFileName, endIndex-startIndex)
+	copy(rewardfileNamesInRange, rewardFileNames[startIndex:endIndex])
 	return rewardfileNamesInRange, nil
 }