Skip to content

Commit d27e90a

Browse files
committed
verify timeout from epochInfo instead of snap.NextEpochCandidates
1 parent d45da0a commit d27e90a

File tree

1 file changed

+1
-11
lines changed

1 file changed

+1
-11
lines changed

consensus/XDPoS/engines/engine_v2/timeout.go

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -157,16 +157,6 @@ func (x *XDPoS_v2) verifyTC(chain consensus.ChainReader, timeoutCert *types.Time
157157
return utils.ErrInvalidTC
158158
}
159159

160-
snap, err := x.getSnapshot(chain, timeoutCert.GapNumber, true)
161-
if err != nil {
162-
log.Error("[verifyTC] Fail to get snapshot when verifying TC!", "tcGapNumber", timeoutCert.GapNumber)
163-
return fmt.Errorf("[verifyTC] Unable to get snapshot, %s", err)
164-
}
165-
if snap == nil || len(snap.NextEpochCandidates) == 0 {
166-
log.Error("[verifyTC] Something wrong with the snapshot from gapNumber", "messageGapNumber", timeoutCert.GapNumber, "snapshot", snap)
167-
return errors.New("empty master node lists from snapshot")
168-
}
169-
170160
signatures, duplicates := UniqueSignatures(timeoutCert.Signatures)
171161
if len(duplicates) != 0 {
172162
for _, d := range duplicates {
@@ -199,7 +189,7 @@ func (x *XDPoS_v2) verifyTC(chain consensus.ChainReader, timeoutCert *types.Time
199189
for _, signature := range signatures {
200190
go func(sig types.Signature) {
201191
defer wg.Done()
202-
verified, _, err := x.verifyMsgSignature(signedTimeoutObj, sig, snap.NextEpochCandidates)
192+
verified, _, err := x.verifyMsgSignature(signedTimeoutObj, sig, epochInfo.Masternodes)
203193
if err != nil || !verified {
204194
log.Error("[verifyTC] Error or verification failure", "signature", sig, "error", err)
205195
mutex.Lock() // Lock before accessing haveError

0 commit comments

Comments
 (0)