version 2 for xoopsconfirm

Author: ggoffy

admin/modules.php

@@ -190,10 +190,11 @@
                 $GLOBALS['xoopsTpl']->assign('error', $modulesObj->getHtmlErrors());
             }
         } else {
-            $xoopsconfirm =  new \XoopsModules\Modulebuilder\Common\XoopsConfirm();
-            $xoopsconfirm->hiddens = ['ok' => 1, 'mod_id' => $modId, 'op' => 'delete'];
-            $xoopsconfirm->action = \Xmf\Request::getString('REQUEST_URI', '', 'SERVER');
-            $xoopsconfirm->object = $modulesObj->getVar('mod_name');
+            $xoopsconfirm = new \XoopsModules\Modulebuilder\Common\XoopsConfirm(
+                                        ['ok' => 1, 'mod_id' => $modId, 'op' => 'delete'],
+                                        \Xmf\Request::getString('REQUEST_URI', '', 'SERVER'),
+                                        $modulesObj->getVar('mod_name')
+                            );
             $form = $xoopsconfirm->getFormXoopsConfirm();
             $GLOBALS['xoopsTpl']->assign('form', $form->render());
         }

class/Common/XoopsConfirm.php

@@ -30,37 +30,28 @@
 /**
  * Class Object XoopsConfirm
  */
-class XoopsConfirm extends \XoopsObject
+class XoopsConfirm
 {
-    public $hiddens  = [];
-    public $action   = '';
-    public $title    = '';
-    public $label    = '';
-    public $object   = '';
+    private $hiddens  = [];
+    private $action   = '';
+    private $title    = '';
+    private $label    = '';
+    private $object   = '';
 
     /**
      * @public function constructor class
      *
      * @param null
      */
-    public function __construct()
+    public function __construct($hiddens, $action, $object, $title = '', $label = '')
     {
+        $this->hiddens = $hiddens;
+        $this->action  = $action;
+        $this->object  = $object;
+        $this->title   = $title;
+        $this->label   = $label;
     }
 
-    /**
-     * @static function &getInstance
-     *
-     * @param null
-     */
-    public static function getInstance()
-    {
-        static $instance = false;
-        if (!$instance) {
-            $instance = new self();
-        }
-    }
-
-
     /**
      * @public function getXoopsConfirm
      * @param bool $action
@@ -85,7 +76,7 @@ public function getFormXoopsConfirm()
         }
 
         xoops_load('XoopsFormLoader');
-        $form = new \XoopsThemeForm($this->title, 'form', $this->action, 'post', true);
+        $form = new \XoopsThemeForm($this->title, 'formXoopsConfirm', $this->action, 'post', true);
         $form->setExtra('enctype="multipart/form-data"');
         $form->addElement(new \XoopsFormLabel($this->label, $this->object));
         //hiddens