code cosmetics

Author: ggoffy

class/Files/Blocks/BlocksFiles.php

@@ -143,6 +143,12 @@ private function getBlocksShow($moduleDirname, $tableName, $tableFieldname, $fie
             $critStatus .= $this->xc->getXcCriteriaAdd($critName, $crit, "\t\t\t");
         }
 
+        $case1 = [];
+        $case2 = [];
+        $case3 = [];
+        $case4 = [];
+        $case5 = [];
+
         $case1[] = $this->pc->getPhpCodeCommentLine("For the block: {$tableName} last",'',"\t\t\t");
         if ('' !== $fieldStatus) {
             $case1[] = $critStatus;

class/Files/CreateArchitecture.php

@@ -751,6 +751,7 @@ public function setCommonFiles($module)
         $patValues = array_values($patterns);
 
         /* clone complete missing folders */
+        $cloneFolders = [];
         $cloneFolders[] = [
             'src'   => TDMC_PATH . '/files/commonfiles',
             'dst'   => $upl_path,

class/Files/CreateXoopsCode.php

@@ -963,7 +963,7 @@ public function getXcSecurity($tableName, $t = '')
         $pc              = Modulebuilder\Files\CreatePhpCode::getInstance();
         $securityError   = $this->getXcXoopsSecurityErrors();
         $implode         = $pc->getPhpCodeImplode(',', $securityError);
-        $content         = "{$t}\t" . $this->getXcRedirectHeader($tableName, '', 3, $implode, $t);
+        $content         = "{$t}\t" . $this->getXcRedirectHeader($tableName, '', 3, $implode, false, $t);
         $securityCheck   = $this->getXcXoopsSecurityCheck();
 
         return $pc->getPhpCodeConditions('!' . $securityCheck, '', '', $content, $t);
@@ -992,7 +992,6 @@ public function getXcInsertData($tableName, $language, $t = '')
      * @param        $numb
      * @param        $var
      * @param bool   $isString
-     *
      * @param string $t
      * @return string
      */

class/Files/Sql/SqlFile.php

@@ -354,34 +354,19 @@ private function getDatabaseFields($moduleDirname, $tableMid, $tableId, $tableNa
      */
     private function getTableRatings($moduleDirname)
     {
-        $ret           = null;
-        $j             = 0;
-        $comma         = [];
-        $row           = [];
 
-        $ret            = $this->getHeadDatabaseTable($moduleDirname, 'ratings', 6);
+        $row   = [];
+        $ret   = $this->getHeadDatabaseTable($moduleDirname, 'ratings', 6);
         $row[] = $this->getFieldRow('rate_id', 'INT(8)', 'UNSIGNED', 'NOT NULL', null, 'AUTO_INCREMENT');
-        $comma[$j] = $this->getKey(2, 'rate_id');
-        ++$j;
         $row[] = $this->getFieldRow('rate_itemid', 'INT(8)', null, 'NOT NULL', "DEFAULT '0'");
         $row[] = $this->getFieldRow('rate_source', 'INT(8)', null, 'NOT NULL', "DEFAULT '0'");
         $row[] = $this->getFieldRow('rate_value', 'INT(1)', null, 'NOT NULL', "DEFAULT '0'");
         $row[] = $this->getFieldRow('rate_uid', 'INT(8)', null, 'NOT NULL', "DEFAULT '0'");
         $row[] = $this->getFieldRow('rate_ip', 'VARCHAR(60)', null, 'NOT NULL', "DEFAULT ''");
         $row[] = $this->getFieldRow('rate_date', 'INT(8)', null, 'NOT NULL', "DEFAULT '0'");
+        $row[] = $this->getKey(2, 'rate_id');
 
-
-        // ================= COMMA ================= //
-        for ($i = 0; $i < $j; ++$i) {
-            if ($i != $j - 1) {
-                $row[] = $comma[$i] . ',';
-            } else {
-                $row[] = $comma[$i];
-            }
-        }
-        // ================= COMMA CICLE ================= //
         $ret .= implode("\n", $row);
-        unset($j);
         $ret .= $this->getFootDatabaseTable();
 
         return $ret;

class/Modules.php

@@ -189,14 +189,14 @@ public function getFormModules($action = false)
         $form->setExtra('enctype="multipart/form-data"');
 
         $modName = $isNew ? $set['name'] : $this->getVar('mod_name');
-        $modName = new \XoopsFormText(_AM_MODULEBUILDER_MODULE_NAME, 'mod_name', 50, 255, $modName);
-        $modName->setDescription(_AM_MODULEBUILDER_MODULE_NAME_DESC);
-        $form->addElement($modName, true);
+        $modNameText = new \XoopsFormText(_AM_MODULEBUILDER_MODULE_NAME, 'mod_name', 50, 255, $modName);
+        $modNameText->setDescription(_AM_MODULEBUILDER_MODULE_NAME_DESC);
+        $form->addElement($modNameText, true);
 
         $modDirname = $isNew ? $set['dirname'] : $this->getVar('mod_dirname');
-        $modDirname = new \XoopsFormText(_AM_MODULEBUILDER_MODULE_DIRNAME, 'mod_dirname', 25, 255, $modDirname);
-        $modDirname->setDescription(_AM_MODULEBUILDER_MODULE_DIRNAME_DESC);
-        $form->addElement($modDirname, true);
+        $modDirnameText = new \XoopsFormText(_AM_MODULEBUILDER_MODULE_DIRNAME, 'mod_dirname', 25, 255, $modDirname);
+        $modDirnameText->setDescription(_AM_MODULEBUILDER_MODULE_DIRNAME_DESC);
+        $form->addElement($modDirnameText, true);
 
         $modVersion = $isNew ? $set['version'] : $this->getVar('mod_version');
         $form->addElement(new \XoopsFormText(_AM_MODULEBUILDER_MODULE_VERSION, 'mod_version', 10, 25, $modVersion), true);