Skip to content

Commit c3e484f

Browse files
committed
test: e2e 테스트 코드 BaseResponse success 체킹 제거
1 parent f5efd8d commit c3e484f

12 files changed

+6
-55
lines changed

src/test/kotlin/com/yapp2app/e2e/media/GenerateUploadTicketE2ETest.kt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,6 @@ class GenerateUploadTicketE2ETest : MediaE2ETestBase() {
6363
.post("/api/media/upload")
6464
.then()
6565
.statusCode(HttpStatus.OK.value())
66-
.body("success", equalTo(true))
6766
.body("resultCode", equalTo(ResultCode.SUCCESS.code))
6867
.body("data.mediaId", notNullValue())
6968
.body("data.uploadUrl", notNullValue())
@@ -99,7 +98,7 @@ class GenerateUploadTicketE2ETest : MediaE2ETestBase() {
9998
.post("/api/media/upload")
10099
.then()
101100
.statusCode(HttpStatus.OK.value())
102-
.body("success", equalTo(true))
101+
.body("resultCode", equalTo(ResultCode.SUCCESS.code))
103102
.extract()
104103
.path<Int>("data.mediaId")
105104
.toLong()
@@ -129,7 +128,7 @@ class GenerateUploadTicketE2ETest : MediaE2ETestBase() {
129128
.post("/api/media/upload")
130129
.then()
131130
.statusCode(HttpStatus.OK.value())
132-
.body("success", equalTo(true))
131+
.body("resultCode", equalTo(ResultCode.SUCCESS.code))
133132
.extract()
134133
.path<Int>("data.mediaId")
135134
.toLong()

src/test/kotlin/com/yapp2app/e2e/photo/folder/CreateFolderE2ETest.kt

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,6 @@ class CreateFolderE2ETest : FolderE2ETestBase() {
5151
.post("/api/folders")
5252
.then()
5353
.statusCode(HttpStatus.OK.value())
54-
.body("success", equalTo(true))
5554
.body("resultCode", equalTo(ResultCode.SUCCESS.code))
5655
}
5756

@@ -71,7 +70,6 @@ class CreateFolderE2ETest : FolderE2ETestBase() {
7170
.post("/api/folders")
7271
.then()
7372
.statusCode(HttpStatus.OK.value())
74-
.body("success", equalTo(true))
7573
.body("resultCode", equalTo(ResultCode.SUCCESS.code))
7674
}
7775
}
@@ -87,7 +85,6 @@ class CreateFolderE2ETest : FolderE2ETestBase() {
8785
.post("/api/folders")
8886
.then()
8987
.statusCode(HttpStatus.BAD_REQUEST.value())
90-
.body("success", equalTo(false))
9188
.body("resultCode", equalTo(ResultCode.INVALID_PARAMETER.code))
9289
}
9390

@@ -108,7 +105,6 @@ class CreateFolderE2ETest : FolderE2ETestBase() {
108105
.post("/api/folders")
109106
.then()
110107
.statusCode(HttpStatus.BAD_REQUEST.value())
111-
.body("success", equalTo(false))
112108
.body("resultCode", equalTo(ResultCode.INVALID_PARAMETER.code))
113109
}
114110

@@ -125,7 +121,6 @@ class CreateFolderE2ETest : FolderE2ETestBase() {
125121
.post("/api/folders")
126122
.then()
127123
.statusCode(HttpStatus.OK.value())
128-
.body("success", equalTo(true))
129124
.body("resultCode", equalTo(ResultCode.SUCCESS.code))
130125

131126
// 동일한 이름으로 재요청
@@ -137,7 +132,6 @@ class CreateFolderE2ETest : FolderE2ETestBase() {
137132
.post("/api/folders")
138133
.then()
139134
.statusCode(HttpStatus.BAD_REQUEST.value())
140-
.body("success", equalTo(false))
141135
.body("resultCode", equalTo(ResultCode.CONFLICT_FOLDER.code))
142136
}
143137
}

src/test/kotlin/com/yapp2app/e2e/photo/folder/DeleteFolderE2ETest.kt

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,6 @@ class DeleteFolderE2ETest : FolderE2ETestBase() {
5757
.post("/api/folders")
5858
.then()
5959
.statusCode(HttpStatus.OK.value())
60-
.body("success", equalTo(true))
6160
.body("resultCode", equalTo(ResultCode.SUCCESS.code))
6261
.extract()
6362
.`as`(object : TypeRef<BaseResponse<CreateFolderResponse>>() {})
@@ -70,7 +69,6 @@ class DeleteFolderE2ETest : FolderE2ETestBase() {
7069
.delete("/api/folders/${response.data?.folderId}")
7170
.then()
7271
.statusCode(HttpStatus.OK.value())
73-
.body("success", equalTo(true))
7472
.body("resultCode", equalTo(ResultCode.SUCCESS.code))
7573
}
7674

@@ -88,7 +86,6 @@ class DeleteFolderE2ETest : FolderE2ETestBase() {
8886
.delete("/api/folders/$nonExistentFolderId")
8987
.then()
9088
.statusCode(HttpStatus.BAD_REQUEST.value())
91-
.body("success", equalTo(false))
9289
.body("resultCode", equalTo(ResultCode.NOT_FOUND.code))
9390
}
9491

@@ -109,7 +106,6 @@ class DeleteFolderE2ETest : FolderE2ETestBase() {
109106
.delete("/api/folders/${otherUserFolder.id}")
110107
.then()
111108
.statusCode(HttpStatus.BAD_REQUEST.value())
112-
.body("success", equalTo(false))
113109
.body("resultCode", equalTo(ResultCode.NOT_FOUND.code))
114110
}
115111
}

src/test/kotlin/com/yapp2app/e2e/photo/folder/DeleteFoldersE2ETest.kt

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,6 @@ class DeleteFoldersE2ETest : FolderE2ETestBase() {
6464
.delete("/api/folders")
6565
.then()
6666
.statusCode(HttpStatus.OK.value())
67-
.body("success", equalTo(true))
6867
.body("resultCode", equalTo(ResultCode.SUCCESS.code))
6968
}
7069

@@ -85,7 +84,6 @@ class DeleteFoldersE2ETest : FolderE2ETestBase() {
8584
.delete("/api/folders")
8685
.then()
8786
.statusCode(HttpStatus.OK.value())
88-
.body("success", equalTo(true))
8987
.body("resultCode", equalTo(ResultCode.SUCCESS.code))
9088
}
9189

@@ -101,7 +99,6 @@ class DeleteFoldersE2ETest : FolderE2ETestBase() {
10199
.delete("/api/folders")
102100
.then()
103101
.statusCode(HttpStatus.BAD_REQUEST.value())
104-
.body("success", equalTo(false))
105102
.body("resultCode", equalTo(ResultCode.INVALID_PARAMETER.code))
106103
}
107104

@@ -124,7 +121,6 @@ class DeleteFoldersE2ETest : FolderE2ETestBase() {
124121
.delete("/api/folders")
125122
.then()
126123
.statusCode(HttpStatus.BAD_REQUEST.value())
127-
.body("success", equalTo(false))
128124
.body("resultCode", equalTo(ResultCode.NOT_FOUND.code))
129125
}
130126

@@ -150,7 +146,6 @@ class DeleteFoldersE2ETest : FolderE2ETestBase() {
150146
.delete("/api/folders")
151147
.then()
152148
.statusCode(HttpStatus.BAD_REQUEST.value())
153-
.body("success", equalTo(false))
154149
.body("resultCode", equalTo(ResultCode.NOT_FOUND.code))
155150
}
156151
}

src/test/kotlin/com/yapp2app/e2e/photo/folder/GetAllFolderE2ETest.kt

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package com.yapp2app.e2e.photo.folder
22

33
import com.yapp2app.common.api.dto.BaseResponse
4+
import com.yapp2app.common.api.dto.ResultCode
45
import com.yapp2app.photo.domain.entity.Folder
56
import com.yapp2app.user.domain.entity.User
67
import io.restassured.RestAssured
@@ -71,7 +72,7 @@ class GetAllFolderE2ETest : FolderE2ETestBase() {
7172
assertThat(response.statusCode()).isEqualTo(HttpStatus.OK.value())
7273

7374
val baseResponse = response.`as`(BaseResponse::class.java)
74-
assertThat(baseResponse.success).isTrue()
75+
assertThat(baseResponse.resultCode).isEqualTo(ResultCode.SUCCESS.code)
7576
}
7677

7778
@Test
@@ -93,7 +94,7 @@ class GetAllFolderE2ETest : FolderE2ETestBase() {
9394
assertThat(response.statusCode()).isEqualTo(HttpStatus.OK.value())
9495

9596
val baseResponse = response.`as`(BaseResponse::class.java)
96-
assertThat(baseResponse.success).isTrue()
97+
assertThat(baseResponse.resultCode).isEqualTo(ResultCode.SUCCESS.code)
9798
}
9899

99100
@Test
@@ -116,6 +117,6 @@ class GetAllFolderE2ETest : FolderE2ETestBase() {
116117
assertThat(response.statusCode()).isEqualTo(HttpStatus.OK.value())
117118

118119
val baseResponse = response.`as`(BaseResponse::class.java)
119-
assertThat(baseResponse.success).isTrue()
120+
assertThat(baseResponse.resultCode).isEqualTo(ResultCode.SUCCESS.code)
120121
}
121122
}

src/test/kotlin/com/yapp2app/e2e/photo/folder/UpdateFolderE2ETest.kt

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,6 @@ class UpdateFolderE2ETest : E2ETestBase() {
7373
.patch("/api/folders/${folder.id}")
7474
.then()
7575
.statusCode(HttpStatus.OK.value())
76-
.body("success", equalTo(true))
7776
.body("resultCode", equalTo(ResultCode.SUCCESS.code))
7877
}
7978

@@ -94,7 +93,6 @@ class UpdateFolderE2ETest : E2ETestBase() {
9493
.patch("/api/folders/${folder.id}")
9594
.then()
9695
.statusCode(HttpStatus.BAD_REQUEST.value())
97-
.body("success", equalTo(false))
9896
.body("resultCode", equalTo(ResultCode.INVALID_PARAMETER.code))
9997
}
10098

@@ -121,7 +119,6 @@ class UpdateFolderE2ETest : E2ETestBase() {
121119
.patch("/api/folders/${folder.id}")
122120
.then()
123121
.statusCode(HttpStatus.BAD_REQUEST.value())
124-
.body("success", equalTo(false))
125122
.body("resultCode", equalTo(ResultCode.INVALID_PARAMETER.code))
126123
}
127124

@@ -140,7 +137,6 @@ class UpdateFolderE2ETest : E2ETestBase() {
140137
.patch("/api/folders/$nonExistentFolderId")
141138
.then()
142139
.statusCode(HttpStatus.BAD_REQUEST.value())
143-
.body("success", equalTo(false))
144140
.body("resultCode", equalTo(ResultCode.NOT_FOUND.code))
145141
}
146142

@@ -179,7 +175,6 @@ class UpdateFolderE2ETest : E2ETestBase() {
179175
.patch("/api/folders/${response.data?.folderId}")
180176
.then()
181177
.statusCode(HttpStatus.BAD_REQUEST.value())
182-
.body("success", equalTo(false))
183178
.body("resultCode", equalTo(ResultCode.CONFLICT_FOLDER.code))
184179
}
185180

@@ -201,7 +196,6 @@ class UpdateFolderE2ETest : E2ETestBase() {
201196
.patch("/api/folders/${otherUserFolder.id}")
202197
.then()
203198
.statusCode(HttpStatus.BAD_REQUEST.value())
204-
.body("success", equalTo(false))
205199
.body("resultCode", equalTo(ResultCode.NOT_FOUND.code))
206200
}
207201

@@ -223,7 +217,6 @@ class UpdateFolderE2ETest : E2ETestBase() {
223217
.patch("/api/folders/${folder.id}")
224218
.then()
225219
.statusCode(HttpStatus.OK.value())
226-
.body("success", equalTo(true))
227220
.body("resultCode", equalTo(ResultCode.SUCCESS.code))
228221
}
229222
}

src/test/kotlin/com/yapp2app/e2e/photo/image/DeletePhotoE2ETest.kt

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@ class DeletePhotoE2ETest : PhotoImageE2ETestBase() {
5353
.delete("/api/photos/${photo.id}")
5454
.then()
5555
.statusCode(HttpStatus.OK.value())
56-
.body("success", equalTo(true))
5756
.body("resultCode", equalTo(ResultCode.SUCCESS.code))
5857
}
5958

@@ -70,7 +69,6 @@ class DeletePhotoE2ETest : PhotoImageE2ETestBase() {
7069
.delete("/api/photos/$nonExistentPhotoId")
7170
.then()
7271
.statusCode(HttpStatus.BAD_REQUEST.value())
73-
.body("success", equalTo(false))
7472
.body("resultCode", equalTo(ResultCode.NOT_FOUND.code))
7573
}
7674

@@ -89,7 +87,6 @@ class DeletePhotoE2ETest : PhotoImageE2ETestBase() {
8987
.delete("/api/photos/${otherUserPhoto.id}")
9088
.then()
9189
.statusCode(HttpStatus.BAD_REQUEST.value())
92-
.body("success", equalTo(false))
9390
.body("resultCode", equalTo(ResultCode.NOT_FOUND.code))
9491
}
9592

@@ -108,7 +105,6 @@ class DeletePhotoE2ETest : PhotoImageE2ETestBase() {
108105
.delete("/api/photos/${photo.id}")
109106
.then()
110107
.statusCode(HttpStatus.OK.value())
111-
.body("success", equalTo(true))
112108
.body("resultCode", equalTo(ResultCode.SUCCESS.code))
113109
}
114110
}

src/test/kotlin/com/yapp2app/e2e/photo/image/DeletePhotosE2ETest.kt

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,6 @@ class DeletePhotosE2ETest : PhotoImageE2ETestBase() {
6262
.delete("/api/photos")
6363
.then()
6464
.statusCode(HttpStatus.OK.value())
65-
.body("success", equalTo(true))
6665
.body("resultCode", equalTo(ResultCode.SUCCESS.code))
6766
}
6867

@@ -78,7 +77,6 @@ class DeletePhotosE2ETest : PhotoImageE2ETestBase() {
7877
.delete("/api/photos")
7978
.then()
8079
.statusCode(HttpStatus.BAD_REQUEST.value())
81-
.body("success", equalTo(false))
8280
.body("resultCode", equalTo(ResultCode.INVALID_PARAMETER.code))
8381
}
8482

@@ -101,7 +99,6 @@ class DeletePhotosE2ETest : PhotoImageE2ETestBase() {
10199
.delete("/api/photos")
102100
.then()
103101
.statusCode(HttpStatus.BAD_REQUEST.value())
104-
.body("success", equalTo(false))
105102
.body("resultCode", equalTo(ResultCode.INVALID_PARAMETER.code))
106103
}
107104

@@ -122,7 +119,6 @@ class DeletePhotosE2ETest : PhotoImageE2ETestBase() {
122119
.delete("/api/photos")
123120
.then()
124121
.statusCode(HttpStatus.OK.value())
125-
.body("success", equalTo(true))
126122
.body("resultCode", equalTo(ResultCode.SUCCESS.code))
127123
}
128124

@@ -147,7 +143,6 @@ class DeletePhotosE2ETest : PhotoImageE2ETestBase() {
147143
.delete("/api/photos")
148144
.then()
149145
.statusCode(HttpStatus.OK.value())
150-
.body("success", equalTo(true))
151146
.body("resultCode", equalTo(ResultCode.SUCCESS.code))
152147
}
153148

@@ -171,7 +166,6 @@ class DeletePhotosE2ETest : PhotoImageE2ETestBase() {
171166
.delete("/api/photos")
172167
.then()
173168
.statusCode(HttpStatus.OK.value())
174-
.body("success", equalTo(true))
175169
.body("resultCode", equalTo(ResultCode.SUCCESS.code))
176170
}
177171
}

src/test/kotlin/com/yapp2app/e2e/photo/image/GetPhotosE2ETest.kt

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,6 @@ class GetPhotosE2ETest : PhotoImageE2ETestBase() {
5757
.get("/api/photos")
5858
.then()
5959
.statusCode(HttpStatus.OK.value())
60-
.body("success", equalTo(true))
6160
.body("resultCode", equalTo(ResultCode.SUCCESS.code))
6261
.body("data.items", hasSize<Int>(2))
6362
}
@@ -83,7 +82,6 @@ class GetPhotosE2ETest : PhotoImageE2ETestBase() {
8382
.get("/api/photos")
8483
.then()
8584
.statusCode(HttpStatus.OK.value())
86-
.body("success", equalTo(true))
8785
.body("resultCode", equalTo(ResultCode.SUCCESS.code))
8886
.body("data.items", hasSize<Int>(2))
8987
}
@@ -104,7 +102,6 @@ class GetPhotosE2ETest : PhotoImageE2ETestBase() {
104102
.then()
105103
.log().all()
106104
.statusCode(HttpStatus.OK.value())
107-
.body("success", equalTo(true))
108105
.body("resultCode", equalTo(ResultCode.SUCCESS.code))
109106
.body("data.items", empty<Any>())
110107
}
@@ -124,7 +121,6 @@ class GetPhotosE2ETest : PhotoImageE2ETestBase() {
124121
.get("/api/photos")
125122
.then()
126123
.statusCode(HttpStatus.OK.value())
127-
.body("success", equalTo(true))
128124
.body("data.items", empty<Any>())
129125
}
130126

@@ -143,7 +139,6 @@ class GetPhotosE2ETest : PhotoImageE2ETestBase() {
143139
.get("/api/photos")
144140
.then()
145141
.statusCode(HttpStatus.OK.value())
146-
.body("success", equalTo(true))
147142
.body("data.items", empty<Any>())
148143
}
149144
}

src/test/kotlin/com/yapp2app/e2e/photo/image/UpdatePhotoE2ETest.kt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,6 @@ class UpdatePhotoE2ETest : PhotoImageE2ETestBase() {
5757
.patch("/api/photos/${photo.id}")
5858
.then()
5959
.statusCode(HttpStatus.OK.value())
60-
.body("success", equalTo(true))
6160
.body("resultCode", equalTo(ResultCode.SUCCESS.code))
6261
}
6362

@@ -77,7 +76,6 @@ class UpdatePhotoE2ETest : PhotoImageE2ETestBase() {
7776
.patch("/api/photos/${photo.id}")
7877
.then()
7978
.statusCode(HttpStatus.OK.value())
80-
.body("success", equalTo(true))
8179
.body("resultCode", equalTo(ResultCode.SUCCESS.code))
8280
}
8381

@@ -97,7 +95,6 @@ class UpdatePhotoE2ETest : PhotoImageE2ETestBase() {
9795
.patch("/api/photos/${photo.id}")
9896
.then()
9997
.statusCode(HttpStatus.OK.value())
100-
.body("success", equalTo(true))
10198
.body("resultCode", equalTo(ResultCode.SUCCESS.code))
10299
}
103100
}

0 commit comments

Comments
 (0)