refactor : Article 에 ImageKey 객체 도입

Author: leegwichan

src/main/java/eatda/domain/article/Article.java

@@ -1,12 +1,15 @@
 package eatda.domain.article;
 
 import eatda.domain.AuditingEntity;
+import eatda.domain.ImageKey;
 import jakarta.persistence.Column;
+import jakarta.persistence.Embedded;
 import jakarta.persistence.Entity;
 import jakarta.persistence.GeneratedValue;
 import jakarta.persistence.GenerationType;
 import jakarta.persistence.Id;
 import jakarta.persistence.Table;
+import jakarta.validation.constraints.NotNull;
 import lombok.AccessLevel;
 import lombok.Getter;
 import lombok.NoArgsConstructor;
@@ -30,10 +33,11 @@ public class Article extends AuditingEntity {
     @Column(name = "article_url", nullable = false, length = 511)
     private String articleUrl;
 
-    @Column(name = "image_key", nullable = false, length = 511)
-    private String imageKey;
+    @NotNull
+    @Embedded
+    private ImageKey imageKey;
 
-    public Article(String title, String subtitle, String articleUrl, String imageKey) {
+    public Article(String title, String subtitle, String articleUrl, ImageKey imageKey) {
         this.title = title;
         this.subtitle = subtitle;
         this.articleUrl = articleUrl;

src/main/java/eatda/domain/story/Story.java

@@ -18,6 +18,7 @@
 import jakarta.persistence.JoinColumn;
 import jakarta.persistence.ManyToOne;
 import jakarta.persistence.Table;
+import jakarta.validation.constraints.NotNull;
 import lombok.AccessLevel;
 import lombok.Builder;
 import lombok.Getter;
@@ -56,6 +57,7 @@ public class Story extends AuditingEntity {
     @Column(name = "description", nullable = false)
     private String description;
 
+    @NotNull
     @Embedded
     private ImageKey imageKey;
 

src/main/java/eatda/service/article/ArticleService.java

@@ -2,8 +2,6 @@
 
 import eatda.controller.article.ArticleResponse;
 import eatda.controller.article.ArticlesResponse;
-import eatda.domain.Image;
-import eatda.domain.ImageKey;
 import eatda.repository.article.ArticleRepository;
 import eatda.storage.image.ImageStorage;
 import java.util.List;
@@ -26,7 +24,7 @@ public ArticlesResponse getAllArticles(int size) {
                         article.getTitle(),
                         article.getSubtitle(),
                         article.getArticleUrl(),
-                        imageStorage.getPreSignedUrl(new ImageKey(article.getImageKey()))
+                        imageStorage.getPreSignedUrl(article.getImageKey())
                 ))
                 .toList();
 

src/test/java/eatda/fixture/ArticleGenerator.java

@@ -1,6 +1,6 @@
 package eatda.fixture;
 
-import eatda.controller.article.ArticleResponse;
+import eatda.domain.ImageKey;
 import eatda.domain.article.Article;
 import eatda.repository.article.ArticleRepository;
 import org.springframework.stereotype.Component;
@@ -36,16 +36,7 @@ public Article generate(String title, String subtitle, String articleUrl) {
     }
 
     public Article generate(String title, String subtitle, String articleUrl, String imageKey) {
-        Article article = new Article(title, subtitle, articleUrl, imageKey);
+        Article article = new Article(title, subtitle, articleUrl, new ImageKey(imageKey));
         return articleRepository.save(article);
     }
-
-    public ArticleResponse toResponse(Article article) {
-        return new ArticleResponse(
-                article.getTitle(),
-                article.getSubtitle(),
-                article.getArticleUrl(),
-                "https://s3.bucket.com/" + article.getImageKey()
-        );
-    }
 }