feat: 응원 등록 서비스 로직 개선

Author: leegwichan

src/main/java/eatda/controller/cheer/CheerResponse.java

@@ -1,7 +1,6 @@
 package eatda.controller.cheer;
 
 import eatda.domain.cheer.Cheer;
-import eatda.domain.cheer.CheerTag;
 import eatda.domain.cheer.CheerTagName;
 import eatda.domain.store.Store;
 import java.util.List;
@@ -14,19 +13,13 @@ public record CheerResponse(
         List<CheerTagName> tags
 ) {
 
-    public CheerResponse(Cheer cheer, List<CheerTag> cheerTags, Store store, String imageUrl) {
+    public CheerResponse(Cheer cheer, Store store, String imageUrl) {
         this(
                 store.getId(),
                 cheer.getId(),
                 imageUrl,
                 cheer.getDescription(),
-                toTagNames(cheerTags)
+                cheer.getCheerTagNames()
         );
     }
-
-    private static List<CheerTagName> toTagNames(List<CheerTag> cheerTags) {
-        return cheerTags.stream()
-                .map(CheerTag::getName)
-                .toList();
-    }
 }

src/main/java/eatda/domain/cheer/CheerTagNames.java

@@ -8,8 +8,6 @@
 import eatda.controller.cheer.CheersResponse;
 import eatda.domain.ImageKey;
 import eatda.domain.cheer.Cheer;
-import eatda.domain.cheer.CheerTag;
-import eatda.domain.cheer.CheerTagNames;
 import eatda.domain.member.Member;
 import eatda.domain.store.Store;
 import eatda.domain.store.StoreSearchResult;
@@ -43,15 +41,15 @@ public CheerResponse registerCheer(CheerRegisterRequest request,
                                        StoreSearchResult result,
                                        ImageKey imageKey,
                                        long memberId) {
-        CheerTagNames cheerTagNames = new CheerTagNames(request.tags());
         Member member = memberRepository.getById(memberId);
         validateRegisterCheer(member, request.storeKakaoId());
 
         Store store = storeRepository.findByKakaoId(result.kakaoId())
                 .orElseGet(() -> storeRepository.save(result.toStore())); // TODO 상점 조회/저장 동시성 이슈 해결
-        Cheer cheer = cheerRepository.save(new Cheer(member, store, request.description(), imageKey));
-        List<CheerTag> cheerTags = cheerTagRepository.saveAll(cheerTagNames.toCheerTags(cheer));
-        return new CheerResponse(cheer, cheerTags, store, imageStorage.getPreSignedUrl(imageKey));
+        Cheer cheer = new Cheer(member, store, request.description(), imageKey);
+        cheer.setCheerTags(request.tags());
+        Cheer savedCheer = cheerRepository.save(cheer);
+        return new CheerResponse(savedCheer, store, imageStorage.getPreSignedUrl(imageKey));
     }
 
     private void validateRegisterCheer(Member member, String storeKakaoId) {

src/main/java/eatda/service/cheer/CheerService.java

@@ -145,6 +145,27 @@ class RegisterCheer {
                             CheerTagName.GOOD_FOR_DATING, CheerTagName.CLEAN_RESTROOM)
             );
         }
+
+        @Test
+        void 해당_응원의_응원_태그가_비어있어도_응원을_저장할_수_있다() {
+            Member member = memberGenerator.generate("123");
+
+            CheerRegisterRequest request = new CheerRegisterRequest("123", "농민백암순대 본점", "맛있어요!", List.of());
+            StoreSearchResult result = new StoreSearchResult(
+                    "123", StoreCategory.KOREAN, "02-755-5232", "농민백암순대 본점", "http://place.map.kakao.com/123",
+                    "서울시 강남구 역삼동 123-45", "서울시 강남구 역삼동 123-45", District.GANGNAM, 37.5665, 126.9780);
+            ImageKey imageKey = new ImageKey("image-key");
+
+            CheerResponse response = cheerService.registerCheer(request, result, imageKey, member.getId());
+
+            Store foundStore = storeRepository.findByKakaoId("123").orElseThrow();
+            assertAll(
+                    () -> assertThat(response.storeId()).isEqualTo(foundStore.getId()),
+                    () -> assertThat(response.cheerDescription()).isEqualTo("맛있어요!"),
+                    () -> assertThat(response.imageUrl()).isNotBlank(),
+                    () -> assertThat(response.tags()).isEmpty()
+            );
+        }
     }
 
     @Nested