refactor: StoreSearchFilter 에서 필터링 된 객체를 반환하도록 변경

- 필터링이 되었다는 의미로 StoreSearchResult 를 반환

Author: leegwichan

src/main/java/eatda/domain/store/StoreSearchFilter.java

@@ -9,17 +9,19 @@
 @Component
 public class StoreSearchFilter {
 
-    public List<MapClientStoreSearchResult> filterSearchedStores(List<MapClientStoreSearchResult> searchResults) {
+    public List<StoreSearchResult> filterSearchedStores(List<MapClientStoreSearchResult> searchResults) {
         return searchResults.stream()
                 .filter(this::isValidStore)
+                .map(MapClientStoreSearchResult::toDomain)
                 .toList();
     }
 
-    public MapClientStoreSearchResult filterStoreByKakaoId(List<MapClientStoreSearchResult> searchResults, String kakaoId) {
+    public StoreSearchResult filterStoreByKakaoId(List<MapClientStoreSearchResult> searchResults, String kakaoId) {
         return searchResults.stream()
                 .filter(store -> store.kakaoId().equals(kakaoId))
                 .filter(this::isValidStore)
                 .findFirst()
+                .map(MapClientStoreSearchResult::toDomain)
                 .orElseThrow(() -> new BusinessException(BusinessErrorCode.STORE_NOT_FOUND));
     }
 

src/main/java/eatda/service/store/StoreSearchService.java

@@ -17,15 +17,11 @@ public class StoreSearchService {
 
     public StoreSearchResult searchStoreByKakaoId(String name, String kakaoId) {
         List<MapClientStoreSearchResult> searchResults = mapClient.searchStores(name);
-        return storeSearchFilter.filterStoreByKakaoId(searchResults, kakaoId)
-                .toDomain();
+        return storeSearchFilter.filterStoreByKakaoId(searchResults, kakaoId);
     }
 
     public List<StoreSearchResult> searchStores(String name) {
         List<MapClientStoreSearchResult> searchResults = mapClient.searchStores(name);
-        return storeSearchFilter.filterSearchedStores(searchResults)
-                .stream()
-                .map(MapClientStoreSearchResult::toDomain)
-                .toList();
+        return storeSearchFilter.filterSearchedStores(searchResults);
     }
 }

src/test/java/eatda/domain/store/StoreSearchFilterTest.java

@@ -1,8 +1,12 @@
 package eatda.domain.store;
 
 import static org.assertj.core.api.Assertions.assertThat;
+import static org.junit.jupiter.api.Assertions.assertAll;
+import static org.junit.jupiter.api.Assertions.assertThrows;
 
 import eatda.client.map.MapClientStoreSearchResult;
+import eatda.exception.BusinessErrorCode;
+import eatda.exception.BusinessException;
 import java.util.List;
 import org.junit.jupiter.api.Nested;
 import org.junit.jupiter.api.Test;
@@ -16,7 +20,7 @@ class FilterSearchedStores {
 
         @Test
         void 빈_검색_결과를_넣으면_빈_리스트를_반환한다() {
-            List<MapClientStoreSearchResult> actual = storeSearchFilter.filterSearchedStores(List.of());
+            List<StoreSearchResult> actual = storeSearchFilter.filterSearchedStores(List.of());
 
             assertThat(actual).isEmpty();
         }
@@ -29,14 +33,48 @@ class FilterSearchedStores {
             MapClientStoreSearchResult store4 = createStore("4", "부산음식점", "FD6", "부산 연제구 연산동 632-8");
 
             List<MapClientStoreSearchResult> searchResults = List.of(store1, store2, store3, store4);
-            List<MapClientStoreSearchResult> actual = storeSearchFilter.filterSearchedStores(searchResults);
+            List<StoreSearchResult> actual = storeSearchFilter.filterSearchedStores(searchResults);
 
-            assertThat(actual).containsExactly(store1, store3);
+            assertThat(actual).extracting(StoreSearchResult::kakaoId)
+                    .containsExactlyInAnyOrder("1", "3");
         }
 
-        private MapClientStoreSearchResult createStore(String id, String name, String categoryGroupCode, String location) {
-            return new MapClientStoreSearchResult(id, categoryGroupCode, "음식점 > 식당", "010-1234-1234", name, "https://yapp.co.kr",
-                    location, null, 37.0d, 128.0d);
+    }
+
+    @Nested
+    class FilterStoreByKakaoId {
+
+        @Test
+        void 음식점_카카오_ID로_검색_결과를_반환한다() {
+            MapClientStoreSearchResult store1 = createStore("1", "서울음식점1", "FD6", "서울 강남구 대치동 896-33");
+            MapClientStoreSearchResult store2 = createStore("2", "서울음식점2", "FD6", "서울 강남구 대치동 896-33");
+
+            List<MapClientStoreSearchResult> searchResults = List.of(store1, store2);
+            StoreSearchResult actual = storeSearchFilter.filterStoreByKakaoId(searchResults, "1");
+
+            assertAll(
+                    () -> assertThat(actual.kakaoId()).isEqualTo("1"),
+                    () -> assertThat(actual.name()).isEqualTo("서울음식점1"),
+                    () -> assertThat(actual.lotNumberAddress()).isEqualTo("서울 강남구 대치동 896-33")
+
+            );
+        }
+
+        @Test
+        void 존재하지_않는_카카오_ID로_검색하면_예외를_던진다() {
+            MapClientStoreSearchResult store = createStore("1", "서울음식점1", "FD6", "서울 강남구 대치동 896-33");
+            List<MapClientStoreSearchResult> searchResults = List.of(store);
+
+            BusinessException exception = assertThrows(BusinessException.class,
+                    () -> storeSearchFilter.filterStoreByKakaoId(searchResults, "999"));
+
+            assertThat(exception.getErrorCode()).isEqualTo(BusinessErrorCode.STORE_NOT_FOUND);
         }
     }
+
+    private MapClientStoreSearchResult createStore(String id, String name, String categoryGroupCode,
+                                                   String location) {
+        return new MapClientStoreSearchResult(id, categoryGroupCode, "음식점 > 식당", "010-1234-1234", name,
+                "https://yapp.co.kr", location, null, 37.0d, 128.0d);
+    }
 }