[Test] 생성 시각에 의한 테스트 개선

leegwichan · web-flow · commit f0628175891e · 2025-07-28T20:28:55.000+09:00
diff --git a/src/main/java/eatda/domain/AuditingEntity.java b/src/main/java/eatda/domain/AuditingEntity.java
@@ -15,6 +15,8 @@ public abstract class AuditingEntity {
 
     @PrePersist
     protected void onCreate() {
-        this.createdAt = LocalDateTime.now();
+        if (createdAt == null) {
+            this.createdAt = LocalDateTime.now();
+        }
     }
 }
diff --git a/src/test/java/eatda/controller/article/ArticleControllerTest.java b/src/test/java/eatda/controller/article/ArticleControllerTest.java
@@ -3,7 +3,7 @@
 import static org.assertj.core.api.Assertions.assertThat;
 
 import eatda.controller.BaseControllerTest;
-import eatda.domain.article.Article;
+import java.time.LocalDateTime;
 import org.junit.jupiter.api.Nested;
 import org.junit.jupiter.api.Test;
 
@@ -14,8 +14,9 @@ class GetArticles {
 
         @Test
         void 가게의_담긴_이야기_목록을_조회할_수_있다() {
-            Article article1 = articleGenerator.generate("국밥의 모든 것");
-            Article article2 = articleGenerator.generate("순대국의 진실");
+            LocalDateTime startAt = LocalDateTime.of(2023, 10, 1, 0, 0);
+            articleGenerator.generate("국밥의 모든 것", startAt);
+            articleGenerator.generate("순대국의 진실", startAt.plusHours(1));
 
             ArticlesResponse response = given()
                     .queryParam("size", 3)
diff --git a/src/test/java/eatda/controller/store/CheerControllerTest.java b/src/test/java/eatda/controller/store/CheerControllerTest.java
@@ -9,6 +9,7 @@
 import eatda.domain.store.Store;
 import eatda.util.ImageUtils;
 import eatda.util.MappingUtils;
+import java.time.LocalDateTime;
 import org.junit.jupiter.api.Nested;
 import org.junit.jupiter.api.Test;
 import org.springframework.http.HttpHeaders;
@@ -64,9 +65,10 @@ class GetCheers {
             Member member = memberGenerator.generateRegisteredMember("nickname", "ac@kakao.com", "123", "01011111111");
             Store store1 = storeGenerator.generate("111", "서울시 노원구 월계3동 123-45");
             Store store2 = storeGenerator.generate("222", "서울시 성북구 석관동 123-45");
-            Cheer cheer1 = cheerGenerator.generateAdmin(member, store1);
-            Cheer cheer2 = cheerGenerator.generateAdmin(member, store1);
-            Cheer cheer3 = cheerGenerator.generateAdmin(member, store2);
+            LocalDateTime startAt = LocalDateTime.of(2025, 7, 26, 1, 0, 0);
+            Cheer cheer1 = cheerGenerator.generateAdmin(member, store1, startAt);
+            Cheer cheer2 = cheerGenerator.generateAdmin(member, store1, startAt.plusHours(1));
+            Cheer cheer3 = cheerGenerator.generateAdmin(member, store2, startAt.plusHours(2));
 
             CheersResponse response = given()
                     .when()
diff --git a/src/test/java/eatda/controller/store/StoreControllerTest.java b/src/test/java/eatda/controller/store/StoreControllerTest.java
@@ -6,6 +6,7 @@
 import eatda.controller.BaseControllerTest;
 import eatda.domain.member.Member;
 import eatda.domain.store.Store;
+import java.time.LocalDateTime;
 import org.junit.jupiter.api.Nested;
 import org.junit.jupiter.api.Test;
 import org.springframework.http.HttpHeaders;
@@ -44,9 +45,10 @@ class GetStores {
         @Test
         void 음식점_목록을_최신순으로_조회한다() {
             Member member = memberGenerator.generate("111");
-            Store store1 = storeGenerator.generate("111", "서울 강남구 대치동 896-33");
-            Store store2 = storeGenerator.generate("222", "서울 강남구 대치동 896-34");
-            Store store3 = storeGenerator.generate("333", "서울 강남구 대치동 896-35");
+            LocalDateTime startAt = LocalDateTime.of(2025, 7, 26, 1, 0, 0);
+            Store store1 = storeGenerator.generate("111", "서울 강남구 대치동 896-33", startAt);
+            Store store2 = storeGenerator.generate("222", "서울 강남구 대치동 896-34", startAt.plusHours(1));
+            Store store3 = storeGenerator.generate("333", "서울 강남구 대치동 896-35", startAt.plusHours(2));
             cheerGenerator.generateCommon(member, store1, "image-key-1");
             cheerGenerator.generateCommon(member, store2, "image-key-2");
             cheerGenerator.generateCommon(member, store3, "image-key-3");
diff --git a/src/test/java/eatda/fixture/ArticleGenerator.java b/src/test/java/eatda/fixture/ArticleGenerator.java
@@ -3,6 +3,8 @@
 import eatda.domain.ImageKey;
 import eatda.domain.article.Article;
 import eatda.repository.article.ArticleRepository;
+import eatda.util.DomainUtils;
+import java.time.LocalDateTime;
 import org.springframework.stereotype.Component;
 
 @Component
@@ -27,6 +29,12 @@ public Article generate(String title) {
         return generate(title, DEFAULT_SUBTITLE);
     }
 
+    public Article generate(String title, LocalDateTime createdAt) {
+        Article article = generate(title, DEFAULT_SUBTITLE);
+        DomainUtils.setCreatedAt(article, createdAt);
+        return articleRepository.save(article);
+    }
+
     public Article generate(String title, String subtitle) {
         return generate(title, subtitle, DEFAULT_URL);
     }
diff --git a/src/test/java/eatda/fixture/CheerGenerator.java b/src/test/java/eatda/fixture/CheerGenerator.java
@@ -5,6 +5,8 @@
 import eatda.domain.store.Cheer;
 import eatda.domain.store.Store;
 import eatda.repository.store.CheerRepository;
+import eatda.util.DomainUtils;
+import java.time.LocalDateTime;
 import org.springframework.stereotype.Component;
 
 @Component
@@ -19,8 +21,9 @@ public CheerGenerator(CheerRepository cheerRepository) {
         this.cheerRepository = cheerRepository;
     }
 
-    public Cheer generateAdmin(Member member, Store store) {
+    public Cheer generateAdmin(Member member, Store store, LocalDateTime createdAt) {
         Cheer cheer = new Cheer(member, store, DEFAULT_DESCRIPTION, new ImageKey(DEFAULT_IMAGE_KEY), true);
+        DomainUtils.setCreatedAt(cheer, createdAt);
         return cheerRepository.save(cheer);
     }
 
diff --git a/src/test/java/eatda/fixture/StoreGenerator.java b/src/test/java/eatda/fixture/StoreGenerator.java
@@ -3,6 +3,8 @@
 import eatda.domain.store.Store;
 import eatda.domain.store.StoreCategory;
 import eatda.repository.store.StoreRepository;
+import eatda.util.DomainUtils;
+import java.time.LocalDateTime;
 import org.springframework.stereotype.Component;
 
 @Component
@@ -37,4 +39,10 @@ public Store generate(String kakaoId, String lotNumberAddress) {
                 .build();
         return storeRepository.save(store);
     }
+
+    public Store generate(String kakaoId, String lotNumberAddress, LocalDateTime createdAt) {
+        Store store = generate(kakaoId, lotNumberAddress);
+        DomainUtils.setCreatedAt(store, createdAt);
+        return storeRepository.save(store);
+    }
 }
diff --git a/src/test/java/eatda/service/article/ArticleServiceTest.java b/src/test/java/eatda/service/article/ArticleServiceTest.java
@@ -4,7 +4,7 @@
 
 import eatda.controller.article.ArticleResponse;
 import eatda.service.BaseServiceTest;
-import java.util.stream.LongStream;
+import java.time.LocalDateTime;
 import org.junit.jupiter.api.Nested;
 import org.junit.jupiter.api.Test;
 import org.springframework.beans.factory.annotation.Autowired;
@@ -19,8 +19,12 @@ class GetAllArticles {
 
         @Test
         void 가게의_담긴_이야기를_최신순으로_조회할_수_있다() {
-            LongStream.rangeClosed(1, 5)
-                    .forEach(i -> articleGenerator.generate("아티클 제목 " + i));
+            LocalDateTime startAt = LocalDateTime.of(2025, 7, 26, 12, 0, 0);
+            articleGenerator.generate("아티클 제목 1", startAt);
+            articleGenerator.generate("아티클 제목 2", startAt.plusHours(1));
+            articleGenerator.generate("아티클 제목 3", startAt.plusHours(2));
+            articleGenerator.generate("아티클 제목 4", startAt.plusHours(3));
+            articleGenerator.generate("아티클 제목 5", startAt.plusHours(4));
 
             var response = articleService.getAllArticles(3);
 
diff --git a/src/test/java/eatda/service/store/CheerServiceTest.java b/src/test/java/eatda/service/store/CheerServiceTest.java
@@ -17,6 +17,7 @@
 import eatda.exception.BusinessErrorCode;
 import eatda.exception.BusinessException;
 import eatda.service.BaseServiceTest;
+import java.time.LocalDateTime;
 import java.util.List;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Nested;
@@ -135,9 +136,10 @@ class GetCheers {
             Member member = memberGenerator.generate("123");
             Store store1 = storeGenerator.generate("123", "서울시 강남구 역삼동 123-45");
             Store store2 = storeGenerator.generate("456", "서울시 성북구 석관동 123-45");
-            Cheer cheer1 = cheerGenerator.generateAdmin(member, store1);
-            Cheer cheer2 = cheerGenerator.generateAdmin(member, store1);
-            Cheer cheer3 = cheerGenerator.generateAdmin(member, store2);
+            LocalDateTime startAt = LocalDateTime.of(2025, 7, 26, 1, 0, 0);
+            Cheer cheer1 = cheerGenerator.generateAdmin(member, store1, startAt);
+            Cheer cheer2 = cheerGenerator.generateAdmin(member, store1, startAt.plusHours(1));
+            Cheer cheer3 = cheerGenerator.generateAdmin(member, store2, startAt.plusHours(2));
 
             CheersResponse response = cheerService.getCheers(2);
 
diff --git a/src/test/java/eatda/service/store/StoreServiceTest.java b/src/test/java/eatda/service/store/StoreServiceTest.java
@@ -14,6 +14,7 @@
 import eatda.exception.BusinessErrorCode;
 import eatda.exception.BusinessException;
 import eatda.service.BaseServiceTest;
+import java.time.LocalDateTime;
 import java.util.List;
 import org.junit.jupiter.api.Nested;
 import org.junit.jupiter.api.Test;
@@ -60,11 +61,12 @@ class GetStores {
         @Test
         void 음식점_목록을_최신순으로_조회한다() {
             Member member = memberGenerator.generate("111");
-            Store store1 = storeGenerator.generate("농민백암순대", "서울 강남구 대치동 896-33");
+            LocalDateTime startAt = LocalDateTime.of(2025, 7, 26, 1, 0, 0);
+            Store store1 = storeGenerator.generate("농민백암순대", "서울 강남구 대치동 896-33", startAt);
+            Store store2 = storeGenerator.generate("석관동떡볶이", "서울 성북구 석관동 123-45", startAt.plusHours(1));
+            Store store3 = storeGenerator.generate("강남순대국", "서울 강남구 역삼동 678-90", startAt.plusHours(2));
             cheerGenerator.generateCommon(member, store1, "image-key-1");
-            Store store2 = storeGenerator.generate("석관동떡볶이", "서울 성북구 석관동 123-45");
             cheerGenerator.generateCommon(member, store2, "image-key-2");
-            Store store3 = storeGenerator.generate("강남순대국", "서울 강남구 역삼동 678-90");
             cheerGenerator.generateCommon(member, store3, "image-key-3");
 
             int size = 2;
diff --git a/src/test/java/eatda/util/DomainUtils.java b/src/test/java/eatda/util/DomainUtils.java
@@ -0,0 +1,21 @@
+package eatda.util;
+
+import eatda.domain.AuditingEntity;
+import java.time.LocalDateTime;
+import org.springframework.test.util.ReflectionTestUtils;
+
+public final class DomainUtils {
+
+    private static final String CREATED_AT_FIELD = "createdAt";
+
+    private DomainUtils() {
+    }
+
+    public static <T extends AuditingEntity> void setCreatedAt(T entity, LocalDateTime createdAt) {
+        try {
+            ReflectionTestUtils.setField(entity, CREATED_AT_FIELD, createdAt);
+        } catch (Exception e) {
+            throw new IllegalArgumentException("Failed to set createdAt field", e);
+        }
+    }
+}

Original file line number	Diff line number	Diff line change
`@@ -15,6 +15,8 @@ public abstract class AuditingEntity {`
`15`	`15`
`16`	`16`	`@PrePersist`
`17`	`17`	`protected void onCreate() {`
`18`		`- this.createdAt = LocalDateTime.now();`
	`18`	`+ if (createdAt == null) {`
	`19`	`+ this.createdAt = LocalDateTime.now();`
	`20`	`+ }`
`19`	`21`	`}`
`20`	`22`	`}`