[Refactor] Presigned URL 캐싱

leegwichan · web-flow · commit fcd83b2feb2b · 2025-07-23T12:20:28.000+09:00
diff --git a/build.gradle b/build.gradle
@@ -57,6 +57,7 @@ dependencies {
     implementation 'org.springframework.boot:spring-boot-starter-data-jpa'
     implementation 'org.springframework.boot:spring-boot-starter-web'
     implementation 'org.springframework.boot:spring-boot-starter-validation'
+    implementation 'org.springframework.boot:spring-boot-starter-cache'
 
     // Lombok
     compileOnly 'org.projectlombok:lombok'
@@ -67,6 +68,7 @@ dependencies {
     runtimeOnly 'com.mysql:mysql-connector-j'
     implementation 'org.flywaydb:flyway-core'
     implementation 'org.flywaydb:flyway-mysql'
+    implementation 'com.github.ben-manes.caffeine:caffeine' // in-memory cache
 
     // JWT
     implementation 'io.jsonwebtoken:jjwt-api:0.11.5'
diff --git a/src/main/java/eatda/config/CacheConfig.java b/src/main/java/eatda/config/CacheConfig.java
@@ -0,0 +1,36 @@
+package eatda.config;
+
+import com.github.benmanes.caffeine.cache.Caffeine;
+import eatda.repository.CacheSetting;
+import java.util.Arrays;
+import java.util.List;
+import org.springframework.cache.CacheManager;
+import org.springframework.cache.caffeine.CaffeineCache;
+import org.springframework.cache.support.SimpleCacheManager;
+import org.springframework.context.annotation.Bean;
+import org.springframework.context.annotation.Configuration;
+
+@Configuration
+public class CacheConfig {
+
+    @Bean
+    public CacheManager cacheManager() {
+        List<CaffeineCache> caches = Arrays.stream(CacheSetting.values())
+                .map(this::createCaffeineCache)
+                .toList();
+
+        SimpleCacheManager cacheManager = new SimpleCacheManager();
+        cacheManager.setCaches(caches);
+        cacheManager.afterPropertiesSet();
+        return cacheManager;
+    }
+
+    private CaffeineCache createCaffeineCache(CacheSetting cacheSetting) {
+        return new CaffeineCache(
+                cacheSetting.getName(),
+                Caffeine.newBuilder()
+                        .expireAfterWrite(cacheSetting.getTimeToLive())
+                        .maximumSize(cacheSetting.getMaximumSize())
+                        .build());
+    }
+}
diff --git a/src/main/java/eatda/domain/ImageDomain.java b/src/main/java/eatda/domain/ImageDomain.java
@@ -1,4 +1,4 @@
-package eatda.service.common;
+package eatda.domain;
 
 import lombok.Getter;
 import lombok.RequiredArgsConstructor;
diff --git a/src/main/java/eatda/repository/CacheSetting.java b/src/main/java/eatda/repository/CacheSetting.java
@@ -0,0 +1,21 @@
+package eatda.repository;
+
+import java.time.Duration;
+import lombok.Getter;
+
+@Getter
+public enum CacheSetting {
+
+    IMAGE("image", Duration.ofMinutes(25), 1_000),
+    ;
+
+    private final String name;
+    private final Duration timeToLive;
+    private final int maximumSize;
+
+    CacheSetting(String image, Duration timeToLive, int maximumSize) {
+        this.name = image;
+        this.timeToLive = timeToLive;
+        this.maximumSize = maximumSize;
+    }
+}
diff --git a/src/main/java/eatda/service/article/ArticleService.java b/src/main/java/eatda/service/article/ArticleService.java
@@ -3,7 +3,7 @@
 import eatda.controller.article.ArticleResponse;
 import eatda.controller.article.ArticlesResponse;
 import eatda.repository.article.ArticleRepository;
-import eatda.service.common.ImageService;
+import eatda.storage.image.ImageStorage;
 import java.util.List;
 import lombok.RequiredArgsConstructor;
 import org.springframework.data.domain.PageRequest;
@@ -14,7 +14,7 @@
 public class ArticleService {
 
     private final ArticleRepository articleRepository;
-    private final ImageService imageService;
+    private final ImageStorage imageStorage;
 
     public ArticlesResponse getAllArticles(int size) {
         PageRequest pageRequest = PageRequest.of(0, size);
@@ -24,7 +24,7 @@ public ArticlesResponse getAllArticles(int size) {
                         article.getTitle(),
                         article.getSubtitle(),
                         article.getArticleUrl(),
-                        imageService.getPresignedUrl(article.getImageKey())
+                        imageStorage.getPresignedUrl(article.getImageKey())
                 ))
                 .toList();
 
diff --git a/src/main/java/eatda/service/store/CheerService.java b/src/main/java/eatda/service/store/CheerService.java
@@ -6,6 +6,7 @@
 import eatda.controller.store.CheerRegisterRequest;
 import eatda.controller.store.CheerResponse;
 import eatda.controller.store.CheersResponse;
+import eatda.domain.ImageDomain;
 import eatda.domain.member.Member;
 import eatda.domain.store.Cheer;
 import eatda.domain.store.Store;
@@ -14,8 +15,7 @@
 import eatda.repository.member.MemberRepository;
 import eatda.repository.store.CheerRepository;
 import eatda.repository.store.StoreRepository;
-import eatda.service.common.ImageDomain;
-import eatda.service.common.ImageService;
+import eatda.storage.image.ImageStorage;
 import java.util.List;
 import lombok.RequiredArgsConstructor;
 import org.springframework.data.domain.Pageable;
@@ -34,7 +34,7 @@ public class CheerService {
     private final MemberRepository memberRepository;
     private final StoreRepository storeRepository;
     private final CheerRepository cheerRepository;
-    private final ImageService imageService;
+    private final ImageStorage imageStorage;
 
     @Transactional
     public CheerResponse registerCheer(CheerRegisterRequest request, MultipartFile image, long memberId) {
@@ -43,12 +43,12 @@ public CheerResponse registerCheer(CheerRegisterRequest request, MultipartFile i
 
         List<StoreSearchResult> searchResults = mapClient.searchShops(request.storeName());
         StoreSearchResult result = storeSearchFilter.filterStoreByKakaoId(searchResults, request.storeKakaoId());
-        String imageKey = imageService.upload(image, ImageDomain.CHEER);
+        String imageKey = imageStorage.upload(image, ImageDomain.CHEER);
 
         Store store = storeRepository.findByKakaoId(result.kakaoId())
                 .orElseGet(() -> storeRepository.save(result.toStore())); // TODO 상점 조회/저장 동시성 이슈 해결
         Cheer cheer = cheerRepository.save(new Cheer(member, store, request.description(), imageKey));
-        return new CheerResponse(cheer, imageService.getPresignedUrl(imageKey), store);
+        return new CheerResponse(cheer, imageStorage.getPresignedUrl(imageKey), store);
     }
 
     private void validateRegisterCheer(Member member, String storeKakaoId) {
@@ -69,7 +69,7 @@ public CheersResponse getCheers(int size) {
     private CheersResponse toCheersResponse(List<Cheer> cheers) {
         return new CheersResponse(cheers.stream()
                 .map(cheer -> new CheerPreviewResponse(cheer, cheer.getStore(),
-                        imageService.getPresignedUrl(cheer.getImageKey())))
+                        imageStorage.getPresignedUrl(cheer.getImageKey())))
                 .toList());
     }
 }
diff --git a/src/main/java/eatda/service/store/StoreService.java b/src/main/java/eatda/service/store/StoreService.java
@@ -11,7 +11,7 @@
 import eatda.domain.store.Store;
 import eatda.repository.store.CheerRepository;
 import eatda.repository.store.StoreRepository;
-import eatda.service.common.ImageService;
+import eatda.storage.image.ImageStorage;
 import java.util.List;
 import java.util.Optional;
 import lombok.RequiredArgsConstructor;
@@ -26,7 +26,7 @@ public class StoreService {
     private final StoreSearchFilter storeSearchFilter;
     private final StoreRepository storeRepository;
     private final CheerRepository cheerRepository;
-    private final ImageService imageService;
+    private final ImageStorage imageStorage;
 
     // TODO : N+1 문제 해결
     public StoresResponse getStores(int size) {
@@ -38,7 +38,7 @@ public StoresResponse getStores(int size) {
 
     private Optional<String> getStoreImageUrl(Store store) {
         return cheerRepository.findRecentImageKey(store)
-                .map(imageService::getPresignedUrl);
+                .map(imageStorage::getPresignedUrl);
     }
 
     public StoreSearchResponses searchStores(String query) {
diff --git a/src/main/java/eatda/service/story/StoryService.java b/src/main/java/eatda/service/story/StoryService.java
@@ -7,14 +7,14 @@
 import eatda.controller.story.StoryRegisterRequest;
 import eatda.controller.story.StoryRegisterResponse;
 import eatda.controller.story.StoryResponse;
+import eatda.domain.ImageDomain;
 import eatda.domain.member.Member;
 import eatda.domain.story.Story;
 import eatda.exception.BusinessErrorCode;
 import eatda.exception.BusinessException;
 import eatda.repository.member.MemberRepository;
 import eatda.repository.story.StoryRepository;
-import eatda.service.common.ImageDomain;
-import eatda.service.common.ImageService;
+import eatda.storage.image.ImageStorage;
 import java.util.List;
 import lombok.RequiredArgsConstructor;
 import org.springframework.data.domain.Page;
@@ -27,10 +27,11 @@
 @Service
 @RequiredArgsConstructor
 public class StoryService {
+
     private static final int PAGE_START_NUMBER = 0;
 
+    private final ImageStorage imageStorage;
     private final MapClient mapClient;
-    private final ImageService imageService;
     private final StoryRepository storyRepository;
     private final MemberRepository memberRepository;
 
@@ -39,7 +40,7 @@ public StoryRegisterResponse registerStory(StoryRegisterRequest request, Multipa
         Member member = memberRepository.getById(memberId);
         List<StoreSearchResult> searchResponses = mapClient.searchShops(request.query());
         FilteredSearchResult matchedStore = filteredSearchResponse(searchResponses, request.storeKakaoId());
-        String imageKey = imageService.upload(image, ImageDomain.STORY);
+        String imageKey = imageStorage.upload(image, ImageDomain.STORY);
 
         Story story = Story.builder()
                 .member(member)
@@ -80,7 +81,7 @@ public StoriesResponse getPagedStoryPreviews(int size) {
                 orderByPage.getContent().stream()
                         .map(story -> new StoriesResponse.StoryPreview(
                                 story.getId(),
-                                imageService.getPresignedUrl(story.getImageKey())
+                                imageStorage.getPresignedUrl(story.getImageKey())
                         ))
                         .toList()
         );
@@ -98,7 +99,7 @@ public StoryResponse getStory(long storyId) {
                 story.getAddressDistrict(),
                 story.getAddressNeighborhood(),
                 story.getDescription(),
-                imageService.getPresignedUrl(story.getImageKey())
+                imageStorage.getPresignedUrl(story.getImageKey())
         );
     }
 }
diff --git a/src/main/java/eatda/storage/image/CachePreSignedUrlStorage.java b/src/main/java/eatda/storage/image/CachePreSignedUrlStorage.java
@@ -0,0 +1,27 @@
+package eatda.storage.image;
+
+import eatda.repository.CacheSetting;
+import java.util.Optional;
+import org.springframework.cache.Cache;
+import org.springframework.cache.CacheManager;
+import org.springframework.stereotype.Component;
+
+@Component
+public class CachePreSignedUrlStorage {
+
+    private static final String CACHE_NAME = CacheSetting.IMAGE.getName();
+
+    private final Cache cache;
+
+    public CachePreSignedUrlStorage(CacheManager cacheManager) {
+        this.cache = cacheManager.getCache(CACHE_NAME);
+    }
+
+    public void put(String imageKey, String preSignedUrl) {
+        cache.put(imageKey, preSignedUrl);
+    }
+
+    public Optional<String> get(String imageKey) {
+        return Optional.ofNullable(cache.get(imageKey, String.class));
+    }
+}
diff --git a/src/main/java/eatda/storage/image/ExternalImageStorage.java b/src/main/java/eatda/storage/image/ExternalImageStorage.java
@@ -1,14 +1,14 @@
-package eatda.service.common;
+package eatda.storage.image;
 
+import eatda.domain.ImageDomain;
 import eatda.exception.BusinessErrorCode;
 import eatda.exception.BusinessException;
 import java.io.IOException;
 import java.time.Duration;
 import java.util.Set;
 import java.util.UUID;
 import org.springframework.beans.factory.annotation.Value;
-import org.springframework.lang.Nullable;
-import org.springframework.stereotype.Service;
+import org.springframework.stereotype.Component;
 import org.springframework.web.multipart.MultipartFile;
 import software.amazon.awssdk.core.sync.RequestBody;
 import software.amazon.awssdk.services.s3.S3Client;
@@ -17,8 +17,8 @@
 import software.amazon.awssdk.services.s3.presigner.S3Presigner;
 import software.amazon.awssdk.services.s3.presigner.model.GetObjectPresignRequest;
 
-@Service
-public class ImageService {
+@Component
+public class ExternalImageStorage {
 
     private static final Set<String> ALLOWED_CONTENT_TYPES = Set.of("image/jpg", "image/jpeg", "image/png");
     private static final String DEFAULT_CONTENT_TYPE = "bin";
@@ -30,7 +30,7 @@ public class ImageService {
     private final String bucket;
     private final S3Presigner s3Presigner;
 
-    public ImageService(
+    public ExternalImageStorage(
             S3Client s3Client,
             @Value("${spring.cloud.aws.s3.bucket}") String bucket,
             S3Presigner s3Presigner) {
@@ -75,12 +75,8 @@ private String getExtension(String filename) {
         return filename.substring(filename.lastIndexOf(EXTENSION_DELIMITER) + 1);
     }
 
-    @Nullable
-    public String getPresignedUrl(@Nullable String key) {
-        if (key == null) {
-            return null;
-        }
 
+    public String getPresignedUrl(String key) {
         try {
             GetObjectRequest getObjectRequest = GetObjectRequest.builder()
                     .bucket(bucket)
diff --git a/src/main/java/eatda/storage/image/ImageStorage.java b/src/main/java/eatda/storage/image/ImageStorage.java
@@ -0,0 +1,41 @@
+package eatda.storage.image;
+
+import eatda.domain.ImageDomain;
+import java.util.Optional;
+import lombok.RequiredArgsConstructor;
+import org.springframework.lang.Nullable;
+import org.springframework.stereotype.Component;
+import org.springframework.web.multipart.MultipartFile;
+
+@Component
+@RequiredArgsConstructor
+public class ImageStorage {
+
+    private final ExternalImageStorage externalImageStorage;
+    private final CachePreSignedUrlStorage cachePreSignedUrlStorage;
+
+
+    public String upload(MultipartFile file, ImageDomain domain) {
+        String imageKey = externalImageStorage.upload(file, domain);
+
+        String preSignedUrl = externalImageStorage.getPresignedUrl(imageKey);
+        cachePreSignedUrlStorage.put(imageKey, preSignedUrl);
+        return imageKey;
+    }
+
+    @Nullable
+    public String getPresignedUrl(@Nullable String imageKey) {
+        if (imageKey == null || imageKey.isEmpty()) {
+            return null;
+        }
+
+        Optional<String> cachedUrl = cachePreSignedUrlStorage.get(imageKey);
+        if (cachedUrl.isPresent()) {
+            return cachedUrl.get();
+        }
+
+        String preSignedUrl = externalImageStorage.getPresignedUrl(imageKey);
+        cachePreSignedUrlStorage.put(imageKey, preSignedUrl);
+        return preSignedUrl;
+    }
+}
diff --git a/src/test/java/eatda/controller/BaseControllerTest.java b/src/test/java/eatda/controller/BaseControllerTest.java
@@ -19,8 +19,8 @@
 import eatda.repository.member.MemberRepository;
 import eatda.repository.store.CheerRepository;
 import eatda.repository.store.StoreRepository;
-import eatda.service.common.ImageService;
 import eatda.service.story.StoryService;
+import eatda.storage.image.ImageStorage;
 import io.restassured.RestAssured;
 import io.restassured.builder.RequestSpecBuilder;
 import io.restassured.filter.Filter;
@@ -81,7 +81,7 @@ public class BaseControllerTest {
     private MapClient mapClient;
 
     @MockitoBean
-    private ImageService imageService;
+    private ImageStorage imageStorage;
 
     @MockitoBean
     protected StoryService storyService; // TODO 실 객체로 변환
@@ -113,8 +113,8 @@ final void mockingClient() throws URISyntaxException {
         );
         doReturn(searchResults).when(mapClient).searchShops(anyString());
 
-        doReturn(MOCKED_IMAGE_URL).when(imageService).getPresignedUrl(anyString());
-        doReturn(MOCKED_IMAGE_KEY).when(imageService).upload(any(), any());
+        doReturn(MOCKED_IMAGE_URL).when(imageStorage).getPresignedUrl(anyString());
+        doReturn(MOCKED_IMAGE_KEY).when(imageStorage).upload(any(), any());
     }
 
     protected final RequestSpecification given() {
diff --git a/src/test/java/eatda/document/BaseDocumentTest.java b/src/test/java/eatda/document/BaseDocumentTest.java
diff --git a/src/test/java/eatda/service/BaseServiceTest.java b/src/test/java/eatda/service/BaseServiceTest.java
diff --git a/src/test/java/eatda/service/story/StoryServiceTest.java b/src/test/java/eatda/service/story/StoryServiceTest.java
diff --git a/src/test/java/eatda/storage/BaseStorageTest.java b/src/test/java/eatda/storage/BaseStorageTest.java
diff --git a/src/test/java/eatda/storage/image/ExternalImageStorageTest.java b/src/test/java/eatda/storage/image/ExternalImageStorageTest.java
diff --git a/src/test/java/eatda/storage/image/ImageStorageTest.java b/src/test/java/eatda/storage/image/ImageStorageTest.java

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-package eatda.service.common;`
	`1`	`+package eatda.domain;`
`2`	`2`
`3`	`3`	`import lombok.Getter;`
`4`	`4`	`import lombok.RequiredArgsConstructor;`