[YS-306] fix: 공고 수정 시 nullable 필드 및 이미지 생성 버그 수정 (#96)

* fix: fix for update logics for changing TSID id strategy and nullable fields

* fix: define request dto in presentation layer

* fix: add idGenerator to newly added updateImages

* fix: change nullable to non-nullable for busniess rules

Author: chock-cho

src/main/kotlin/com/dobby/backend/application/usecase/experiment/UpdateExperimentPostUseCase.kt

@@ -1,6 +1,7 @@
 package com.dobby.backend.application.usecase.experiment
 
 import com.dobby.backend.application.usecase.UseCase
+import com.dobby.backend.domain.IdGenerator
 import com.dobby.backend.domain.exception.*
 import com.dobby.backend.domain.gateway.experiment.ExperimentPostGateway
 import com.dobby.backend.domain.model.experiment.ExperimentPost
@@ -12,7 +13,8 @@ import com.dobby.backend.infrastructure.database.entity.enums.areaInfo.Region
 import java.time.LocalDate
 
 class UpdateExperimentPostUseCase (
-    private val experimentPostGateway: ExperimentPostGateway
+    private val experimentPostGateway: ExperimentPostGateway,
+    private val idGenerator: IdGenerator
 ) : UseCase<UpdateExperimentPostUseCase.Input, UpdateExperimentPostUseCase.Output> {
     data class Input(
         val experimentPostId: String,
@@ -104,7 +106,8 @@ class UpdateExperimentPostUseCase (
             univName = input.univName,
             region = input.region,
             area = input.area,
-            imageListInfo = input.imageListInfo?.images
+            imageListInfo = input.imageListInfo?.images,
+            idGenerator = idGenerator
         )
         val updatedPost = experimentPostGateway.save(experimentPost)
 

src/main/kotlin/com/dobby/backend/domain/model/experiment/ExperimentPost.kt

@@ -1,5 +1,6 @@
 package com.dobby.backend.domain.model.experiment
 
+import com.dobby.backend.domain.IdGenerator
 import com.dobby.backend.domain.exception.ExperimentPostImageSizeException
 import com.dobby.backend.domain.exception.ExperimentPostInvalidOnlineRequestException
 import com.dobby.backend.domain.model.member.Member
@@ -69,12 +70,18 @@ data class ExperimentPost(
         univName: String?,
         region: Region?,
         area: Area?,
-        imageListInfo: List<String>?
+        imageListInfo: List<String>?,
+        idGenerator: IdGenerator
     ): ExperimentPost {
-        val updatedImages = imageListInfo?.map { imageUrl ->
-            val existingImage = this.images.find { it.imageUrl == imageUrl }
-            existingImage ?: ExperimentImage(id = "0", experimentPost = this, imageUrl = imageUrl)
-        } ?: this.images
+        val existingImageUrls = this.images.map { it.imageUrl }.toSet()
+        val newImages = imageListInfo?.filter { it !in existingImageUrls }?.map { imageUrl ->
+            ExperimentImage(
+                id = idGenerator.generateId(),
+                experimentPost = this,
+                imageUrl = imageUrl
+            )
+        } ?: emptyList()
+        val updatedImages = this.images.toMutableList().apply { addAll(newImages) }
 
         return this.copy(
             targetGroup = targetGroup ?: this.targetGroup,
@@ -88,9 +95,9 @@ data class ExperimentPost(
             leadResearcher = leadResearcher ?: this.leadResearcher,
             detailedAddress = detailedAddress ?: this.detailedAddress,
             matchType = matchType ?: this.matchType,
-            univName = univName ?: this.univName,
-            region = region ?: this.region,
-            area = area ?: this.area,
+            univName = univName,
+            region = region,
+            area = area,
             images = updatedImages.toMutableList(),
             updatedAt = LocalDateTime.now()
         ).apply { validate() }

src/main/kotlin/com/dobby/backend/presentation/api/dto/request/experiment/UpdateExperimentPostRequest.kt

@@ -17,11 +17,11 @@ data class UpdateExperimentPostRequest (
     val count: Int, // N 회 참여
     val timeRequired: TimeSlot?,
 
-    val leadResearcher: String, // 연구 책임 정보 -> 기본값: 연구자 정보에서 끌어와야 함, 추후에 자유롭게 수정 가능
+    val leadResearcher: String?, // 연구 책임 정보 -> 기본값: 연구자 정보에서 끌어와야 함, 추후에 자유롭게 수정 가능
 
-    val univName: String, // 대학교 이름 -> 기본값: 연구자 정보에서 끌어와야 함, 추후에 자유롭게 수정 가능
-    val region: Region,
-    val area: Area,
+    val univName: String?, // 대학교 이름 -> 기본값: 연구자 정보에서 끌어와야 함, 추후에 자유롭게 수정 가능
+    val region: Region?,
+    val area: Area?,
     val detailedAddress: String?,
 
     val reward: String,