Skip to content

Commit f17c151

Browse files
authored
Merge pull request #223 from YAPP-Github/refactor/#222-module-dependency-cleanup
[REFACTOR] 모듈간의 의존성을 깔끔하게 정리해보자
2 parents ccc2e38 + 6ecb05c commit f17c151

File tree

92 files changed

+401
-789
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

92 files changed

+401
-789
lines changed

app/build.gradle.kts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,21 +29,24 @@ android {
2929

3030
dependencies {
3131
implementation(projects.core.common)
32+
implementation(projects.core.analytics)
3233
implementation(projects.core.buildconfig)
3334
implementation(projects.core.network)
3435
implementation(projects.core.designsystem)
3536
implementation(projects.core.datastore)
3637
implementation(projects.core.alarm)
3738
implementation(projects.core.media)
39+
implementation(projects.core.ui)
3840
implementation(projects.data)
3941
implementation(projects.domain)
42+
implementation(projects.feature.splash)
4043
implementation(projects.feature.onboarding)
4144
implementation(projects.feature.home)
4245
implementation(projects.feature.alarmInteraction)
4346
implementation(projects.feature.fortune)
4447
implementation(projects.feature.mission)
4548
implementation(projects.feature.setting)
46-
implementation(projects.feature.navigator)
49+
implementation(projects.feature.webview)
4750
implementation(libs.firebase.analytics)
4851
implementation(libs.firebase.crashlytics)
4952
implementation(libs.play.services.ads)

app/src/main/AndroidManifest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
android:value="@string/admob_app_id" />
3131

3232
<activity
33-
android:name="com.yapp.navigator.MainActivity"
33+
android:name="com.yapp.orbit.MainActivity"
3434
android:windowSoftInputMode="adjustResize"
3535
android:exported="true"
3636
android:label="@string/app_name"

feature/navigator/src/main/java/com/yapp/navigator/MainActivity.kt renamed to app/src/main/java/com/yapp/orbit/MainActivity.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package com.yapp.navigator
1+
package com.yapp.orbit
22

33
import android.annotation.SuppressLint
44
import android.content.pm.ActivityInfo

feature/navigator/src/main/java/com/yapp/navigator/OrbitNavHost.kt renamed to app/src/main/java/com/yapp/orbit/OrbitNavHost.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package com.yapp.navigator
1+
package com.yapp.orbit
22

33
import android.annotation.SuppressLint
44
import androidx.compose.animation.AnimatedVisibility

build-logic/src/main/java/com/yapp/convention/ComposeAndroid.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@ internal fun Project.configureComposeAndroid() {
1616
val bom = libs.findLibrary("compose.bom").get()
1717
add("implementation", platform(bom))
1818

19+
add("implementation", libs.findLibrary("activity.compose").get())
20+
1921
add("implementation", libs.findLibrary("compose.material3").get())
2022
add("implementation", libs.findLibrary("compose.ui").get())
2123
add("implementation", libs.findLibrary("compose.ui.tooling.preview").get())

build-logic/src/main/java/com/yapp/convention/HiltAndroid.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ internal fun Project.configureHiltAndroid() {
1414
dependencies {
1515
"implementation"(libs.findLibrary("hilt.android").get())
1616
"ksp"(libs.findLibrary("hilt.android.compiler").get())
17+
"implementation"(libs.findLibrary("hilt-navigation-compose").get())
1718
}
1819
}
1920

build-logic/src/main/java/orbit.android.feature.gradle.kts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ dependencies {
1919
implementation(project(":core:ui"))
2020

2121
val libs = project.extensions.libs
22-
implementation(libs.findLibrary("hilt-navigation-compose").get())
2322
implementation(libs.findLibrary("compose-navigation").get())
2423
implementation(libs.findLibrary("lifecycle-viewmodel").get())
2524
implementation(libs.findLibrary("lifecycle-runtime").get())

core/alarm/build.gradle.kts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ android {
1111

1212
dependencies {
1313
implementation(projects.core.analytics)
14-
implementation(projects.core.datastore)
1514
implementation(projects.core.designsystem)
1615
implementation(projects.core.media)
1716
implementation(projects.domain)

core/alarm/src/main/java/com/yapp/alarm/AlarmModule.kt

Lines changed: 0 additions & 21 deletions
This file was deleted.

core/alarm/src/main/java/com/yapp/alarm/AlarmHelper.kt renamed to core/alarm/src/main/java/com/yapp/alarm/AndroidAlarmScheduler.kt

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,17 +9,18 @@ import com.yapp.domain.model.Alarm
99
import com.yapp.domain.model.AlarmDay
1010
import com.yapp.domain.model.toAlarmDays
1111
import com.yapp.domain.model.toDayOfWeek
12+
import com.yapp.domain.scheduler.AlarmScheduler
1213
import java.time.Instant
1314
import java.time.LocalDateTime
1415
import java.time.ZoneId
1516
import java.time.format.DateTimeFormatter
1617
import javax.inject.Inject
1718

18-
class AlarmHelper @Inject constructor(
19+
class AndroidAlarmScheduler @Inject constructor(
1920
private val app: Application,
2021
private val alarmManager: AlarmManager,
21-
) {
22-
fun scheduleAlarm(alarm: Alarm) {
22+
) : AlarmScheduler {
23+
override fun scheduleAlarm(alarm: Alarm) {
2324
val selectedDays = alarm.repeatDays.toAlarmDays()
2425

2526
if (selectedDays.isEmpty()) {
@@ -46,7 +47,7 @@ class AlarmHelper @Inject constructor(
4647
Log.d("AlarmHelper", "Scheduled weekly alarm for $day at: $triggerMillis")
4748
}
4849

49-
fun unScheduleAlarm(alarm: Alarm) {
50+
override fun unScheduleAlarm(alarm: Alarm) {
5051
val selectedDays = alarm.repeatDays.toAlarmDays()
5152

5253
if (selectedDays.isEmpty()) {

0 commit comments

Comments
 (0)