Skip to content

Commit 562c97c

Browse files
committed
[BOOK-477] chore: 토끼 리뷰 반영
1 parent 5887d7e commit 562c97c

File tree

6 files changed

+11
-11
lines changed

6 files changed

+11
-11
lines changed

feature/record/src/main/kotlin/com/ninecraft/booket/feature/record/register/RecordRegisterPresenter.kt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ import dev.zacsweers.metro.Assisted
3232
import dev.zacsweers.metro.AssistedFactory
3333
import dev.zacsweers.metro.AssistedInject
3434
import kotlinx.collections.immutable.ImmutableList
35-
import kotlinx.collections.immutable.PersistentList
3635
import kotlinx.collections.immutable.persistentListOf
3736
import kotlinx.collections.immutable.persistentMapOf
3837
import kotlinx.collections.immutable.toPersistentList
@@ -231,7 +230,7 @@ class RecordRegisterPresenter(
231230

232231
is RecordRegisterUiEvent.OnSelectEmotionV2 -> {
233232
selectedEmotion = event.emotion
234-
emotionDetails = getEmotionDetails(event.emotion) as PersistentList<String>
233+
emotionDetails = getEmotionDetails(event.emotion).toPersistentList()
235234
isEmotionDetailBottomSheetVisible = true
236235
}
237236

@@ -274,7 +273,7 @@ class RecordRegisterPresenter(
274273
isEmotionDetailBottomSheetVisible = false
275274
}
276275

277-
is RecordRegisterUiEvent.OnEmotionDatilBottomSheetDismiss -> {
276+
is RecordRegisterUiEvent.OnEmotionDetailBottomSheetDismiss -> {
278277
isEmotionDetailBottomSheetVisible = false
279278
}
280279

feature/record/src/main/kotlin/com/ninecraft/booket/feature/record/register/RecordRegisterUiState.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ sealed interface RecordRegisterUiEvent : CircuitUiEvent {
5858
data class OnEmotionDetailRemoved(val detail: String) : RecordRegisterUiEvent
5959
data object OnEmotionDetailSkipped : RecordRegisterUiEvent
6060
data object OnEmotionDetailCommitted : RecordRegisterUiEvent
61-
data object OnEmotionDatilBottomSheetDismiss : RecordRegisterUiEvent
61+
data object OnEmotionDetailBottomSheetDismiss : RecordRegisterUiEvent
6262
data object OnImpressionGuideButtonClick : RecordRegisterUiEvent
6363
data object OnImpressionGuideBottomSheetDismiss : RecordRegisterUiEvent
6464
data class OnSelectImpressionGuide(val index: Int) : RecordRegisterUiEvent

feature/record/src/main/kotlin/com/ninecraft/booket/feature/record/step_v2/EmotionItem.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -109,12 +109,12 @@ internal fun EmotionItem(
109109
horizontalArrangement = Arrangement.spacedBy(ReedTheme.spacing.spacing2),
110110
verticalArrangement = Arrangement.spacedBy(ReedTheme.spacing.spacing2),
111111
) {
112-
selectedEmotionDetails.forEach { emotion ->
112+
selectedEmotionDetails.forEach { detail ->
113113
ReedRemovableChip(
114-
label = emotion,
114+
label = detail,
115115
chipSizeStyle = smallChipStyle,
116116
onRemove = {
117-
onEmotionDetailRemove(emotion)
117+
onEmotionDetailRemove(detail)
118118
},
119119
)
120120
}

feature/record/src/main/kotlin/com/ninecraft/booket/feature/record/step_v2/EmotionStepV2.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -114,13 +114,13 @@ internal fun EmotionStepV2(
114114
emotionDetails = state.emotionDetails,
115115
selectedEmotionDetail = state.selectedEmotionDetails[state.selectedEmotion] ?: persistentListOf(),
116116
onDismissRequest = {
117-
state.eventSink(RecordRegisterUiEvent.OnEmotionDatilBottomSheetDismiss)
117+
state.eventSink(RecordRegisterUiEvent.OnEmotionDetailBottomSheetDismiss)
118118
},
119119
sheetState = emotionDetailBottomSheetState,
120120
onCloseButtonClick = {
121121
coroutineScope.launch {
122122
emotionDetailBottomSheetState.hide()
123-
state.eventSink(RecordRegisterUiEvent.OnEmotionDatilBottomSheetDismiss)
123+
state.eventSink(RecordRegisterUiEvent.OnEmotionDetailBottomSheetDismiss)
124124
}
125125
},
126126
onEmotionDetailToggled = { detail ->

feature/record/src/main/kotlin/com/ninecraft/booket/feature/record/step_v2/QuoteStepV2.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ internal fun QuoteStepV2(
176176
verticalAlignment = Alignment.CenterVertically,
177177
) {
178178
Text(
179-
text = "메모",
179+
text = stringResource(R.string.quote_step_memo_label),
180180
color = ReedTheme.colors.contentPrimary,
181181
style = ReedTheme.typography.body1Medium,
182182
)

feature/record/src/main/res/values/strings.xml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@
2424
<string name="quote_step_scan_sentence">문장 스캔하기</string>
2525
<string name="quote_step_page_hint">기록하고 싶은 페이지를 작성해보세요</string>
2626
<string name="quote_step_sentence_hint">기록하고 싶은 문장을 작성해보세요</string>
27+
<string name="quote_step_memo_label">메모</string>
28+
<string name="quote_step_memo_hint">기록하고 싶은 메모가 있다면 작성해보세요</string>
2729
<string name="emotion_step_title">문장에 대해 어떤 감정이 드셨나요?</string>
2830
<string name="emotion_step_description">대표 감정을 한 가지 선택해주세요</string>
2931
<string name="impression_step_title">문장에 대한 감상을 남겨주세요</string>
@@ -42,7 +44,6 @@
4244
<string name="impression_guide_tooltip_message">예시 문장을 알려드려요</string>
4345
<string name="scan_tooltip_message">스캔으로 빠르게 입력해요</string>
4446
<string name="select">선택</string>
45-
<string name="quote_step_memo_hint">기록하고 싶은 메모가 있다면 작성해보세요</string>
4647
<string name="emotion_detail_title">어떤 %1$s을 느꼈나요?</string>
4748
<string name="emotion_detail_description">더 자세한 감정을 선택 기록할 수 있어요.</string>
4849
<string name="emotion_detail_skip">건너뛰기</string>

0 commit comments

Comments
 (0)