Skip to content

Commit 5f94120

Browse files
committed
[BOOK-233] refactor: 토끼 리뷰 반영
1 parent 5debfeb commit 5f94120

File tree

5 files changed

+9
-3
lines changed

5 files changed

+9
-3
lines changed

core/common/src/main/kotlin/com/ninecraft/booket/core/common/event/ErrorEventHelper.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import kotlinx.coroutines.flow.receiveAsFlow
66
import java.util.UUID
77

88
object ErrorEventHelper {
9-
private val _errorEvent = Channel<ErrorEvent>(DEFAULT_BUFFER_SIZE)
9+
private val _errorEvent = Channel<ErrorEvent>(Channel.BUFFERED)
1010
val errorEvent = _errorEvent.receiveAsFlow()
1111

1212
fun sendError(event: ErrorEvent) {

feature/detail/src/main/kotlin/com/ninecraft/booket/feature/detail/book/BookDetailPresenter.kt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,9 @@ class BookDetailPresenter @AssistedInject constructor(
9898
seedsStates = seeds.categories.toImmutableList()
9999
readingRecords = records.content.toPersistentList()
100100

101+
isLastPage = records.content.size < PAGE_SIZE
102+
currentStartIndex = START_INDEX
103+
101104
uiState = UiState.Success
102105
}
103106
} catch (ce: CancellationException) {

feature/detail/src/main/kotlin/com/ninecraft/booket/feature/detail/record/RecordDetailPresenter.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,8 @@ class RecordDetailPresenter @AssistedInject constructor(
4141

4242
repository.getRecordDetail(readingRecordId = readingRecordId)
4343
.onSuccess { result ->
44-
uiState = UiState.Success
4544
recordDetailInfo = result
45+
uiState = UiState.Success
4646
}
4747
.onFailure { exception ->
4848
uiState = UiState.Error(exception)

feature/home/src/main/kotlin/com/ninecraft/booket/feature/home/HomePresenter.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ class HomePresenter @AssistedInject constructor(
3939

4040
fun loadHomeContent() {
4141
scope.launch {
42-
if (uiState == UiState.Idle) {
42+
if (uiState is UiState.Idle || uiState is UiState.Error) {
4343
uiState = UiState.Loading
4444
}
4545

feature/main/src/main/kotlin/com/ninecraft/booket/feature/main/MainActivity.kt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,9 @@ class MainActivity : ComponentActivity() {
7575
spec.action()
7676
dialogSpec.value = null
7777
},
78+
onDismissRequest = {
79+
dialogSpec.value = null
80+
},
7881
)
7982
}
8083

0 commit comments

Comments
 (0)