Skip to content

Commit 66b52ab

Browse files
committed
fix: 독서 기록 화면 감상평 빈 값일 경우 하단 패딩 제거
""로 들어가도 Text의 높이를 그대로 차지함, 감상푱아 빈 값일 경우 Text Composable 사용 X
1 parent 56ff9d1 commit 66b52ab

File tree

2 files changed

+48
-7
lines changed

2 files changed

+48
-7
lines changed

feature/detail/src/main/kotlin/com/ninecraft/booket/feature/detail/record/RecordDetailUi.kt

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -206,3 +206,30 @@ private fun ReviewDetailPreview() {
206206
)
207207
}
208208
}
209+
210+
@ComponentPreview
211+
@Composable
212+
private fun ReviewDetailEmptyPreview() {
213+
ReedTheme {
214+
RecordDetailUi(
215+
state = RecordDetailUiState(
216+
uiState = UiState.Success,
217+
recordDetailInfo = RecordDetailModel(
218+
id = "",
219+
userBookId = "",
220+
pageNumber = 90,
221+
quote = "소설가들은 늘 소재를 찾아 떠도는 존재 같지만, 실은 그 반대인 경우가 더 잦다.",
222+
review = "",
223+
emotionTags = listOf("따뜻함"),
224+
createdAt = "2023.10.10",
225+
updatedAt = "",
226+
bookTitle = "여름은 오래 그곳에 남아",
227+
bookPublisher = "비채 비채 비채 비채",
228+
bookCoverImageUrl = "",
229+
author = "미쓰이에 마사시, 미쓰이에 마사시, 미쓰이에 마사시, 미쓰이에 마사시",
230+
),
231+
eventSink = {},
232+
),
233+
)
234+
}
235+
}

feature/detail/src/main/kotlin/com/ninecraft/booket/feature/detail/record/component/ReviewItem.kt

Lines changed: 21 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ internal fun ReviewItem(
3939
)
4040
.padding(
4141
horizontal = ReedTheme.spacing.spacing4,
42-
vertical = ReedTheme.spacing.spacing3,
42+
vertical = ReedTheme.spacing.spacing4,
4343
),
4444
) {
4545
Column {
@@ -68,12 +68,14 @@ internal fun ReviewItem(
6868
style = ReedTheme.typography.label2Regular,
6969
)
7070
}
71-
Spacer(modifier = Modifier.height(ReedTheme.spacing.spacing3))
72-
Text(
73-
text = review,
74-
color = ReedTheme.colors.contentSecondary,
75-
style = ReedTheme.typography.label1Medium,
76-
)
71+
if (review.isNotBlank()) {
72+
Spacer(modifier = Modifier.height(ReedTheme.spacing.spacing3))
73+
Text(
74+
text = review,
75+
color = ReedTheme.colors.contentSecondary,
76+
style = ReedTheme.typography.label1Medium,
77+
)
78+
}
7779
}
7880
}
7981
}
@@ -89,3 +91,15 @@ private fun ReviewBoxPreview() {
8991
)
9092
}
9193
}
94+
95+
@ComponentPreview
96+
@Composable
97+
private fun ReviewBoxEmptyPreview() {
98+
ReedTheme {
99+
ReviewItem(
100+
emotion = "따뜻함",
101+
review = "",
102+
createdAt = "2025.06.25",
103+
)
104+
}
105+
}

0 commit comments

Comments
 (0)