Skip to content

Commit 6bdd62b

Browse files
committed
[BOOK-124] chore: BottomNavigationPresenter내 rootNavigator 주입 제거, NavigateToFullScreen 이벤트 및 함수 제거
각각의 Home, Search, Library 화면에서 직접 화면 이동을 구현하고 있어 navigateToFullScreen 함수를 사용하지 않고 있음
1 parent dc81add commit 6bdd62b

File tree

2 files changed

+2
-12
lines changed

2 files changed

+2
-12
lines changed

feature/main/src/main/kotlin/com/ninecraft/booket/feature/main/screens/BottomNavigationPresenter.kt

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -8,16 +8,12 @@ import com.slack.circuit.backstack.SaveableBackStack
88
import com.slack.circuit.backstack.rememberSaveableBackStack
99
import com.slack.circuit.codegen.annotations.CircuitInject
1010
import com.slack.circuit.foundation.rememberCircuitNavigator
11-
import com.slack.circuit.runtime.Navigator
1211
import com.slack.circuit.runtime.presenter.Presenter
13-
import dagger.assisted.Assisted
1412
import dagger.assisted.AssistedFactory
1513
import dagger.assisted.AssistedInject
1614
import dagger.hilt.android.components.ActivityRetainedComponent
1715

18-
class BottomNavigationPresenter @AssistedInject constructor(
19-
@Assisted private val rootNavigator: Navigator,
20-
) : Presenter<BottomNavigationUiState> {
16+
class BottomNavigationPresenter @AssistedInject constructor() : Presenter<BottomNavigationUiState> {
2117

2218
@Composable
2319
override fun present(): BottomNavigationUiState {
@@ -35,10 +31,6 @@ class BottomNavigationPresenter @AssistedInject constructor(
3531
restoreState = true,
3632
)
3733
}
38-
39-
is BottomNavigationUiEvent.NavigateToFullScreen -> {
40-
rootNavigator.goTo(event.screen)
41-
}
4234
}
4335
}
4436

@@ -53,7 +45,7 @@ class BottomNavigationPresenter @AssistedInject constructor(
5345
@CircuitInject(BottomNavigationScreen::class, ActivityRetainedComponent::class)
5446
@AssistedFactory
5547
fun interface Factory {
56-
fun create(rootNavigator: Navigator): BottomNavigationPresenter
48+
fun create(): BottomNavigationPresenter
5749
}
5850
}
5951

feature/main/src/main/kotlin/com/ninecraft/booket/feature/main/screens/BottomNavigationUiState.kt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,4 @@ data class BottomNavigationUiState(
1414

1515
sealed interface BottomNavigationUiEvent {
1616
data class OnTabSelected(val tab: MainTab) : BottomNavigationUiEvent
17-
data class NavigateToFullScreen(val screen: com.slack.circuit.runtime.screen.Screen) :
18-
BottomNavigationUiEvent
1917
}

0 commit comments

Comments
 (0)