Skip to content

Commit 97b09db

Browse files
committed
[BOOK-147] refactor: ReedDialog 필수 항목 기본값 제거
1 parent 323e142 commit 97b09db

File tree

1 file changed

+14
-11
lines changed
  • core/designsystem/src/main/kotlin/com/ninecraft/booket/core/designsystem/component

1 file changed

+14
-11
lines changed

core/designsystem/src/main/kotlin/com/ninecraft/booket/core/designsystem/component/ReedDialog.kt

Lines changed: 14 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,12 @@ import com.ninecraft.booket.core.designsystem.theme.ReedTheme
2323

2424
@Composable
2525
fun ReedDialog(
26-
title: String = "",
27-
subtext: String? = null,
28-
confirmButtonText: String = "",
26+
title: String,
27+
confirmButtonText: String,
28+
onConfirmRequest: () -> Unit,
29+
modifier: Modifier = Modifier,
30+
description: String? = null,
2931
dismissButtonText: String? = null,
30-
onConfirmRequest: () -> Unit = {},
3132
onDismissRequest: () -> Unit = {},
3233
) {
3334
Dialog(
@@ -36,7 +37,7 @@ fun ReedDialog(
3637
},
3738
) {
3839
Column(
39-
modifier = Modifier
40+
modifier = modifier
4041
.fillMaxWidth()
4142
.background(
4243
color = ReedTheme.colors.basePrimary,
@@ -58,10 +59,10 @@ fun ReedDialog(
5859
textAlign = TextAlign.Center,
5960
style = ReedTheme.typography.headline1SemiBold,
6061
)
61-
subtext?.let {
62+
description?.let {
6263
Spacer(modifier = Modifier.height(ReedTheme.spacing.spacing2))
6364
Text(
64-
text = subtext,
65+
text = description,
6566
color = ReedTheme.colors.contentSecondary,
6667
textAlign = TextAlign.Center,
6768
style = ReedTheme.typography.body2Medium,
@@ -99,24 +100,26 @@ fun ReedDialog(
99100

100101
@Preview
101102
@Composable
102-
fun ReedConfirmDialogPreview() {
103+
private fun ReedConfirmDialogPreview() {
103104
ReedTheme {
104105
ReedDialog(
105106
title = "Title",
106-
subtext = "subtext",
107107
confirmButtonText = "확인",
108+
onConfirmRequest = {},
109+
description = "subtext",
108110
)
109111
}
110112
}
111113

112114
@Preview
113115
@Composable
114-
fun ReedChoiceDialogPreview() {
116+
private fun ReedChoiceDialogPreview() {
115117
ReedTheme {
116118
ReedDialog(
117119
title = "Title",
118-
subtext = "subtext",
119120
confirmButtonText = "확인",
121+
onConfirmRequest = {},
122+
description = "subtext",
120123
dismissButtonText = "취소",
121124
)
122125
}

0 commit comments

Comments
 (0)