Skip to content

Commit a41d39c

Browse files
authored
Merge pull request #214 from YAPP-Github/BOOK-417-fix/#213
fix: 감정별 배경/텍스트 색상 매칭 수정
2 parents c6da703 + a8b5f54 commit a41d39c

File tree

19 files changed

+90
-91
lines changed

19 files changed

+90
-91
lines changed

core/common/src/main/kotlin/com/ninecraft/booket/core/common/extensions/Emotion.kt

Lines changed: 0 additions & 22 deletions
This file was deleted.

core/designsystem/build.gradle.kts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ android {
1212
dependencies {
1313
implementations(
1414
projects.core.common,
15+
projects.core.model,
1516

1617
libs.androidx.splash,
1718

Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
package com.ninecraft.booket.core.designsystem
2+
3+
import androidx.compose.ui.graphics.Color
4+
import com.ninecraft.booket.core.designsystem.theme.InsightBgColor
5+
import com.ninecraft.booket.core.designsystem.theme.InsightTextColor
6+
import com.ninecraft.booket.core.designsystem.theme.JoyBgColor
7+
import com.ninecraft.booket.core.designsystem.theme.JoyTextColor
8+
import com.ninecraft.booket.core.designsystem.theme.SadnessBgColor
9+
import com.ninecraft.booket.core.designsystem.theme.SadnessTextColor
10+
import com.ninecraft.booket.core.designsystem.theme.WarmthBgColor
11+
import com.ninecraft.booket.core.designsystem.theme.WarmthTextColor
12+
import com.ninecraft.booket.core.model.Emotion
13+
14+
val Emotion.bgColor: Color
15+
get() = when (this) {
16+
Emotion.WARM -> WarmthBgColor
17+
Emotion.JOY -> JoyBgColor
18+
Emotion.SAD -> SadnessBgColor
19+
Emotion.INSIGHT -> InsightBgColor
20+
}
21+
22+
val Emotion.textColor: Color
23+
get() = when (this) {
24+
Emotion.WARM -> WarmthTextColor
25+
Emotion.JOY -> JoyTextColor
26+
Emotion.SAD -> SadnessTextColor
27+
Emotion.INSIGHT -> InsightTextColor
28+
}
29+
30+
val Emotion.graphicRes: Int
31+
get() = when (this) {
32+
Emotion.WARM -> R.drawable.img_emotion_warmth
33+
Emotion.JOY -> R.drawable.img_emotion_joy
34+
Emotion.SAD -> R.drawable.img_emotion_sadness
35+
Emotion.INSIGHT -> R.drawable.img_emotion_insight
36+
}

core/designsystem/src/main/kotlin/com/ninecraft/booket/core/designsystem/EmotionTag.kt

Lines changed: 0 additions & 18 deletions
This file was deleted.

feature/detail/src/main/kotlin/com/ninecraft/booket/feature/detail/book/BookDetailPresenter.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -306,7 +306,7 @@ class BookDetailPresenter @AssistedInject constructor(
306306
RecordCardScreen(
307307
quote = selectedRecordInfo.quote,
308308
bookTitle = selectedRecordInfo.bookTitle,
309-
emotionTag = selectedRecordInfo.emotionTags[0],
309+
emotion = selectedRecordInfo.emotionTags[0],
310310
),
311311
)
312312
}

feature/detail/src/main/kotlin/com/ninecraft/booket/feature/detail/book/component/SeedItem.kt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@ import androidx.compose.ui.Modifier
1616
import androidx.compose.ui.draw.clip
1717
import androidx.compose.ui.res.painterResource
1818
import androidx.compose.ui.unit.dp
19-
import com.ninecraft.booket.core.common.extensions.toBackgroundColor
20-
import com.ninecraft.booket.core.common.extensions.toTextColor
2119
import com.ninecraft.booket.core.designsystem.ComponentPreview
20+
import com.ninecraft.booket.core.designsystem.bgColor
21+
import com.ninecraft.booket.core.designsystem.textColor
2222
import com.ninecraft.booket.core.designsystem.theme.ReedTheme
2323
import com.ninecraft.booket.core.model.Emotion
2424
import com.ninecraft.booket.core.model.EmotionModel
@@ -42,7 +42,7 @@ internal fun SeedItem(
4242
Box(
4343
modifier = Modifier
4444
.clip(RoundedCornerShape(ReedTheme.radius.full))
45-
.background(emotion.name.toBackgroundColor())
45+
.background(emotion.name.bgColor)
4646
.padding(
4747
horizontal = ReedTheme.spacing.spacing2,
4848
vertical = ReedTheme.spacing.spacing1,
@@ -51,7 +51,7 @@ internal fun SeedItem(
5151
) {
5252
Text(
5353
text = emotion.name.displayName,
54-
color = emotion.name.toTextColor(),
54+
color = emotion.name.textColor,
5555
style = ReedTheme.typography.label2SemiBold,
5656
)
5757
}

feature/detail/src/main/kotlin/com/ninecraft/booket/feature/detail/card/RecordCardPresenter.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ class RecordCardPresenter @AssistedInject constructor(
7474
isLoading = isLoading,
7575
quote = screen.quote,
7676
bookTitle = screen.bookTitle,
77-
emotionTag = screen.emotionTag,
77+
emotion = screen.emotion,
7878
isCapturing = isCapturing,
7979
isSharing = isSharing,
8080
sideEffect = sideEffect,

feature/detail/src/main/kotlin/com/ninecraft/booket/feature/detail/card/RecordCardUi.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ internal fun RecordCardUi(
8383
RecordCard(
8484
quote = state.quote,
8585
bookTitle = state.bookTitle,
86-
emotionTag = state.emotionTag,
86+
emotion = state.emotion,
8787
modifier = Modifier
8888
.padding(top = ReedTheme.spacing.spacing5)
8989
.clip(RoundedCornerShape(ReedTheme.radius.md))

feature/detail/src/main/kotlin/com/ninecraft/booket/feature/detail/card/RecordCardUiState.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ data class RecordCardUiState(
1111
val quote: String = "",
1212
val bookTitle: String = "",
1313
val author: String = "",
14-
val emotionTag: String = "",
14+
val emotion: String = "",
1515
val isCapturing: Boolean = false,
1616
val isSharing: Boolean = false,
1717
val sideEffect: RecordCardSideEffect? = null,

feature/detail/src/main/kotlin/com/ninecraft/booket/feature/detail/card/component/RecordCard.kt

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -19,20 +19,20 @@ import androidx.compose.ui.res.painterResource
1919
import androidx.compose.ui.text.style.TextOverflow
2020
import androidx.compose.ui.unit.sp
2121
import com.ninecraft.booket.core.designsystem.ComponentPreview
22-
import com.ninecraft.booket.core.designsystem.EmotionTag
2322
import com.ninecraft.booket.core.designsystem.theme.ReedTheme
23+
import com.ninecraft.booket.core.model.Emotion
2424
import com.ninecraft.booket.feature.detail.R
2525

2626
@Composable
2727
internal fun RecordCard(
2828
quote: String,
2929
bookTitle: String,
30-
emotionTag: String,
30+
emotion: String,
3131
modifier: Modifier = Modifier,
3232
) {
3333
Box(modifier = modifier.fillMaxWidth()) {
3434
Image(
35-
painter = painterResource(getEmotionCardImage(emotionTag)),
35+
painter = painterResource(getEmotionCardImage(emotion)),
3636
contentDescription = "Record Card Image",
3737
modifier = Modifier.fillMaxSize(),
3838
contentScale = ContentScale.Crop,
@@ -74,12 +74,12 @@ internal fun RecordCard(
7474
}
7575
}
7676

77-
private fun getEmotionCardImage(emotionTag: String): Int {
78-
return when (emotionTag) {
79-
EmotionTag.WARMTH.label -> R.drawable.img_record_card_warm
80-
EmotionTag.JOY.label -> R.drawable.img_record_card_joy
81-
EmotionTag.SADNESS.label -> R.drawable.img_record_card_sad
82-
EmotionTag.INSIGHT.label -> R.drawable.img_record_card_insight
77+
private fun getEmotionCardImage(emotion: String): Int {
78+
return when (emotion) {
79+
Emotion.WARM.displayName -> R.drawable.img_record_card_warm
80+
Emotion.JOY.displayName -> R.drawable.img_record_card_joy
81+
Emotion.SAD.displayName -> R.drawable.img_record_card_sad
82+
Emotion.INSIGHT.displayName -> R.drawable.img_record_card_insight
8383
else -> R.drawable.img_record_card_warm
8484
}
8585
}
@@ -91,7 +91,7 @@ private fun RecordCardPreview() {
9191
RecordCard(
9292
quote = "이 세상에 집이라 이름 붙일 수 없는 것이 있다면 그건 바로 여기, 내가 앉아 있는 이곳일 것이다.",
9393
bookTitle = "샤이닝",
94-
emotionTag = EmotionTag.WARMTH.label,
94+
emotion = Emotion.WARM.displayName,
9595
)
9696
}
9797
}

0 commit comments

Comments
 (0)