Skip to content

Commit cb744e6

Browse files
committed
[BOOK-168] refactor: 불필요한 sideEffect 초기화 제거
1 parent 9d0ce07 commit cb744e6

File tree

3 files changed

+1
-13
lines changed

3 files changed

+1
-13
lines changed

feature/detail/src/main/kotlin/com/ninecraft/booket/feature/detail/review/ReviewDetailSideEffect.kt renamed to feature/detail/src/main/kotlin/com/ninecraft/booket/feature/detail/review/HandleReviewDetailSideEffect.kt

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ import com.skydoves.compose.effects.RememberedEffect
88
@Composable
99
internal fun HandleReviewDetailSideEffects(
1010
state: ReviewDetailUiState,
11-
eventSink: (ReviewDetailUiEvent) -> Unit,
1211
) {
1312
val context = LocalContext.current
1413

@@ -20,9 +19,5 @@ internal fun HandleReviewDetailSideEffects(
2019

2120
null -> {}
2221
}
23-
24-
if (state.sideEffect != null) {
25-
eventSink(ReviewDetailUiEvent.InitSideEffect)
26-
}
2722
}
2823
}

feature/detail/src/main/kotlin/com/ninecraft/booket/feature/detail/review/ReviewDetailPresenter.kt

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,6 @@ class ReviewDetailPresenter @AssistedInject constructor(
2828

2929
fun handleEvent(event: ReviewDetailUiEvent) {
3030
when (event) {
31-
ReviewDetailUiEvent.InitSideEffect -> {
32-
sideEffect = null
33-
}
34-
3531
ReviewDetailUiEvent.OnBackClicked -> {
3632
navigator.pop()
3733
}
@@ -47,7 +43,5 @@ class ReviewDetailPresenter @AssistedInject constructor(
4743
@CircuitInject(ReviewDetailScreen::class, ActivityRetainedComponent::class)
4844
@AssistedFactory
4945
fun interface Factory {
50-
fun create(
51-
navigator: Navigator,
52-
): ReviewDetailPresenter
46+
fun create(navigator: Navigator): ReviewDetailPresenter
5347
}

feature/detail/src/main/kotlin/com/ninecraft/booket/feature/detail/review/ReviewDetailUiState.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,5 @@ sealed interface ReviewDetailSideEffect {
1717
}
1818

1919
sealed interface ReviewDetailUiEvent : CircuitUiEvent {
20-
data object InitSideEffect : ReviewDetailUiEvent
2120
data object OnBackClicked : ReviewDetailUiEvent
2221
}

0 commit comments

Comments
 (0)