Skip to content

Commit fabd9b2

Browse files
authored
Merge pull request #146 from YAPP-Github/BOOK-260-fix/#142
[BOOK-260] feat: 스플래시 화면 네트워크 연결 에러 대응
2 parents c7bdf0f + e919ffb commit fabd9b2

File tree

15 files changed

+84
-19
lines changed

15 files changed

+84
-19
lines changed

core/common/src/main/kotlin/com/ninecraft/booket/core/common/constants/ErrorDialogSpec.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,6 @@ package com.ninecraft.booket.core.common.constants
22

33
data class ErrorDialogSpec(
44
val message: String,
5-
val buttonLabel: String,
5+
val buttonLabelResId: Int,
66
val action: () -> Unit,
77
)

core/common/src/main/kotlin/com/ninecraft/booket/core/common/utils/HandleException.kt

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
package com.ninecraft.booket.core.common.utils
22

3+
import androidx.annotation.StringRes
4+
import com.ninecraft.booket.core.common.R
35
import com.ninecraft.booket.core.common.constants.ErrorDialogSpec
46
import com.ninecraft.booket.core.common.constants.ErrorScope
57
import com.ninecraft.booket.core.common.event.ErrorEvent
@@ -46,11 +48,13 @@ fun handleException(
4648
fun postErrorDialog(
4749
errorScope: ErrorScope,
4850
exception: Throwable,
51+
@StringRes buttonLabelResId: Int = R.string.confirm,
4952
action: () -> Unit = {},
5053
) {
5154
val spec = buildDialog(
5255
scope = errorScope,
5356
exception = exception,
57+
buttonLabelResId = buttonLabelResId,
5458
action = action,
5559
)
5660

@@ -60,6 +64,7 @@ fun postErrorDialog(
6064
private fun buildDialog(
6165
scope: ErrorScope,
6266
exception: Throwable,
67+
@StringRes buttonLabelResId: Int,
6368
action: () -> Unit,
6469
): ErrorDialogSpec {
6570
val message = when {
@@ -92,7 +97,7 @@ private fun buildDialog(
9297
}
9398
}
9499

95-
return ErrorDialogSpec(message = message, buttonLabel = "확인", action = action)
100+
return ErrorDialogSpec(message = message, buttonLabelResId = buttonLabelResId, action = action)
96101
}
97102

98103
@Suppress("TooGenericExceptionCaught")

core/common/src/main/res/values/strings.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,5 @@
55
<string name="book_status_completed">독서 완료</string>
66
<string name="record_sort_page_ascending">페이지순</string>
77
<string name="record_sort_recent_register">최신 등록순</string>
8+
<string name="confirm">확인</string>
89
</resources>

core/model/src/main/kotlin/com/ninecraft/booket/core/model/BookUpsertModel.kt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
package com.ninecraft.booket.core.model
22

3-
import androidx.compose.runtime.Stable
4-
5-
@Stable
63
data class BookUpsertModel(
74
val userBookId: String,
85
val userId: String,

core/model/src/main/kotlin/com/ninecraft/booket/core/model/ReadingRecordsModel.kt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
package com.ninecraft.booket.core.model
22

3+
import androidx.compose.runtime.Stable
4+
35
data class ReadingRecordsModel(
46
val lastPage: Boolean = true,
57
val totalResults: Int = 0,
@@ -8,6 +10,7 @@ data class ReadingRecordsModel(
810
val readingRecords: List<ReadingRecordModel> = emptyList(),
911
)
1012

13+
@Stable
1114
data class ReadingRecordModel(
1215
val id: String = "",
1316
val userBookId: String = "",

core/ui/src/main/kotlin/com/ninecraft/booket/core/ui/ReedScaffold.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,13 +22,13 @@ fun ReedScaffold(
2222
content: @Composable (PaddingValues) -> Unit,
2323
) {
2424
Scaffold(
25+
modifier = modifier.keyboardHide(),
2526
topBar = topBar,
2627
bottomBar = bottomBar,
2728
snackbarHost = snackbarHost,
2829
floatingActionButton = floatingActionButton,
2930
containerColor = containerColor,
3031
contentWindowInsets = contentWindowInsets,
31-
modifier = modifier.keyboardHide(),
3232
) { innerPadding ->
3333
content(innerPadding)
3434
}

feature/main/src/main/kotlin/com/ninecraft/booket/feature/main/MainActivity.kt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ import androidx.compose.runtime.mutableStateOf
1111
import androidx.compose.runtime.remember
1212
import androidx.compose.ui.Modifier
1313
import androidx.compose.ui.graphics.Color
14+
import androidx.compose.ui.res.stringResource
1415
import androidx.core.splashscreen.SplashScreen.Companion.installSplashScreen
1516
import com.ninecraft.booket.core.common.constants.ErrorDialogSpec
1617
import com.ninecraft.booket.core.common.event.ErrorEvent
@@ -70,7 +71,8 @@ class MainActivity : ComponentActivity() {
7071
dialogSpec.value?.let { spec ->
7172
ReedDialog(
7273
description = spec.message,
73-
confirmButtonText = spec.buttonLabel,
74+
confirmButtonText = stringResource(spec.buttonLabelResId),
75+
7476
onConfirmRequest = {
7577
spec.action()
7678
dialogSpec.value = null

feature/record/src/main/kotlin/com/ninecraft/booket/feature/record/register/RecordRegisterUi.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ internal fun RecordRegisterUi(
5656
)
5757
RecordProgressBar(
5858
currentStep = state.currentStep,
59-
modifier = modifier.padding(horizontal = ReedTheme.spacing.spacing5),
59+
modifier = Modifier.padding(horizontal = ReedTheme.spacing.spacing5),
6060
)
6161
Spacer(modifier = Modifier.height(ReedTheme.spacing.spacing10))
6262
when (state.currentStep) {

feature/search/src/main/kotlin/com/ninecraft/booket/feature/search/book/BookSearchPresenter.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ class BookSearchPresenter @AssistedInject constructor(
158158
}
159159

160160
is BookSearchUiEvent.OnSearchClick -> {
161-
val query = event.text.trim()
161+
val query = event.query.trim()
162162
if (query.isNotEmpty()) {
163163
searchBooks(query = query, startIndex = START_INDEX)
164164
}

feature/search/src/main/kotlin/com/ninecraft/booket/feature/search/book/BookSearchUi.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -93,13 +93,13 @@ internal fun SearchContent(
9393
ReedTextField(
9494
queryState = state.queryState,
9595
queryHintRes = designR.string.search_book_hint,
96-
onSearch = { text ->
97-
state.eventSink(BookSearchUiEvent.OnSearchClick(text))
96+
onSearch = { query ->
97+
state.eventSink(BookSearchUiEvent.OnSearchClick(query))
9898
},
9999
onClear = {
100100
state.eventSink(BookSearchUiEvent.OnClearClick)
101101
},
102-
modifier = modifier.padding(horizontal = ReedTheme.spacing.spacing5),
102+
modifier = Modifier.padding(horizontal = ReedTheme.spacing.spacing5),
103103
borderStroke = BorderStroke(width = 1.dp, color = ReedTheme.colors.borderBrand),
104104
searchIconTint = ReedTheme.colors.contentBrand,
105105
)

0 commit comments

Comments
 (0)