Skip to content

Commit 76ea1c7

Browse files
committed
hotfix: 독서기록 review optional하게 처리
1 parent 5fa446c commit 76ea1c7

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

domain/src/main/kotlin/org/yapp/domain/readingrecord/ReadingRecord.kt

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ data class ReadingRecord private constructor(
2828
userBookId = UserBookId.newInstance(userBookId),
2929
pageNumber = PageNumber.newInstance(pageNumber),
3030
quote = Quote.newInstance(quote),
31-
review = review?.let { Review.newInstance(it) },
31+
review = Review.newInstance(review),
3232
emotionTags = emotionTags.map { EmotionTag.newInstance(it) }
3333
)
3434
}
@@ -67,7 +67,7 @@ data class ReadingRecord private constructor(
6767
return this.copy(
6868
pageNumber = pageNumber?.let { PageNumber.newInstance(it) } ?: this.pageNumber,
6969
quote = quote?.let { Quote.newInstance(it) } ?: this.quote,
70-
review = review?.let { Review.newInstance(it) },
70+
review = if (review != null) Review.newInstance(review) else this.review,
7171
emotionTags = emotionTags?.map { EmotionTag.newInstance(it) } ?: this.emotionTags,
7272
updatedAt = LocalDateTime.now()
7373
)
@@ -111,8 +111,10 @@ data class ReadingRecord private constructor(
111111
@JvmInline
112112
value class Review(val value: String) {
113113
companion object {
114-
fun newInstance(value: String): Review {
115-
require(value.isNotBlank()) { "Review cannot be blank" }
114+
fun newInstance(value: String?): Review? {
115+
if (value.isNullOrBlank()) {
116+
return null
117+
}
116118
require(value.length <= 1000) { "Review cannot exceed 1000 characters" }
117119
return Review(value)
118120
}

infra/src/main/kotlin/org/yapp/infra/readingrecord/entity/ReadingRecordEntity.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ class ReadingRecordEntity(
4848
userBookId = ReadingRecord.UserBookId.newInstance(this.userBookId),
4949
pageNumber = ReadingRecord.PageNumber.newInstance(this.pageNumber),
5050
quote = ReadingRecord.Quote.newInstance(this.quote),
51-
review = this.review?.let { ReadingRecord.Review.newInstance(it) },
51+
review = ReadingRecord.Review.newInstance(this.review),
5252
emotionTags = emptyList(),
5353
createdAt = this.createdAt,
5454
updatedAt = this.updatedAt,

0 commit comments

Comments
 (0)