correct an error in ROOT surrounding features

Author: YNedderhoff

modules/featmap.py

@@ -138,7 +138,6 @@ def give_surrounding_information(sentence, id1, id2):
     drpos = "__NULL__"
     dlform = "__NULL__"
     dlpos = "__NULL__"
-
     if id1 not in [0, 1, len(sentence)]:
         hrform = sentence[id1].form
         hrpos = sentence[id1].pos
@@ -178,16 +177,16 @@ def fm(infile):
     index = 0  # index in featmap
 
     for sentence in sentences(codecs.open(infile, encoding='utf-8')):
-
         for token1 in sentence:
             direction = "left"
             distance = give_distance(0, token1.id, direction)
-            hrform, hrpos, hlform, hlpos, drform, drpos, dlform, dlpos = "__NULL__"
+            hrform = hrpos = hlform = hlpos = drform = drpos = dlform = dlpos = "__NULL__"
 
             # add root features
             for feature in give_features("__ROOT__", "__ROOT__", "__ROOT__", token1.form, token1.lemma, token1.pos,
                                          hrform, hrpos, hlform, hlpos, drform, drpos, dlform, dlpos, direction,
                                          distance):
+                #print feature
                 if feature not in feat_map:
                     feat_map[feature] = index
                     index += 1
@@ -204,6 +203,7 @@ def fm(infile):
                 for feature in give_features(token1.form, token1.lemma, token1.pos, token2.form, token2.lemma,
                                              token2.pos, hrform, hrpos, hlform, hlpos, drform, drpos, dlform, dlpos,
                                              direction, distance):
+                    #print feature
                     if feature not in feat_map:
                         feat_map[feature] = index
                         index += 1

modules/graphs.py

@@ -52,7 +52,7 @@ def __init__(self, tokens, mode="sparse", feat_map=None, weight_vector=None):
                 if token1.head == 0:
                     direction = "left"
                     distance = give_distance(0, token1.id, direction)
-                    hrform, hrpos, hlform, hlpos, drform, drpos, dlform, dlpos = "__NULL__"
+                    hrform = hrpos = hlform = hlpos = drform = drpos = dlform = dlpos = "__NULL__"
                     new_arc = Arc("sparse", 0, token1.id)
                     if feat_map is not None:
                         new_arc.feat_vec = [f for f in (feat_map[feature] for feature in
@@ -91,7 +91,7 @@ def __init__(self, tokens, mode="sparse", feat_map=None, weight_vector=None):
 
                 direction = "left"
                 distance = give_distance(0, token1.id, direction)
-                hrform, hrpos, hlform, hlpos, drform, drpos, dlform, dlpos = "__NULL__"
+                hrform = hrpos = hlform = hlpos = drform = drpos = dlform = dlpos = "__NULL__"
 
                 if mode == "complete-sparse":
                     new_arc = Arc("sparse", 0, token1.id)

start-cle.sh

@@ -23,4 +23,4 @@ python -u dependency-parser.py -test -i $CORPORA/dev/wsj_dev_without_head.conll0
 python -u dependency-parser.py -ev -i predicted.conll06 -g $CORPORA/dev/wsj_dev.conll06 -o evaluation_sentence.txt
 
 #evaluate arc based
-#./eval07.pl -g $CORPORA/dev/wsj_dev.conll06 -s  predicted.conll06 >> evaluation.txt 2>&1
+./eval07.pl -g $CORPORA/dev/wsj_dev.conll06 -s  predicted.conll06 >> evaluation.txt 2>&1