add metatests for test failure

Author: YSaxon

CMakeLists.txt

@@ -616,6 +616,19 @@ ${CMAKE_LIBRARY_OUTPUT_DIRECTORY}/${CMAKE_SHARED_LIBRARY_PREFIX}cliffi_test${CMA
 set_tests_properties(repl_smoketest PROPERTIES PASS_REGULAR_EXPRESSION "Function returned: 3")
 set_tests_properties(repl_smoketest PROPERTIES PASS_REGULAR_EXPRESSION "Function returned: 7")
 
+add_test(NAME repl_metatest_tests_fail_on_bad_input
+COMMAND cliffi --repltest
+thisisnotagoodcommand \n
+should_not_reach_here = 1 \n
+)
+set_tests_properties(repl_metatest_tests_fail_on_bad_input PROPERTIES WILL_FAIL TRUE) # this test is expected to fail
+
+add_test(NAME repl_metatest_tests_fail_on_segfault
+COMMAND cliffi --repltest
+null_pointer = -P 0 \n
+${CMAKE_LIBRARY_OUTPUT_DIRECTORY}/${CMAKE_SHARED_LIBRARY_PREFIX}cliffi_test${CMAKE_SHARED_LIBRARY_SUFFIX} i increment_at_pointer null_pointer \n
+)
+set_tests_properties(repl_metatest_tests_fail_on_segfault PROPERTIES WILL_FAIL TRUE) # this test is expected to fail
 
 add_test(NAME repl_test_globals #
 COMMAND cliffi --repltest

cliffi_testlib.c

@@ -26,12 +26,9 @@ double multiply(double a, double b) {
 }
 
 // A function that takes a pointer to an integer, increments it, and returns the result
-int increment_at_pointer(int* a) {
-    if (a) {
-        (*a)++;
-        return *a;
-    }
-    return 0;
+int increment_at_pointer(int* a) { //deliberately unsafe
+    (*a)++;
+    return *a;
 }
 
 int* get_array_of_int(int a, size_t size) {