lints

Author: Yag000

src/cli.rs

@@ -42,7 +42,7 @@ impl Cli {
         None
     }
 
-    pub fn get_settings(&self) -> Settings {
+    #[must_use] pub fn get_settings(&self) -> Settings {
         let mut settings = get_configuration().unwrap_or_else(|_| Settings::default());
 
         if let Some(seconds) = self.get_seconds() {
@@ -56,7 +56,7 @@ impl Cli {
         settings
     }
 
-    pub fn get_action(&self) -> Actions {
+    #[must_use] pub fn get_action(&self) -> Actions {
         if self.toggle {
             return Actions::Toggle;
         }

src/path.rs

@@ -15,7 +15,7 @@ pub enum File {
 }
 
 impl File {
-    pub fn new(path: PathBuf) -> Option<Self> {
+    #[must_use] pub fn new(path: PathBuf) -> Option<Self> {
         if !path.exists() {
             None
         } else if path.is_dir() {
@@ -43,8 +43,8 @@ impl File {
 impl Display for File {
     fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
         match self {
-            Self::Image(image) => write!(f, "{}", image),
-            Self::Folder(folder) => write!(f, "{}", folder),
+            Self::Image(image) => write!(f, "{image}"),
+            Self::Folder(folder) => write!(f, "{folder}"),
         }
     }
 }
@@ -82,7 +82,7 @@ pub struct ImagePath {
 }
 
 impl ImagePath {
-    pub fn new(path: PathBuf) -> Option<Self> {
+    #[must_use] pub fn new(path: PathBuf) -> Option<Self> {
         if !path.exists() || path.is_dir() {
             None
         } else {
@@ -104,7 +104,7 @@ impl ImagePath {
     /// If it is a file it must be contained in a folder that is contained in the wallpaper directory.
     ///  
     ///  Example:
-    ///  wallpaper_dir
+    ///  `wallpaper_dir`
     ///  |--- folder1
     ///  |    |--- wallpaper1
     ///  |-- wallpaper2
@@ -125,7 +125,7 @@ impl ImagePath {
         is_animated
     }
 
-    /// Helper function for is_animated.
+    /// Helper function for `is_animated`.
     fn check_if_animated(&mut self, settings: &Settings) -> bool {
         if let Some(parent) = self.path.parent() {
             if self.path.is_dir() {
@@ -154,18 +154,18 @@ impl ImagePath {
     /// # Panics
     ///
     /// If the path is not an animated wallpaper it may panic.
-    pub fn get_animated_wallpaper_name(&self) -> String {
+    #[must_use] pub fn get_animated_wallpaper_name(&self) -> String {
         self.animated_info.as_ref().unwrap().animated_folder.clone()
     }
 
-    pub fn get_animated_number(&self) -> Option<u32> {
+    #[must_use] pub fn get_animated_number(&self) -> Option<u32> {
         if let Some(info) = self.animated_info.as_ref() {
             return Some(info.animated_number);
         }
         None
     }
 
-    pub fn path(&self) -> &Path {
+    #[must_use] pub fn path(&self) -> &Path {
         &self.path
     }
 
@@ -265,7 +265,7 @@ impl AnimatedInfo {
             .expect("failed to convert file name to str")
             .chars()
             .rev()
-            .take_while(|c| c.is_ascii_digit())
+            .take_while(char::is_ascii_digit)
             .collect::<String>()
             .chars()
             .rev()

src/setup.rs

@@ -15,14 +15,14 @@ pub fn run(settings: Settings, action: Actions) {
             Ok(wallpaper) => {
                 let path = wallpaper.to_string();
                 if let Err(err) = update_wallpaper(&settings, &path) {
-                    eprintln!("Error, {}", err);
+                    eprintln!("Error, {err}");
                 }
             }
-            Err(err) => eprintln!("Error, {}", err),
+            Err(err) => eprintln!("Error, {err}"),
         },
         Actions::Get => match get_next_wallpaper(&settings) {
-            Ok(wallpaper) => println!("{}", wallpaper),
-            Err(err) => eprintln!("Error, {}", err),
+            Ok(wallpaper) => println!("{wallpaper}"),
+            Err(err) => eprintln!("Error, {err}"),
         },
     }
 }
@@ -38,8 +38,8 @@ fn run_daemon(settings: Settings) {
         .stderr(stderr); // Redirect stderr
 
     match daemonize.start() {
-        Ok(_) => launch_wallpaper_loop(settings),
-        Err(e) => eprintln!("Error, {}", e),
+        Ok(()) => launch_wallpaper_loop(settings),
+        Err(e) => eprintln!("Error, {e}"),
     }
 }
 
@@ -49,21 +49,21 @@ fn launch_wallpaper_loop(settings: Settings) {
             Ok(mut wallpaper) => {
                 let path = wallpaper.to_string();
                 if let Err(err) = update_wallpaper(&settings, &path) {
-                    eprintln!("Error, {}", err);
+                    eprintln!("Error, {err}");
                     thread::sleep(Duration::from_secs(settings.sleep_time));
                 } else {
                     let sleep_time = match wallpaper.get_sleep_time(&settings) {
                         Ok(seconds) => seconds,
                         Err(err) => {
-                            eprintln!("Error, {}", err);
+                            eprintln!("Error, {err}");
                             settings.sleep_time
                         }
                     };
 
                     thread::sleep(Duration::from_secs(sleep_time));
                 }
             }
-            Err(err) => eprintln!("Error, {}", err),
+            Err(err) => eprintln!("Error, {err}"),
         }
     }
 }

src/wallpaper.rs

@@ -53,15 +53,15 @@ pub fn get_random_wallpaper(settings: &Settings) -> Result<File> {
     let files = read_dir(settings.wallpaper_dir.clone())?
         .filter_map(|entry| {
             if let Ok(entry) = entry {
-                if !entry
+                if entry
                     .file_name()
                     .to_str()
                     .expect("failed to convert file name to str")
                     .starts_with('.')
                 {
-                    Some(entry)
-                } else {
                     None
+                } else {
+                    Some(entry)
                 }
             } else {
                 None
@@ -121,7 +121,7 @@ pub fn get_next_animated_wallpaper(settings: &Settings, path: &File) -> Result<O
         }
     }
 
-    let base_name = format!("{name}{}", next_index);
+    let base_name = format!("{name}{next_index}");
 
     let a = read_dir(format!("{}/{name}", settings.wallpaper_dir))?.find(|s| {
         if let Ok(s) = s {