Perform silent code cleanup

Author: dmytro1morozov

demo/src/main/java/com/yalantis/starwarsdemo/adapter/ProfileAdapter.java

@@ -26,7 +26,7 @@ public class ProfileAdapter extends RecyclerView.Adapter<ProfileAdapter.ViewHold
     private static final int VIEW_TYPE_TEXT_FIELD = 1;
     private static final int VIEW_GENDER_FIELD = 2;
     private final ProfileAdapterListener mListener;
-    private User mUser;
+    private final User mUser;
 
     private final String mFullNameLabel;
     private final String mHomeWorldLabel;
@@ -87,9 +87,8 @@ public void onBindViewHolder(final ViewHolder holder, int position) {
 //            holder.getBinding().setVariable(BR.callback, mListener);
 //            holder.getBinding().setVariable(BR.user, mUser);
                 holder.mySwitch.setCheckedImmediate(mUser.isDarkSide());
-                holder.mySwitch.setOnCheckedChangeListener((CompoundButton.OnCheckedChangeListener)
-                        (buttonView, isChecked) ->
-                                mListener.onSideSwitch(holder.mySwitch));
+                holder.mySwitch.setOnCheckedChangeListener((buttonView, isChecked) ->
+                        mListener.onSideSwitch(holder.mySwitch));
                 holder.label.setText(mUser.getSideText());
                 break;
             case 1:

demo/src/main/java/com/yalantis/starwarsdemo/particlesys/ParticleSystem.java

@@ -24,7 +24,7 @@
 public class ParticleSystem implements Renderable {
     private final ParticleSystemRenderer mRenderer;
     public static final int PARTICLE_COUNT = 1_000;
-    private int mBufferId;
+    private final int mBufferId;
 
     public static final int POS_DATA_SIZE = 3;
     public static final int TEXTURE_COORDS_DATA_SIZE = 2;
@@ -39,7 +39,7 @@ public ParticleSystem(ParticleSystemRenderer renderer, FloatBuffer vertexBuffer)
         Timber.d("generated in %d ms", System.currentTimeMillis() - startTime);
 
         // Copy buffer into OpenGL's memory. After, we don't need to keep the client-side buffers around.
-        final int buffers[] = new int[1];
+        final int[] buffers = new int[1];
         glGenBuffers(1, buffers, 0);
 
         glBindBuffer(GL_ARRAY_BUFFER, buffers[0]);

demo/src/main/java/com/yalantis/starwarsdemo/particlesys/ParticleSystemRenderer.java

@@ -34,22 +34,22 @@ public class ParticleSystemRenderer implements GLSurfaceView.Renderer {
     public int sizeX = 35;
     public int sizeY = 70;
     public float mTime;
-    private GLSurfaceView mGlSurfaceView;
+    private final GLSurfaceView mGlSurfaceView;
     /**
      * Store the model matrix. This matrix is used to move models from object space (where each model can be thought
      * of being located at the center of the universe) to world space.
      */
-    private float[] mModelMatrix = new float[16];
+    private final float[] mModelMatrix = new float[16];
     /**
      * Store the view matrix. This can be thought of as our camera. This matrix transforms world space to eye space;
      * it positions things relative to our eye.
      */
-    private float[] mViewMatrix = new float[16];
+    private final float[] mViewMatrix = new float[16];
     /** Store the projection matrix. This is used to project the scene onto a 2D viewport. */
-    private float[] mProjectionMatrix = new float[16];
+    private final float[] mProjectionMatrix = new float[16];
     /** Allocate storage for the final combined matrix. This will be passed into the shader program. */
-    private float[] mMVPMatrix = new float[16];
-    private float[] mTemporaryMatrix = new float[16];
+    private final float[] mMVPMatrix = new float[16];
+    private final float[] mTemporaryMatrix = new float[16];
     private int timeHandle;
     private long mStartTime;
     private int frames;
@@ -59,7 +59,7 @@ public class ParticleSystemRenderer implements GLSurfaceView.Renderer {
     private float dt;
     private long t_current;
     private long t_prev;
-    private float dt_prev = 1;
+    private final float dt_prev = 1;
     private ValueAnimator animator;
     private Bitmap mBitmap;
     private ParticleSystem mParticleSystem;
@@ -68,7 +68,7 @@ public class ParticleSystemRenderer implements GLSurfaceView.Renderer {
     private int mHeight;
     private int timesRepeated;
     private float delta;
-    private ExecutorService mExecutor = Executors.newSingleThreadExecutor();
+    private final ExecutorService mExecutor = Executors.newSingleThreadExecutor();
 
 
     public ParticleSystemRenderer(GLSurfaceView glSurfaceView) {

demo/src/main/java/com/yalantis/starwarsdemo/view/SideFragment.java

@@ -43,7 +43,7 @@ public abstract class SideFragment extends Fragment implements ProfileAdapterLis
 
     private FragmentSideBinding binding;
 
-    private Toolbar.OnMenuItemClickListener onMenuItemClickListener = item -> {
+    private final Toolbar.OnMenuItemClickListener onMenuItemClickListener = item -> {
         if (R.id.action_close == item.getItemId()) {
             doBreak();
         }

demo/src/main/java/com/yalantis/starwarsdemo/widget/CenterTopImageView.java

@@ -3,13 +3,14 @@
 import android.content.Context;
 import android.graphics.Matrix;
 import android.util.AttributeSet;
-import android.widget.ImageView;
+
+import androidx.appcompat.widget.AppCompatImageView;
 
 /**
  * Created by Artem Kholodnyi on 11/23/15.
  */
-public class CenterTopImageView extends ImageView {
-    private Matrix matrix = new Matrix();
+public class CenterTopImageView extends AppCompatImageView {
+    private final Matrix matrix = new Matrix();
 
     public CenterTopImageView(Context context) {
         super(context);