a bunch of tiny fixes i noticed; one in particular seemed to cause a crash sometimes

Author: parisba

Runtime/Commands/Actions.cs

@@ -222,7 +222,8 @@ public CommandDispatchResult.ParameterParseStatusType TryParseArgs(string[] args
                             arg = args[i];
                             if (converter == null)
                             {
-                                paramsArray.SetValue(arg, i);
+                                // Use relative index into paramsArray
+                                paramsArray.SetValue(arg, i - paramIndex);
                             }
                             else
                             {

Runtime/LineProviders/UnityLocalisedLineProvider.Installed.cs

@@ -44,7 +44,7 @@ public string? ShadowLineSource
             {
                 foreach (var metadataEntry in tags)
                 {
-                    if (metadataEntry.StartsWith("shadow:") != false)
+                    if (metadataEntry.StartsWith("shadow:"))
                     {
                         // This is a shadow line. Return the line ID that it's
                         // shadowing.

Runtime/Storage/InMemoryVariableStorage.cs

@@ -71,10 +71,11 @@ public string GetDebugList()
             var stringBuilder = new System.Text.StringBuilder();
             foreach (KeyValuePair<string, object> item in variables)
             {
+                // .Name gets type name without namespace prefix
                 stringBuilder.AppendLine(string.Format("{0} = {1} ({2})",
                                                         item.Key,
                                                         item.Value.ToString(),
-                                                        variableTypes[item.Key].ToString().Substring("System.".Length)));
+                                                        variableTypes[item.Key].Name));
             }
             return stringBuilder.ToString();
         }

Runtime/Views/OptionsPresenter.cs

@@ -303,8 +303,11 @@ async YarnTask CancelSourceWhenDialogueCancelled()
                     {
                         // we get the substring of 0 -> markup position
                         // and replace that range with ...
-                        var end = lineText.Substring(markup.Position);
-                        lineText = "..." + end;
+                        if (markup.Position <= lineText.Length) // Bounds check
+                        {
+                            var end = lineText.Substring(markup.Position);
+                            lineText = "..." + end;
+                        }
                     }
 
                     if (lastLineText != null)

Runtime/YarnProject/LineMetadata.cs

@@ -90,7 +90,7 @@ public IEnumerable<string> GetLineIDs()
 
             foreach (var metadataEntry in metadata)
             {
-                if (metadataEntry.StartsWith("shadow:") != false)
+                if (metadataEntry.StartsWith("shadow:"))
                 {
                     // This is a shadow line. Return the line ID that it's
                     // shadowing.