added some more culture specific tests around floats

Author: McJones

Tests/TestCases/Commands.testplan

@@ -22,5 +22,6 @@ command: `show 1`
 command: `0`
 command: `2 {0}`
 command: `regular old command`
+command: `zorp 2.1`
 
 stop

Tests/TestCases/Commands.yarn

@@ -66,4 +66,6 @@ title: Start
 // another weird but allowed situation
 <<set $replacement = "ular old co">>
 <<reg{$replacement}mmand>>
+
+<<zorp {2.1}>>
 ===

YarnSpinner.Tests/MarkupTests.cs

@@ -1235,9 +1235,62 @@ public void TestMarkupMultiplePropertyParsing()
         [InlineData("[p=-1,1 /]")]
         public void TestMarkupPropertyParsingUsesInvariantNumberParsingFails(string input)
         {
-            var lineParser = new LineParser();
-            var markup = lineParser.ParseStringWithDiagnostics(input, "en");
-            markup.diagnostics.Should().ContainSingle();
+            var targetCultures = new[] {
+                "en",
+                "zh-Hans",
+                "ru",
+                "es-US",
+                "es",
+                "sw",
+                "ar",
+                "pt-BR",
+                "de",
+                "fr",
+                "fr-FR",
+                "ja",
+                "pl",
+                "ko",
+            };
+
+            foreach (var culture in targetCultures)
+            {    
+                System.Globalization.CultureInfo.CurrentCulture = new System.Globalization.CultureInfo(culture);
+                var lineParser = new LineParser();
+                var markup = lineParser.ParseStringWithDiagnostics(input, culture);
+                markup.diagnostics.Should().ContainSingle();
+            }
+        }
+
+        [Theory]
+        [InlineData("[p=1.1 /]", 1.1)]
+        [InlineData("[p=-1.1 /]",-1.1)]
+        public void TestMarkupPropertyParsingUsesInvariantNumber(string input, float propertyValue)
+        {
+            var targetCultures = new[] {
+                "en",
+                "zh-Hans",
+                "ru",
+                "es-US",
+                "es",
+                "sw",
+                "ar",
+                "pt-BR",
+                "de",
+                "fr",
+                "fr-FR",
+                "ja",
+                "pl",
+                "ko",
+            };
+
+            foreach (var culture in targetCultures)
+            {    
+                System.Globalization.CultureInfo.CurrentCulture = new System.Globalization.CultureInfo(culture);
+                var lineParser = new LineParser();
+                var markup = lineParser.ParseStringWithDiagnostics(input, culture);
+                markup.diagnostics.Should().BeEmpty();
+                markup.markup.Attributes[0].Properties["p"].FloatValue.Should().Be(propertyValue);
+            }
         }
 
 

YarnSpinner/VirtualMachine.cs

@@ -567,7 +567,6 @@ internal void RunInstruction(Instruction i)
                         // passes it to the client as a line
                         string stringKey = i.RunLine.LineID;
 
-
                         var expressionCount = i.RunLine.SubstitutionCount;
 
                         var strings = new string[expressionCount];